Message ID | 20181107153019.26401-5-daniel.vetter@ffwll.ch (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <intel-gfx-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E0BD515E9 for <patchwork-intel-gfx@patchwork.kernel.org>; Wed, 7 Nov 2018 15:30:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D19A22C63D for <patchwork-intel-gfx@patchwork.kernel.org>; Wed, 7 Nov 2018 15:30:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CFBCE2C6A3; Wed, 7 Nov 2018 15:30:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 835F82C67E for <patchwork-intel-gfx@patchwork.kernel.org>; Wed, 7 Nov 2018 15:30:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 102976E1B5; Wed, 7 Nov 2018 15:30:39 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3EA1D6E1A5 for <intel-gfx@lists.freedesktop.org>; Wed, 7 Nov 2018 15:30:33 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id x2-v6so13755633eds.3 for <intel-gfx@lists.freedesktop.org>; Wed, 07 Nov 2018 07:30:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=35SA+A3zSGOUwg2DuEDiDQyYR9o/qAXgi6nZL2aj8/Q=; b=o+yZM0vyxVbswzj97yzFbEvUFUYu/TMFkEuW0AGlHU/KmxIjfTp3k/XAfrIMFa3O+v sz7dQ6KgNpOC4C9IWjBVM80sFpyyJynph/F1VhYDWqwPOnkRfxABklG0UI2oI1F2sat2 gErpaf+WzKcvTya4FnbXqMh2GWc2Mq79Au6mNjKYyBPOqT2+tKEDMiEaDCkDwl5k5nwl f4Rm5xgT5IYBSTV3T93NXWjtPQsigbd8y6pZyxBKgbOeMZpXUI2+lGspsi4MGJBTpp93 bE5oijQPmJicxScQ3yLWwzMwSPl3mEFaotPxH9+nPsv/lrEsq6HmD9nJL9K/zvI/9PwD 9xWw== X-Gm-Message-State: AGRZ1gL9Y3EhyO/DQK7DZAeNHQA1HB6k+SEwPfx8glwghJdYrc4n11b/ auk91+7795PYV8KSb/4OMenI+qOFwYA= X-Google-Smtp-Source: AJdET5f7HN+EBJG9Y12PY//olRpyBjx62OSYjpjVIxhywE6u/lWFxMC1uqAPmNeX7RRnIa8M2jlNBA== X-Received: by 2002:aa7:d74f:: with SMTP id a15-v6mr562345eds.102.1541604631546; Wed, 07 Nov 2018 07:30:31 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id b48-v6sm322425edb.27.2018.11.07.07.30.30 for <intel-gfx@lists.freedesktop.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 07:30:30 -0800 (PST) From: Daniel Vetter <daniel.vetter@ffwll.ch> To: Intel Graphics Development <intel-gfx@lists.freedesktop.org> Date: Wed, 7 Nov 2018 16:30:11 +0100 Message-Id: <20181107153019.26401-5-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181107153019.26401-1-daniel.vetter@ffwll.ch> References: <20181107153019.26401-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 05/13] mm: Check if mmu notifier callbacks are allowed to fail X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development <intel-gfx.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/intel-gfx> List-Post: <mailto:intel-gfx@lists.freedesktop.org> List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
[01/13] locking/lockdep: restore cross-release checks
|
expand
|
diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c index 5119ff846769..59e102589a25 100644 --- a/mm/mmu_notifier.c +++ b/mm/mmu_notifier.c @@ -190,6 +190,8 @@ int __mmu_notifier_invalidate_range_start(struct mm_struct *mm, pr_info("%pS callback failed with %d in %sblockable context.\n", mn->ops->invalidate_range_start, _ret, !blockable ? "non-" : ""); + WARN(blockable,"%pS callback failure not allowed\n", + mn->ops->invalidate_range_start); ret = _ret; } }
Just a bit of paranoia, since if we start pushing this deep into callchains it's hard to spot all places where an mmu notifier implementation might fail when it's not allowed to. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Michal Hocko <mhocko@suse.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: David Rientjes <rientjes@google.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: "Jérôme Glisse" <jglisse@redhat.com> Cc: linux-mm@kvack.org Cc: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- mm/mmu_notifier.c | 2 ++ 1 file changed, 2 insertions(+)