diff mbox series

[v3,1/3] drm/i915: Reuse the aux_domain cached

Message ID 20181107235449.32264-1-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [v3,1/3] drm/i915: Reuse the aux_domain cached | expand

Commit Message

Souza, Jose Nov. 7, 2018, 11:54 p.m. UTC 
intel_dp_detect() caches the aux_domain in the beginning of the
function as it is used twice, so lets also use it as the aux_domain
don't change in runtime.

v3: returning intel_dp_retrain_link() error insted of
connector_status_disconnected

Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Imre Deak Nov. 8, 2018, 2:47 p.m. UTC | #1 
On Thu, Nov 08, 2018 at 12:25:52AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v3,1/3] drm/i915: Reuse the aux_domain cached
> URL   : https://patchwork.freedesktop.org/series/52194/
> State : failure
> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_5103 -> Patchwork_10760 =
> 
> == Summary - FAILURE ==
> 
>   Serious unknown changes coming with Patchwork_10760 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_10760, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://patchwork.freedesktop.org/api/1.0/series/52194/revisions/1/mbox/
> 
> == Possible new issues ==
> 
>   Here are the unknown changes that may have been introduced in Patchwork_10760:
> 
>   === IGT changes ===
> 
>     ==== Possible regressions ====
> 
>     igt@drv_selftest@live_hangcheck:
>       fi-skl-6700k2:      PASS -> INCOMPLETE

Network card died after a igt@kms_chamelium@common-hpd-after-suspend, since:
- https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10760/fi-skl-6700k2/run0.log
  and
  https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10760/fi-skl-6700k2/dmesg0.log
  have a mismatch wrt. which test have actually run.
- From dmesg normally you can always see the network adapter coming up
  after resume:
  [  121.090583] e1000e: enp0s31f6 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None
  but you never see this message after the above test.

  I suggest changing to another network adapter on this machine.

>       fi-bwr-2160:        PASS -> DMESG-FAIL

Unrelated system (not DDI and no DP connector on it), but also I can't
spot any issues in dmesg:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10767/fi-bwr-2160/igt@drv_selftest@live_hangcheck.html

> 
>     
> == Known issues ==
> 
>   Here are the changes found in Patchwork_10760 that come from known issues:
> 
>   === IGT changes ===
> 
>     ==== Issues hit ====
> 
>     igt@kms_chamelium@common-hpd-after-suspend:
>       fi-skl-6700k2:      PASS -> FAIL (fdo#103841)
> 
>     igt@kms_frontbuffer_tracking@basic:
>       fi-byt-clapper:     PASS -> FAIL (fdo#103167)
> 
>     igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
>       fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362)
> 
>     igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
>       fi-icl-u:           PASS -> INCOMPLETE (fdo#107713)
> 
>     
>     ==== Possible fixes ====
> 
>     igt@kms_flip@basic-flip-vs-modeset:
>       fi-hsw-4770r:       DMESG-WARN (fdo#105602) -> PASS
> 
>     igt@kms_pipe_crc_basic@read-crc-pipe-b:
>       fi-byt-clapper:     FAIL (fdo#107362) -> PASS
> 
>     igt@prime_vgem@basic-fence-flip:
>       fi-ilk-650:         FAIL (fdo#104008) -> PASS
> 
>     
>   fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
>   fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
>   fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
>   fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
>   fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
>   fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
> 
> 
> == Participating hosts (54 -> 47) ==
> 
>   Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 
> 
> 
> == Build changes ==
> 
>     * Linux: CI_DRM_5103 -> Patchwork_10760
> 
>   CI_DRM_5103: 23c1138030ad65402f698ab0b356e2f55722bc77 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_10760: f184a07eb4328798c63af8f99364319c86976885 @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> f184a07eb432 drm/i915/mst: Drop pre_pll_enable null check
> 4b47d3d89e19 drm/i915: Release DDI power well references in MST ports
> 7a48eda6125e drm/i915: Reuse the aux_domain cached
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10760/issues.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Imre Deak Nov. 8, 2018, 4:16 p.m. UTC | #2 
On Thu, Nov 08, 2018 at 04:47:50PM +0200, Imre Deak wrote:
> On Thu, Nov 08, 2018 at 12:25:52AM +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: series starting with [v3,1/3] drm/i915: Reuse the aux_domain cached
> > URL   : https://patchwork.freedesktop.org/series/52194/
> > State : failure
> > 
> > == Summary ==
> > 
> > = CI Bug Log - changes from CI_DRM_5103 -> Patchwork_10760 =
> > 
> > == Summary - FAILURE ==
> > 
> >   Serious unknown changes coming with Patchwork_10760 absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_10760, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://patchwork.freedesktop.org/api/1.0/series/52194/revisions/1/mbox/
> > 
> > == Possible new issues ==
> > 
> >   Here are the unknown changes that may have been introduced in Patchwork_10760:
> > 
> >   === IGT changes ===
> > 
> >     ==== Possible regressions ====
> > 
> >     igt@drv_selftest@live_hangcheck:
> >       fi-skl-6700k2:      PASS -> INCOMPLETE
> 
> Network card died after a igt@kms_chamelium@common-hpd-after-suspend, since:
> - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10760/fi-skl-6700k2/run0.log
>   and
>   https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10760/fi-skl-6700k2/dmesg0.log
>   have a mismatch wrt. which test have actually run.
> - From dmesg normally you can always see the network adapter coming up
>   after resume:
>   [  121.090583] e1000e: enp0s31f6 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None
>   but you never see this message after the above test.
> 
>   I suggest changing to another network adapter on this machine.
> 
> >       fi-bwr-2160:        PASS -> DMESG-FAIL
> 
> Unrelated system (not DDI and no DP connector on it), but also I can't
> spot any issues in dmesg:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10767/fi-bwr-2160/igt@drv_selftest@live_hangcheck.html

Sorry wrong link above the right one is:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10760/fi-bwr-2160/igt@drv_selftest@live_hangcheck.html
from which the failure signature looks to be:
i915/intel_hangcheck_live_selftests: igt_reset_evict_fence failed with error -5

Still can't see how it's related, and found the following previous
instances for the same error on the same machine:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10759/fi-bwr-2160/igt@drv_selftest@live_hangcheck.html
(the above is just right before the current test run, +Ville for that)
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3197/fi-bwr-2160/igt@drv_selftest@live_hangcheck.html
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3205/fi-bwr-2160/igt@drv_selftest@live_hangcheck.html

> 
> > 
> >     
> > == Known issues ==
> > 
> >   Here are the changes found in Patchwork_10760 that come from known issues:
> > 
> >   === IGT changes ===
> > 
> >     ==== Issues hit ====
> > 
> >     igt@kms_chamelium@common-hpd-after-suspend:
> >       fi-skl-6700k2:      PASS -> FAIL (fdo#103841)
> > 
> >     igt@kms_frontbuffer_tracking@basic:
> >       fi-byt-clapper:     PASS -> FAIL (fdo#103167)
> > 
> >     igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
> >       fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362)
> > 
> >     igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
> >       fi-icl-u:           PASS -> INCOMPLETE (fdo#107713)
> > 
> >     
> >     ==== Possible fixes ====
> > 
> >     igt@kms_flip@basic-flip-vs-modeset:
> >       fi-hsw-4770r:       DMESG-WARN (fdo#105602) -> PASS
> > 
> >     igt@kms_pipe_crc_basic@read-crc-pipe-b:
> >       fi-byt-clapper:     FAIL (fdo#107362) -> PASS
> > 
> >     igt@prime_vgem@basic-fence-flip:
> >       fi-ilk-650:         FAIL (fdo#104008) -> PASS
> > 
> >     
> >   fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
> >   fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
> >   fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
> >   fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
> >   fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
> >   fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
> >   fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
> > 
> > 
> > == Participating hosts (54 -> 47) ==
> > 
> >   Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 
> > 
> > 
> > == Build changes ==
> > 
> >     * Linux: CI_DRM_5103 -> Patchwork_10760
> > 
> >   CI_DRM_5103: 23c1138030ad65402f698ab0b356e2f55722bc77 @ git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >   Patchwork_10760: f184a07eb4328798c63af8f99364319c86976885 @ git://anongit.freedesktop.org/gfx-ci/linux
> > 
> > 
> > == Linux commits ==
> > 
> > f184a07eb432 drm/i915/mst: Drop pre_pll_enable null check
> > 4b47d3d89e19 drm/i915: Release DDI power well references in MST ports
> > 7a48eda6125e drm/i915: Reuse the aux_domain cached
> > 
> > == Logs ==
> > 
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10760/issues.html
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Imre Deak Nov. 9, 2018, 4:27 p.m. UTC | #3 
On Fri, Nov 09, 2018 at 03:29:27PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v3,1/3] drm/i915: Reuse the aux_domain cached
> URL   : https://patchwork.freedesktop.org/series/52194/
> State : success
> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_5105_full -> Patchwork_10778_full =
> 
> == Summary - WARNING ==
> 
>   Minor unknown changes coming with Patchwork_10778_full need to be verified
>   manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_10778_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> == Possible new issues ==
> 
>   Here are the unknown changes that may have been introduced in Patchwork_10778_full:
> 
>   === IGT changes ===
> 
>     ==== Warnings ====
> 
>     igt@perf_pmu@rc6:
>       shard-kbl:          PASS -> SKIP

Looks like https://bugs.freedesktop.org/show_bug.cgi?id=108664 .

I pushed the series to -dinq, thanks for the fix and reviews.

> 
>     
> == Known issues ==
> 
>   Here are the changes found in Patchwork_10778_full that come from known issues:
> 
>   === IGT changes ===
> 
>     ==== Issues hit ====
> 
>     igt@kms_cursor_crc@cursor-128x128-random:
>       shard-apl:          PASS -> FAIL (fdo#103232) +2
> 
>     igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
>       shard-skl:          PASS -> FAIL (fdo#103184)
> 
>     igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
>       shard-apl:          PASS -> FAIL (fdo#103167)
> 
>     igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
>       shard-glk:          PASS -> FAIL (fdo#103167) +1
> 
>     igt@kms_plane@pixel-format-pipe-b-planes:
>       shard-apl:          PASS -> FAIL (fdo#103166)
> 
>     igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
>       shard-glk:          PASS -> FAIL (fdo#103166)
> 
>     igt@pm_rpm@modeset-lpsp-stress:
>       shard-skl:          PASS -> INCOMPLETE (fdo#107807) +1
> 
>     
>     ==== Possible fixes ====
> 
>     igt@drm_import_export@import-close-race-flink:
>       shard-skl:          TIMEOUT (fdo#108667) -> PASS
> 
>     igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
>       shard-skl:          DMESG-WARN (fdo#107956) -> PASS
> 
>     igt@kms_color@pipe-b-legacy-gamma:
>       shard-apl:          FAIL (fdo#104782) -> PASS
> 
>     igt@kms_cursor_crc@cursor-256x256-suspend:
>       shard-apl:          FAIL (fdo#103232, fdo#103191) -> PASS
> 
>     igt@kms_cursor_crc@cursor-64x64-random:
>       shard-glk:          FAIL (fdo#103232) -> PASS
> 
>     igt@kms_cursor_crc@cursor-size-change:
>       shard-apl:          FAIL (fdo#103232) -> PASS
> 
>     igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
>       shard-glk:          FAIL (fdo#105363) -> PASS
> 
>     igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
>       shard-apl:          FAIL (fdo#103167) -> PASS +1
> 
>     igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
>       shard-glk:          FAIL (fdo#103167) -> PASS +2
> 
>     igt@kms_frontbuffer_tracking@psr-suspend:
>       shard-skl:          INCOMPLETE (fdo#106978, fdo#104108, fdo#107773) -> PASS
> 
>     igt@kms_plane@plane-position-covered-pipe-b-planes:
>       shard-glk:          FAIL (fdo#103166) -> PASS
> 
>     igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
>       shard-apl:          FAIL (fdo#103166) -> PASS +1
> 
>     
>   fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
>   fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
>   fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
>   fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
>   fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   fdo#106978 https://bugs.freedesktop.org/show_bug.cgi?id=106978
>   fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
>   fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
>   fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
>   fdo#108667 https://bugs.freedesktop.org/show_bug.cgi?id=108667
> 
> 
> == Participating hosts (6 -> 6) ==
> 
>   No changes in participating hosts
> 
> 
> == Build changes ==
> 
>     * Linux: CI_DRM_5105 -> Patchwork_10778
> 
>   CI_DRM_5105: e44a1cc644d1719d195bd0afb9e319ae555059e1 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_10778: 0bf78b3561dcad33f6af786b617b373e91354a84 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10778/shards.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 5258c9d654f4..2b090609bee2 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -5169,8 +5169,7 @@  intel_dp_detect(struct drm_connector *connector,
 
 		ret = intel_dp_retrain_link(encoder, ctx);
 		if (ret) {
-			intel_display_power_put(dev_priv,
-						intel_aux_power_domain(dig_port));
+			intel_display_power_put(dev_priv, aux_domain);
 			return ret;
 		}
 	}