| Message ID | 20181109202016.18920-6-jose.souza@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] drm/i915: Avoid a full port detection in the first eDP short pulse | expand |
On Fri, Nov 09, 2018 at 12:20:15PM -0800, José Roberto de Souza wrote: > We should not access hardware while computing config also we don't > support stereo 3D so this tests was never true. yeap... it was there becase at some point we were planing to enabled that S3D and if that happen we would easily forgot about the PSR case and have bad bugs. But I don't see that happening any time soon, so, let's clean it up. Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/intel_psr.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c > index e505b0b9ae47..853e3f1370a0 100644 > --- a/drivers/gpu/drm/i915/intel_psr.c > +++ b/drivers/gpu/drm/i915/intel_psr.c > @@ -533,13 +533,6 @@ void intel_psr_compute_config(struct intel_dp *intel_dp, > return; > } > > - if (IS_HASWELL(dev_priv) && > - I915_READ(HSW_STEREO_3D_CTL(crtc_state->cpu_transcoder)) & > - S3D_ENABLE) { > - DRM_DEBUG_KMS("PSR condition failed: Stereo 3D is Enabled\n"); > - return; > - } > - > if (IS_HASWELL(dev_priv) && > adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) { > DRM_DEBUG_KMS("PSR condition failed: Interlaced is Enabled\n"); > -- > 2.19.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index e505b0b9ae47..853e3f1370a0 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -533,13 +533,6 @@ void intel_psr_compute_config(struct intel_dp *intel_dp, return; } - if (IS_HASWELL(dev_priv) && - I915_READ(HSW_STEREO_3D_CTL(crtc_state->cpu_transcoder)) & - S3D_ENABLE) { - DRM_DEBUG_KMS("PSR condition failed: Stereo 3D is Enabled\n"); - return; - } - if (IS_HASWELL(dev_priv) && adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) { DRM_DEBUG_KMS("PSR condition failed: Interlaced is Enabled\n");
We should not access hardware while computing config also we don't support stereo 3D so this tests was never true. Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: José Roberto de Souza <jose.souza@intel.com> --- drivers/gpu/drm/i915/intel_psr.c | 7 ------- 1 file changed, 7 deletions(-)