diff mbox series

[04/15] drm/i915/tv: Fix tv mode clocks

Message ID 20181112170000.27531-5-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Fix TV encoder support | expand

Commit Message

Ville Syrjälä Nov. 12, 2018, 4:59 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The oversample clock is always supposed to be either 108 MHz
or 148.5 MHz. Make it so.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_tv.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Imre Deak Jan. 22, 2019, 12:56 p.m. UTC | #1 
On Mon, Nov 12, 2018 at 06:59:48PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The oversample clock is always supposed to be either 108 MHz
> or 148.5 MHz. Make it so.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Matches the spec:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_tv.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
> index 219a16d6dcc2..dea24ef88763 100644
> --- a/drivers/gpu/drm/i915/intel_tv.c
> +++ b/drivers/gpu/drm/i915/intel_tv.c
> @@ -636,7 +636,7 @@ static const struct tv_mode tv_modes[] = {
>  	},
>  	{
>  		.name       = "480p",
> -		.clock		= 107520,
> +		.clock		= 108000,
>  		.refresh	= 59940,
>  		.oversample     = TV_OVERSAMPLE_4X,
>  		.component_only = 1,
> @@ -660,7 +660,7 @@ static const struct tv_mode tv_modes[] = {
>  	},
>  	{
>  		.name       = "576p",
> -		.clock		= 107520,
> +		.clock		= 108000,
>  		.refresh	= 50000,
>  		.oversample     = TV_OVERSAMPLE_4X,
>  		.component_only = 1,
> @@ -684,7 +684,7 @@ static const struct tv_mode tv_modes[] = {
>  	},
>  	{
>  		.name       = "720p@60Hz",
> -		.clock		= 148800,
> +		.clock		= 148500,
>  		.refresh	= 60000,
>  		.oversample     = TV_OVERSAMPLE_2X,
>  		.component_only = 1,
> @@ -708,7 +708,7 @@ static const struct tv_mode tv_modes[] = {
>  	},
>  	{
>  		.name       = "720p@50Hz",
> -		.clock		= 148800,
> +		.clock		= 148500,
>  		.refresh	= 50000,
>  		.oversample     = TV_OVERSAMPLE_2X,
>  		.component_only = 1,
> @@ -733,7 +733,7 @@ static const struct tv_mode tv_modes[] = {
>  	},
>  	{
>  		.name       = "1080i@50Hz",
> -		.clock		= 148800,
> +		.clock		= 148500,
>  		.refresh	= 50000,
>  		.oversample     = TV_OVERSAMPLE_2X,
>  		.component_only = 1,
> @@ -759,7 +759,7 @@ static const struct tv_mode tv_modes[] = {
>  	},
>  	{
>  		.name       = "1080i@60Hz",
> -		.clock		= 148800,
> +		.clock		= 148500,
>  		.refresh	= 60000,
>  		.oversample     = TV_OVERSAMPLE_2X,
>  		.component_only = 1,
> @@ -1114,7 +1114,7 @@ static void intel_tv_pre_enable(struct intel_encoder *encoder,
>  static const struct drm_display_mode reported_modes[] = {
>  	{
>  		.name = "NTSC 480i",
> -		.clock = 107520,
> +		.clock = 108000,
>  		.hdisplay = 1280,
>  		.hsync_start = 1368,
>  		.hsync_end = 1496,
> -- 
> 2.18.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index 219a16d6dcc2..dea24ef88763 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -636,7 +636,7 @@  static const struct tv_mode tv_modes[] = {
 	},
 	{
 		.name       = "480p",
-		.clock		= 107520,
+		.clock		= 108000,
 		.refresh	= 59940,
 		.oversample     = TV_OVERSAMPLE_4X,
 		.component_only = 1,
@@ -660,7 +660,7 @@  static const struct tv_mode tv_modes[] = {
 	},
 	{
 		.name       = "576p",
-		.clock		= 107520,
+		.clock		= 108000,
 		.refresh	= 50000,
 		.oversample     = TV_OVERSAMPLE_4X,
 		.component_only = 1,
@@ -684,7 +684,7 @@  static const struct tv_mode tv_modes[] = {
 	},
 	{
 		.name       = "720p@60Hz",
-		.clock		= 148800,
+		.clock		= 148500,
 		.refresh	= 60000,
 		.oversample     = TV_OVERSAMPLE_2X,
 		.component_only = 1,
@@ -708,7 +708,7 @@  static const struct tv_mode tv_modes[] = {
 	},
 	{
 		.name       = "720p@50Hz",
-		.clock		= 148800,
+		.clock		= 148500,
 		.refresh	= 50000,
 		.oversample     = TV_OVERSAMPLE_2X,
 		.component_only = 1,
@@ -733,7 +733,7 @@  static const struct tv_mode tv_modes[] = {
 	},
 	{
 		.name       = "1080i@50Hz",
-		.clock		= 148800,
+		.clock		= 148500,
 		.refresh	= 50000,
 		.oversample     = TV_OVERSAMPLE_2X,
 		.component_only = 1,
@@ -759,7 +759,7 @@  static const struct tv_mode tv_modes[] = {
 	},
 	{
 		.name       = "1080i@60Hz",
-		.clock		= 148800,
+		.clock		= 148500,
 		.refresh	= 60000,
 		.oversample     = TV_OVERSAMPLE_2X,
 		.component_only = 1,
@@ -1114,7 +1114,7 @@  static void intel_tv_pre_enable(struct intel_encoder *encoder,
 static const struct drm_display_mode reported_modes[] = {
 	{
 		.name = "NTSC 480i",
-		.clock = 107520,
+		.clock = 108000,
 		.hdisplay = 1280,
 		.hsync_start = 1368,
 		.hsync_end = 1496,