| Message ID | 20181116144447.7836-1-joonas.lahtinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Hide enable_gvt modparam when not compiled in | expand |
Quoting Joonas Lahtinen (2018-11-16 14:44:47) > Hide the enable_gvt modparam in the default scenario where > support has not been compiled in. > > Cc: Zhenyu Wang <zhenyuw@linux.intel.com> > Cc: Zhi Wang <zhi.a.wang@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Alternative would be to move the param into a gvt-only file.c Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Random thought: Also a lot of the error state will be garbage for gvt clients. -Chris
On 2018.11.16 16:44:47 +0200, Joonas Lahtinen wrote: > Hide the enable_gvt modparam in the default scenario where > support has not been compiled in. > > Cc: Zhenyu Wang <zhenyuw@linux.intel.com> > Cc: Zhi Wang <zhi.a.wang@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_params.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 8d71886b5f03..2e0356561839 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -167,8 +167,10 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400, > i915_param_named(enable_dpcd_backlight, bool, 0600, > "Enable support for DPCD backlight control (default:false)"); > > +#if IS_ENABLED(CONFIG_DRM_I915_GVT) > i915_param_named(enable_gvt, bool, 0400, > "Enable support for Intel GVT-g graphics virtualization host support(default:false)"); > +#endif > > static __always_inline void _print_param(struct drm_printer *p, > const char *name, I'm thinking we'd better to remove gvt parameter but depends on kernel config only in considering of current state and be easier to try, or better to be handled by gvt module split which will remove this anyway, so Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Thanks for the reviews, pushed now. Regards, Joonas Quoting Patchwork (2018-11-16 17:31:58) > == Series Details == > > Series: drm/i915: Hide enable_gvt modparam when not compiled in > URL : https://patchwork.freedesktop.org/series/52616/ > State : success > > == Summary == > > = CI Bug Log - changes from CI_DRM_5151 -> Patchwork_10841 = > > == Summary - SUCCESS == > > No regressions found. > > External URL: https://patchwork.freedesktop.org/api/1.0/series/52616/revisions/1/mbox/ > > == Possible new issues == > > Here are the unknown changes that may have been introduced in Patchwork_10841: > > === IGT changes === > > ==== Possible regressions ==== > > {igt@runner@aborted}: > fi-icl-u: NOTRUN -> FAIL > > > == Known issues == > > Here are the changes found in Patchwork_10841 that come from known issues: > > === IGT changes === > > ==== Issues hit ==== > > igt@gem_exec_suspend@basic-s3: > fi-icl-u2: PASS -> DMESG-WARN (fdo#107724) > > > ==== Possible fixes ==== > > igt@i915_selftest@live_coherency: > fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS > > igt@i915_selftest@live_hangcheck: > fi-skl-iommu: INCOMPLETE (fdo#108602) -> PASS > > igt@kms_frontbuffer_tracking@basic: > fi-hsw-peppy: DMESG-WARN (fdo#102614) -> PASS > fi-byt-clapper: FAIL (fdo#103167) -> PASS > > igt@kms_pipe_crc_basic@read-crc-pipe-a: > fi-byt-clapper: FAIL (fdo#107362) -> PASS > > > ==== Warnings ==== > > igt@i915_selftest@live_contexts: > fi-icl-u: DMESG-FAIL (fdo#108569) -> INCOMPLETE (fdo#108315) > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614 > fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167 > fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164 > fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362 > fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724 > fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315 > fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569 > fdo#108602 https://bugs.freedesktop.org/show_bug.cgi?id=108602 > > > == Participating hosts (48 -> 46) == > > Additional (1): fi-byt-j1900 > Missing (3): fi-ilk-m540 fi-byt-squawks fi-hsw-4200u > > > == Build changes == > > * Linux: CI_DRM_5151 -> Patchwork_10841 > > CI_DRM_5151: 65d1ff82ff3c9c20c78bd66f19f0f20f0fd46c4e @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_4718: 8ac5cfb4db9c7bc593beec18a6be1e2ff163106c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_10841: fa91c9f62ba9c96a7b2f86dcd39c7e6617918805 @ git://anongit.freedesktop.org/gfx-ci/linux > > > == Linux commits == > > fa91c9f62ba9 drm/i915: Hide enable_gvt modparam when not compiled in > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10841/issues.html
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 8d71886b5f03..2e0356561839 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -167,8 +167,10 @@ i915_param_named_unsafe(inject_load_failure, uint, 0400, i915_param_named(enable_dpcd_backlight, bool, 0600, "Enable support for DPCD backlight control (default:false)"); +#if IS_ENABLED(CONFIG_DRM_I915_GVT) i915_param_named(enable_gvt, bool, 0400, "Enable support for Intel GVT-g graphics virtualization host support(default:false)"); +#endif static __always_inline void _print_param(struct drm_printer *p, const char *name,
Hide the enable_gvt modparam in the default scenario where support has not been compiled in. Cc: Zhenyu Wang <zhenyuw@linux.intel.com> Cc: Zhi Wang <zhi.a.wang@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 ++ 1 file changed, 2 insertions(+)