| Message ID | 20181121151653.24595-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Show waiter's status on engine dump | expand |
On 21/11/2018 15:16, Chris Wilson wrote: > When showing the list of waiters, include the task's status so that we > can tell if they have been woken up and are waiting for the CPU, or if > they are still waiting to be woken. > > v2: task_state_to_char() > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > --- > drivers/gpu/drm/i915/intel_engine_cs.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c > index 885a901b6e13..99b05fc3bb24 100644 > --- a/drivers/gpu/drm/i915/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/intel_engine_cs.c > @@ -1562,8 +1562,10 @@ void intel_engine_dump(struct intel_engine_cs *engine, > for (rb = rb_first(&b->waiters); rb; rb = rb_next(rb)) { > struct intel_wait *w = rb_entry(rb, typeof(*w), node); > > - drm_printf(m, "\t%s [%d] waiting for %x\n", > - w->tsk->comm, w->tsk->pid, w->seqno); > + drm_printf(m, "\t%s [%d] (%c) waiting for %x\n", > + w->tsk->comm, w->tsk->pid, > + task_state_to_char(w->tsk), > + w->seqno); > } > spin_unlock(&b->rb_lock); > local_irq_restore(flags); > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c index 885a901b6e13..99b05fc3bb24 100644 --- a/drivers/gpu/drm/i915/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/intel_engine_cs.c @@ -1562,8 +1562,10 @@ void intel_engine_dump(struct intel_engine_cs *engine, for (rb = rb_first(&b->waiters); rb; rb = rb_next(rb)) { struct intel_wait *w = rb_entry(rb, typeof(*w), node); - drm_printf(m, "\t%s [%d] waiting for %x\n", - w->tsk->comm, w->tsk->pid, w->seqno); + drm_printf(m, "\t%s [%d] (%c) waiting for %x\n", + w->tsk->comm, w->tsk->pid, + task_state_to_char(w->tsk), + w->seqno); } spin_unlock(&b->rb_lock); local_irq_restore(flags);
When showing the list of waiters, include the task's status so that we can tell if they have been woken up and are waiting for the CPU, or if they are still waiting to be woken. v2: task_state_to_char() Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- drivers/gpu/drm/i915/intel_engine_cs.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)