diff mbox series

drm/i915: Dial down workaround debug messages

Message ID 20181204171530.28583-1-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Dial down workaround debug messages | expand

Commit Message

Tvrtko Ursulin Dec. 4, 2018, 5:15 p.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

For selftests like live_hangcheck, which does thousands of reset per
second, it is too verbose to log every time we re-apply the workarounds.

Remove those messages since, coupled with the dedicated selftest, it is
sufficient to only log the number of recorded workarounds at init time.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_workarounds.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Chris Wilson Dec. 4, 2018, 5:20 p.m. UTC | #1 
Quoting Tvrtko Ursulin (2018-12-04 17:15:30)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> For selftests like live_hangcheck, which does thousands of reset per
> second, it is too verbose to log every time we re-apply the workarounds.
> 
> Remove those messages since, coupled with the dedicated selftest, it is
> sufficient to only log the number of recorded workarounds at init time.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>

Ta, 
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Chris Wilson Dec. 4, 2018, 6:59 p.m. UTC | #2 
Quoting Patchwork (2018-12-04 18:35:08)
> == Series Details ==
> 
> Series: drm/i915: Dial down workaround debug messages
> URL   : https://patchwork.freedesktop.org/series/53490/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_5260 -> Patchwork_11011
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.

Applied before Tomi notices and complains. Thanks,
-Chris
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
index 4f41e326f3f3..6bcac78a9c36 100644
--- a/drivers/gpu/drm/i915/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/intel_workarounds.c
@@ -955,8 +955,6 @@  wa_list_apply(struct drm_i915_private *dev_priv, const struct i915_wa_list *wal)
 
 	intel_uncore_forcewake_put__locked(dev_priv, fw);
 	spin_unlock_irqrestore(&dev_priv->uncore.lock, flags);
-
-	DRM_DEBUG_DRIVER("Applied %u %s workarounds\n", wal->count, wal->name);
 }
 
 void intel_gt_apply_workarounds(struct drm_i915_private *dev_priv)
@@ -1126,8 +1124,6 @@  void intel_engine_apply_whitelist(struct intel_engine_cs *engine)
 	for (; i < RING_MAX_NONPRIV_SLOTS; i++)
 		I915_WRITE(RING_FORCE_TO_NONPRIV(base, i),
 			   i915_mmio_reg_offset(RING_NOPID(base)));
-
-	DRM_DEBUG_DRIVER("Applied %u %s workarounds\n", wal->count, wal->name);
 }
 
 static void rcs_engine_wa_init(struct intel_engine_cs *engine)