From patchwork Thu Jan 24 16:58:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10779615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1AE0C1515 for ; Thu, 24 Jan 2019 16:59:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C11D531181 for ; Thu, 24 Jan 2019 16:59:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AE333311E6; Thu, 24 Jan 2019 16:59:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 54E5131181 for ; Thu, 24 Jan 2019 16:59:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FD486F1D5; Thu, 24 Jan 2019 16:59:15 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCC8C6F1C7 for ; Thu, 24 Jan 2019 16:59:10 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id h15so5158037edb.4 for ; Thu, 24 Jan 2019 08:59:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NRYJ8qohWihltl8r99SAklEQhhr5LjjBf+C3cHaroek=; b=JMhhVEMkXu9yG8wAAJktNMsyIRRIgY42phNdsT1dhcamIm20c5tGDlYJv3uCS40ztj Zksev/nSSm+/XE7usREBHBrqWArZL3B9BnSQ7lq5d5qviThpP0eBRvu0qEcvC7ctLK0K NYSI2PZLN91leeJtI0nkTzlAjfJ5CAgmOLIqNU4kUiM48J5QK1ebZEW4Imz2ywHSeqqr JEZ5RMnZ708cwZYdDhTkH588TuXTZ9N88XrWwlaR2n8jpG3Lo4bqR0RncWN2scRCIoWW z4ojgXfGsbv2icwBV0bl5yzlClu8lZsGqGocnMs7oLHhdeJ1IVeUGwruUt4YWJNSd6tw +lSA== X-Gm-Message-State: AJcUukf2r5dDh2yYkxvJ7rkGKhQbbs7fSM+36Vo5yxe8b9RZrK1EFGlt 1T30xtQ7a1zFDBEuFpRPREqTtw== X-Google-Smtp-Source: ALg8bN7nNNeCbDedMh3CyLWPhQaBsnurzL5P+HbVkColv3njfo7R31Ix6dbdjTEmW8uEoJgmKnjqNQ== X-Received: by 2002:a17:906:27d3:: with SMTP id k19mr1052422ejc.154.1548349148752; Thu, 24 Jan 2019 08:59:08 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w31sm11219233edw.82.2019.01.24.08.59.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:59:07 -0800 (PST) From: Daniel Vetter To: DRI Development Date: Thu, 24 Jan 2019 17:58:24 +0100 Message-Id: <20190124165831.16427-20-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124165831.16427-1-daniel.vetter@ffwll.ch> References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 19/26] drm/qxl: Use drm_fb_helper_fill_info X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: spice-devel@lists.freedesktop.org, Daniel Vetter , Intel Graphics Development , virtualization@lists.linux-foundation.org, Gerd Hoffmann , Daniel Vetter , Dave Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP This should not result in any changes. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org Cc: spice-devel@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_fb.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c index d028471597ef..22dc9a7a643b 100644 --- a/drivers/gpu/drm/qxl/qxl_fb.c +++ b/drivers/gpu/drm/qxl/qxl_fb.c @@ -219,8 +219,6 @@ static int qxlfb_create(struct drm_fb_helper *helper, goto out_unref; } - info->par = helper; - fb = drm_gem_fbdev_fb_create(&qdev->ddev, sizes, 64, gobj, &qxlfb_fb_funcs); if (IS_ERR(fb)) { @@ -232,10 +230,6 @@ static int qxlfb_create(struct drm_fb_helper *helper, /* setup helper with fb data */ qdev->fb_helper.fb = fb; - strcpy(info->fix.id, "qxldrmfb"); - - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); - info->fbops = &qxlfb_ops; /* @@ -247,8 +241,7 @@ static int qxlfb_create(struct drm_fb_helper *helper, info->screen_base = shadow; info->screen_size = gobj->size; - drm_fb_helper_fill_var(info, &qdev->fb_helper, sizes->fb_width, - sizes->fb_height); + drm_fb_helper_fill_info(info, &qdev->fb_helper); /* setup aperture base/size for vesafb takeover */ info->apertures->ranges[0].base = qdev->ddev.mode_config.fb_base;