From patchwork Thu Jan 24 16:58:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10779629 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1A26417F0 for ; Thu, 24 Jan 2019 17:00:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01683310D4 for ; Thu, 24 Jan 2019 17:00:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EA12A311FA; Thu, 24 Jan 2019 17:00:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A2A58310D4 for ; Thu, 24 Jan 2019 17:00:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31D3B6F1EA; Thu, 24 Jan 2019 16:59:18 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC7036F1D4 for ; Thu, 24 Jan 2019 16:59:15 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id g22so5151475edr.7 for ; Thu, 24 Jan 2019 08:59:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fp1C/+4GE67gkaUF1IXPEiFlAtDyLhIZQ9A3rmhlSA0=; b=bsDcMS33kfS2YKZVzrnVCtZ0NqfLAum1+P8w/yKyT3LwFmhhVQT1Dq16kiDpB6Regy zmFBQeTd53oWD58SXK/3i3GJqs6MSgH2dhm0GyIjmdDY3Z5YVJHgSJzP2a3ZJwVf7RuA KPYoyZIkud7inbJDVTcJGK8Kh6TNvlDMWpgstx1DtDCr/NaxjsDyX89mM1l5HE+O25gU zteRrHrtoQzgbujbU25jhuswLrulPD72ys6UmVLcYX7AEyRA84S0sMXPWfcCQrulZUd4 Bfl1wiZIEkbzWm6i4sH8iHhZZURSOS9aRQ1qCNWb78wB0siHU1Pe+PfDJEAviSI3GBjM Sp+Q== X-Gm-Message-State: AJcUukf651I3CclmaPGY7XOhQBvuIF8jNj3/gMsuFkNQISReLV4pBijJ aA5iD4XI1XZGOBsL29+q/PBKNQPUTTQ= X-Google-Smtp-Source: ALg8bN5Z+0uZpaFK4VkkIY1//UZcgCgoQYRDYFMTOx+Tek7VJgnBrF27FPED8tlaj/drrzW8wYsItw== X-Received: by 2002:a50:b5a5:: with SMTP id a34mr7359577ede.52.1548349153790; Thu, 24 Jan 2019 08:59:13 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w31sm11219233edw.82.2019.01.24.08.59.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:59:12 -0800 (PST) From: Daniel Vetter To: DRI Development Date: Thu, 24 Jan 2019 17:58:27 +0100 Message-Id: <20190124165831.16427-23-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124165831.16427-1-daniel.vetter@ffwll.ch> References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Jonathan Hunter , linux-tegra@vger.kernel.org, Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Another driver that didn't set fbinfo->fix.id before. Signed-off-by: Daniel Vetter Cc: Thierry Reding Cc: Jonathan Hunter Cc: linux-tegra@vger.kernel.org Acked-by: Thierry Reding --- drivers/gpu/drm/tegra/fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 5ee48a6bb3ad..82348ddd0b83 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -255,12 +255,10 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, helper->fb = fb; helper->fbdev = info; - info->par = helper; info->flags = FBINFO_FLAG_DEFAULT; info->fbops = &tegra_fb_ops; - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(info, helper, fb->width, fb->height); + drm_fb_helper_fill_info(info, helper); offset = info->var.xoffset * bytes_per_pixel + info->var.yoffset * fb->pitches[0];