diff mbox series

[i-g-t,8/8] intel-ci: Drop gem_exec_nop from BAT

Message ID 20190130095500.23596-8-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series [i-g-t,1/8] lib: Skip unused fork helpers | expand

Commit Message

Chris Wilson Jan. 30, 2019, 9:55 a.m. UTC
This pair, gem_exec_nop/{series,parallel}, are very light stress tests
of which we already perform the same sequence inside
i915_selftests/live_requests. We keep basic uABI coverage (i.e. plain
old gem_execbuf) via the likes of gem_exec_basic and gem_exec_reloc so
all gem_exec_nop adds are nefarious HW details, much less likely to spot
if a test is of sound quality for further testing (and again, we have
alternate coverage of the same HW stress).

Between the pair of subtests, gem_exec_nop takes about 20s of BAT.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 2 --
 1 file changed, 2 deletions(-)

Comments

Mika Kuoppala Jan. 30, 2019, 11:12 a.m. UTC | #1
Chris Wilson <chris@chris-wilson.co.uk> writes:

> This pair, gem_exec_nop/{series,parallel}, are very light stress tests
> of which we already perform the same sequence inside
> i915_selftests/live_requests. We keep basic uABI coverage (i.e. plain
> old gem_execbuf) via the likes of gem_exec_basic and gem_exec_reloc so
> all gem_exec_nop adds are nefarious HW details, much less likely to spot
> if a test is of sound quality for further testing (and again, we have
> alternate coverage of the same HW stress).
>
> Between the pair of subtests, gem_exec_nop takes about 20s of BAT.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>

I was going to say that I have already stamped this.
But re-checking the previous submission, I haven't.
Perhaps I forgot to press send.

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/intel-ci/fast-feedback.testlist | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index da3c4c8ed..a95d2e95c 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -43,8 +43,6 @@ igt@gem_exec_fence@basic-wait-default
>  igt@gem_exec_fence@basic-await-default
>  igt@gem_exec_fence@nb-await-default
>  igt@gem_exec_gttfill@basic
> -igt@gem_exec_nop@basic-parallel
> -igt@gem_exec_nop@basic-series
>  igt@gem_exec_parallel@basic
>  igt@gem_exec_parse@basic-allowed
>  igt@gem_exec_parse@basic-rejected
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index da3c4c8ed..a95d2e95c 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -43,8 +43,6 @@  igt@gem_exec_fence@basic-wait-default
 igt@gem_exec_fence@basic-await-default
 igt@gem_exec_fence@nb-await-default
 igt@gem_exec_gttfill@basic
-igt@gem_exec_nop@basic-parallel
-igt@gem_exec_nop@basic-series
 igt@gem_exec_parallel@basic
 igt@gem_exec_parse@basic-allowed
 igt@gem_exec_parse@basic-rejected