diff mbox series

drm/i915/gvt: Fix kerneldoc typo for intel_vgpu_emulate_hotplug

Message ID 20190205203033.5477-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series drm/i915/gvt: Fix kerneldoc typo for intel_vgpu_emulate_hotplug | expand

Commit Message

Chris Wilson Feb. 5, 2019, 8:30 p.m. UTC
drivers/gpu/drm/i915/gvt/display.c:457: warning: Function parameter or member 'connected' not described in 'intel_vgpu_emulate_hotplug'
drivers/gpu/drm/i915/gvt/display.c:457: warning: Excess function parameter 'conncted' description in 'intel_vgpu_emulate_hotplug'

Fixes: 1ca20f33df42 ("drm/i915/gvt: add hotplug emulation")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Hang Yuan <hang.yuan@linux.intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
---
 drivers/gpu/drm/i915/gvt/display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhenyu Wang Feb. 18, 2019, 8:59 a.m. UTC | #1
On 2019.02.05 20:30:33 +0000, Chris Wilson wrote:
> drivers/gpu/drm/i915/gvt/display.c:457: warning: Function parameter or member 'connected' not described in 'intel_vgpu_emulate_hotplug'
> drivers/gpu/drm/i915/gvt/display.c:457: warning: Excess function parameter 'conncted' description in 'intel_vgpu_emulate_hotplug'
> 
> Fixes: 1ca20f33df42 ("drm/i915/gvt: add hotplug emulation")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Hang Yuan <hang.yuan@linux.intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/display.c b/drivers/gpu/drm/i915/gvt/display.c
> index 035479e273be..e3f9caa7839f 100644
> --- a/drivers/gpu/drm/i915/gvt/display.c
> +++ b/drivers/gpu/drm/i915/gvt/display.c
> @@ -448,7 +448,7 @@ void intel_gvt_emulate_vblank(struct intel_gvt *gvt)
>  /**
>   * intel_vgpu_emulate_hotplug - trigger hotplug event for vGPU
>   * @vgpu: a vGPU
> - * @conncted: link state
> + * @connected: link state
>   *
>   * This function is used to trigger hotplug interrupt for vGPU
>   *
> -- 

Thanks! Applied this, sorry to miss the check..
Zhenyu Wang March 22, 2019, 8:18 a.m. UTC | #2
On 2019.03.22 08:18:33 +0000, Chris Wilson wrote:
> Quoting Zhenyu Wang (2019-02-18 08:59:07)
> > On 2019.02.05 20:30:33 +0000, Chris Wilson wrote:
> > > drivers/gpu/drm/i915/gvt/display.c:457: warning: Function parameter or member 'connected' not described in 'intel_vgpu_emulate_hotplug'
> > > drivers/gpu/drm/i915/gvt/display.c:457: warning: Excess function parameter 'conncted' description in 'intel_vgpu_emulate_hotplug'
> > > 
> > > Fixes: 1ca20f33df42 ("drm/i915/gvt: add hotplug emulation")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Hang Yuan <hang.yuan@linux.intel.com>
> > > Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> > > Cc: Zhi Wang <zhi.a.wang@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/gvt/display.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/gvt/display.c b/drivers/gpu/drm/i915/gvt/display.c
> > > index 035479e273be..e3f9caa7839f 100644
> > > --- a/drivers/gpu/drm/i915/gvt/display.c
> > > +++ b/drivers/gpu/drm/i915/gvt/display.c
> > > @@ -448,7 +448,7 @@ void intel_gvt_emulate_vblank(struct intel_gvt *gvt)
> > >  /**
> > >   * intel_vgpu_emulate_hotplug - trigger hotplug event for vGPU
> > >   * @vgpu: a vGPU
> > > - * @conncted: link state
> > > + * @connected: link state
> > >   *
> > >   * This function is used to trigger hotplug interrupt for vGPU
> > >   *
> > > -- 
> > 
> > Thanks! Applied this, sorry to miss the check..
> 
> Still present after the recent gvt merges.

oops, I was pushing this to gvt-next-fixes, but didn't actually
generate the -next-fixes for other dependence. I'll include this
for next pull. Sorry about that.
Chris Wilson March 22, 2019, 8:18 a.m. UTC | #3
Quoting Zhenyu Wang (2019-02-18 08:59:07)
> On 2019.02.05 20:30:33 +0000, Chris Wilson wrote:
> > drivers/gpu/drm/i915/gvt/display.c:457: warning: Function parameter or member 'connected' not described in 'intel_vgpu_emulate_hotplug'
> > drivers/gpu/drm/i915/gvt/display.c:457: warning: Excess function parameter 'conncted' description in 'intel_vgpu_emulate_hotplug'
> > 
> > Fixes: 1ca20f33df42 ("drm/i915/gvt: add hotplug emulation")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Hang Yuan <hang.yuan@linux.intel.com>
> > Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> > Cc: Zhi Wang <zhi.a.wang@intel.com>
> > ---
> >  drivers/gpu/drm/i915/gvt/display.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gvt/display.c b/drivers/gpu/drm/i915/gvt/display.c
> > index 035479e273be..e3f9caa7839f 100644
> > --- a/drivers/gpu/drm/i915/gvt/display.c
> > +++ b/drivers/gpu/drm/i915/gvt/display.c
> > @@ -448,7 +448,7 @@ void intel_gvt_emulate_vblank(struct intel_gvt *gvt)
> >  /**
> >   * intel_vgpu_emulate_hotplug - trigger hotplug event for vGPU
> >   * @vgpu: a vGPU
> > - * @conncted: link state
> > + * @connected: link state
> >   *
> >   * This function is used to trigger hotplug interrupt for vGPU
> >   *
> > -- 
> 
> Thanks! Applied this, sorry to miss the check..

Still present after the recent gvt merges.
-Chris
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gvt/display.c b/drivers/gpu/drm/i915/gvt/display.c
index 035479e273be..e3f9caa7839f 100644
--- a/drivers/gpu/drm/i915/gvt/display.c
+++ b/drivers/gpu/drm/i915/gvt/display.c
@@ -448,7 +448,7 @@  void intel_gvt_emulate_vblank(struct intel_gvt *gvt)
 /**
  * intel_vgpu_emulate_hotplug - trigger hotplug event for vGPU
  * @vgpu: a vGPU
- * @conncted: link state
+ * @connected: link state
  *
  * This function is used to trigger hotplug interrupt for vGPU
  *