From patchwork Thu Feb 14 18:32:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 10813483 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1723A922 for ; Thu, 14 Feb 2019 18:32:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07B512F0B9 for ; Thu, 14 Feb 2019 18:32:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 062922F137; Thu, 14 Feb 2019 18:32:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A22622F0B9 for ; Thu, 14 Feb 2019 18:32:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C1686E998; Thu, 14 Feb 2019 18:32:34 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E4F76E997; Thu, 14 Feb 2019 18:32:32 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 15579595-1500050 for multiple; Thu, 14 Feb 2019 18:32:19 +0000 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Thu, 14 Feb 2019 18:32:13 +0000 Message-Id: <20190214183213.30674-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190214132916.3550-1-chris@chris-wilson.co.uk> References: <20190214132916.3550-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t] i915/gem_create: Verify that all new objects are clear X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Matthew Auld Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The kernel must not return stale information back to userspace when they create a new object. For that purpose, we always clear objects on creation, so verify that this is so. Signed-off-by: Chris Wilson Cc: Matthew Auld --- tests/i915/gem_create.c | 71 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c index 25c5e8088..9de2263d5 100644 --- a/tests/i915/gem_create.c +++ b/tests/i915/gem_create.c @@ -44,6 +44,7 @@ #include #include #include +#include #include @@ -141,6 +142,73 @@ static void invalid_nonaligned_size(int fd) gem_close(fd, handle); } +static uint64_t get_npages(uint64_t *global, uint64_t npages) +{ + uint64_t try, old, max; + + max = *global; + do { + old = max; + try = npages % (max / 2); + max -= try; + } while ((max = __sync_val_compare_and_swap(global, old, max)) != old); + + return try; +} + +struct thread_clear { + uint64_t max; + int timeout; + int i915; +}; + +static void *thread_clear(void *data) +{ + struct thread_clear *arg = data; + int i915 = arg->i915; + + igt_until_timeout(arg->timeout) { + uint32_t handle; + uint64_t npages; + + npages = random(); + npages <<= 32; + npages |= random(); + npages = get_npages(&arg->max, npages); + + handle = gem_create(i915, npages << 12); + for (uint64_t page = 0; page < npages; page++) { + uint64_t x; + + gem_read(i915, handle, + page % (4096 - sizeof(x)), + &x, sizeof(x)); + igt_assert_eq_u64(x, 0); + } + gem_close(i915, handle); + + __sync_add_and_fetch(&arg->max, npages); + } + + return NULL; +} + +static void always_clear(int i915, int timeout) +{ + struct thread_clear arg = { + .i915 = i915, + .timeout = timeout, + .max = intel_get_avail_ram_mb() << (20 - 12), /* in pages */ + }; + const int ncpus = sysconf(_SC_NPROCESSORS_ONLN); + pthread_t thread[ncpus]; + + for (int i = 0; i < ncpus; i++) + pthread_create(&thread[i], NULL, thread_clear, &arg); + for (int i = 0; i < ncpus; i++) + pthread_join(thread[i], NULL); +} + igt_main { int fd = -1; @@ -162,4 +230,7 @@ igt_main igt_subtest("create-invalid-nonaligned") invalid_nonaligned_size(fd); + + igt_subtest("create-clear") + always_clear(fd, 30); }