| Message ID | 20190305144717.10000-1-michal.winiarski@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/selftests: Upgrade printing test/subtest name to pr_info | expand |
On 05/03/2019 14:47, Michał Winiarski wrote: > We're using pr_debug for things that we don't really want to see in the > CI log, but we may find useful during test development. > Let's upgrade the test name printer - we do want to see those in CI log. > > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/selftests/i915_selftest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c > index 10ef0e636a24..b18eaefef798 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_selftest.c > +++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c > @@ -133,7 +133,7 @@ static int __run_selftests(const char *name, > if (signal_pending(current)) > return -EINTR; > > - pr_debug(DRIVER_NAME ": Running %s\n", st->name); > + pr_info(DRIVER_NAME ": Running %s\n", st->name); > if (data) > err = st->live(data); > else > @@ -255,7 +255,7 @@ int __i915_subtests(const char *caller, > if (!apply_subtest_filter(caller, st->name)) > continue; > > - pr_debug(DRIVER_NAME ": Running %s/%s\n", caller, st->name); > + pr_info(DRIVER_NAME ": Running %s/%s\n", caller, st->name); > GEM_TRACE("Running %s/%s\n", caller, st->name); > > err = st->func(data); > We are gathering momentum! :) (20181120172839.25013-1-tvrtko.ursulin@linux.intel.com) Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko
Quoting Tvrtko Ursulin (2019-03-05 14:50:48) > > On 05/03/2019 14:47, Michał Winiarski wrote: > > We're using pr_debug for things that we don't really want to see in the > > CI log, but we may find useful during test development. > > Let's upgrade the test name printer - we do want to see those in CI log. > > > > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > --- > > We are gathering momentum! :) > (20181120172839.25013-1-tvrtko.ursulin@linux.intel.com) > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> If you both think it's useful, then you're probably right. Probably ;) I still feel that I only care if it fails, but nevertheless Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
On 05/03/2019 15:16, Patchwork wrote: > == Series Details == > > Series: drm/i915/selftests: Upgrade printing test/subtest name to pr_info > URL : https://patchwork.freedesktop.org/series/57582/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_5703 -> Patchwork_12371 > ==================================================== > > Summary > ------- > > **SUCCESS** > > No regressions found. > > External URL: https://patchwork.freedesktop.org/api/1.0/series/57582/revisions/1/mbox/ > > Known issues > ------------ > > Here are the changes found in Patchwork_12371 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@amdgpu/amd_basic@cs-compute: > - fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094] > > * igt@i915_module_load@reload-with-fault-injection: > - fi-kbl-7567u: PASS -> DMESG-WARN [fdo#105602] / [fdo#108529] +1 > > * igt@i915_pm_rpm@module-reload: > - fi-kbl-7567u: PASS -> DMESG-WARN [fdo#108529] > > * igt@i915_selftest@live_evict: > - fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709] > > * igt@kms_chamelium@common-hpd-after-suspend: > - fi-kbl-7567u: PASS -> DMESG-FAIL [fdo#105079] > > * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence: > - fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] > > * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c: > - fi-kbl-7567u: PASS -> SKIP [fdo#109271] +33 > > * igt@kms_psr@cursor_plane_move: > - fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +37 > > * igt@runner@aborted: > - fi-bsw-kefka: NOTRUN -> FAIL [fdo#107709] > > > #### Possible fixes #### > > * igt@amdgpu/amd_basic@userptr: > - fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS > > * igt@i915_pm_rpm@basic-pci-d3-state: > - fi-byt-j1900: SKIP [fdo#109271] -> PASS > > * igt@i915_pm_rpm@basic-rte: > - fi-byt-j1900: FAIL [fdo#108800] -> PASS > > * igt@i915_pm_rpm@module-reload: > - fi-skl-6770hq: FAIL [fdo#108511] -> PASS > > * igt@i915_selftest@live_execlists: > - fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS > > * igt@kms_busy@basic-flip-c: > - fi-skl-6770hq: SKIP [fdo#109271] / [fdo#109278] -> PASS +2 > > * igt@kms_flip@basic-flip-vs-dpms: > - fi-skl-6770hq: SKIP [fdo#109271] -> PASS +33 > > * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: > - fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS > > > [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 > [fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079 > [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 > [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 > [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709 > [fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094 > [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511 > [fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529 > [fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800 > [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965 > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 > [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720 > > > Participating hosts (46 -> 41) > ------------------------------ > > Additional (1): fi-skl-6260u > Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus > > > Build changes > ------------- > > * Linux: CI_DRM_5703 -> Patchwork_12371 > > CI_DRM_5703: 453da75010eb2a0806e75490b86d24beb6fa76a7 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_4870: ed944b45563c694dc6373bc48dc83b8ba7edb19f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_12371: 6370fd1332e148f3065cb95a56dd06cabb18780f @ git://anongit.freedesktop.org/gfx-ci/linux > > > == Linux commits == > > 6370fd1332e1 drm/i915/selftests: Upgrade printing test/subtest name to pr_info Pushed. Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c index 10ef0e636a24..b18eaefef798 100644 --- a/drivers/gpu/drm/i915/selftests/i915_selftest.c +++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c @@ -133,7 +133,7 @@ static int __run_selftests(const char *name, if (signal_pending(current)) return -EINTR; - pr_debug(DRIVER_NAME ": Running %s\n", st->name); + pr_info(DRIVER_NAME ": Running %s\n", st->name); if (data) err = st->live(data); else @@ -255,7 +255,7 @@ int __i915_subtests(const char *caller, if (!apply_subtest_filter(caller, st->name)) continue; - pr_debug(DRIVER_NAME ": Running %s/%s\n", caller, st->name); + pr_info(DRIVER_NAME ": Running %s/%s\n", caller, st->name); GEM_TRACE("Running %s/%s\n", caller, st->name); err = st->func(data);
We're using pr_debug for things that we don't really want to see in the CI log, but we may find useful during test development. Let's upgrade the test name printer - we do want to see those in CI log. Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/selftests/i915_selftest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)