| Message ID | 20190306064728.8234-9-jose.souza@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v5,1/9] drm/i915/psr: Remove PSR2 FIXME | expand |
On Tue, 2019-03-05 at 22:47 -0800, José Roberto de Souza wrote: > The support for PSR2 was polished, IGT tests for PSR2 was added and > it was tested performing regular user workloads like browsing, > editing documents and compiling Linux, so it is time to enable it by > default and enjoy even more power-savings. Great job :) Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> Is there a reason to include the PSR1 CRC fix in this series, that is an orthogonal issue IMO. And I think we should merge the PSR2 patches independently. > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/intel_psr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_psr.c > b/drivers/gpu/drm/i915/intel_psr.c > index 5d66e7313c75..bae266869c20 100644 > --- a/drivers/gpu/drm/i915/intel_psr.c > +++ b/drivers/gpu/drm/i915/intel_psr.c > @@ -80,9 +80,6 @@ static bool intel_psr2_enabled(struct > drm_i915_private *dev_priv, > case I915_PSR_DEBUG_DISABLE: > case I915_PSR_DEBUG_FORCE_PSR1: > return false; > - case I915_PSR_DEBUG_DEFAULT: > - if (i915_modparams.enable_psr <= 0) > - return false; > default: > return crtc_state->has_psr2; > }
On Thu, 2019-03-07 at 13:33 -0800, Dhinakaran Pandiyan wrote: > On Tue, 2019-03-05 at 22:47 -0800, José Roberto de Souza wrote: > > The support for PSR2 was polished, IGT tests for PSR2 was added and > > it was tested performing regular user workloads like browsing, > > editing documents and compiling Linux, so it is time to enable it > > by > > default and enjoy even more power-savings. > > Great job :) > Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > > Is there a reason to include the PSR1 CRC fix in this series, that is > an orthogonal issue IMO. And I think we should merge the PSR2 patches > independently. I added those patches to get all green CI runs but I can merge all other patches than 'drm/i915: Force PSR exit when getting pipe CRC', I just answered your questions on that patch, lets see what you think about the answers. > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > > --- > > drivers/gpu/drm/i915/intel_psr.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_psr.c > > b/drivers/gpu/drm/i915/intel_psr.c > > index 5d66e7313c75..bae266869c20 100644 > > --- a/drivers/gpu/drm/i915/intel_psr.c > > +++ b/drivers/gpu/drm/i915/intel_psr.c > > @@ -80,9 +80,6 @@ static bool intel_psr2_enabled(struct > > drm_i915_private *dev_priv, > > case I915_PSR_DEBUG_DISABLE: > > case I915_PSR_DEBUG_FORCE_PSR1: > > return false; > > - case I915_PSR_DEBUG_DEFAULT: > > - if (i915_modparams.enable_psr <= 0) > > - return false; > > default: > > return crtc_state->has_psr2; > > }
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 5d66e7313c75..bae266869c20 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -80,9 +80,6 @@ static bool intel_psr2_enabled(struct drm_i915_private *dev_priv, case I915_PSR_DEBUG_DISABLE: case I915_PSR_DEBUG_FORCE_PSR1: return false; - case I915_PSR_DEBUG_DEFAULT: - if (i915_modparams.enable_psr <= 0) - return false; default: return crtc_state->has_psr2; }