diff mbox series

[i-g-t,09/25] i915/gem_ctx_param: Remove kneecapping

Message ID	20190314141939.26246-9-chris@chris-wilson.co.uk (mailing list archive)
State	New, archived
Headers	show Return-Path: <intel-gfx-bounces@lists.freedesktop.org> From: Chris Wilson <chris@chris-wilson.co.uk> To: intel-gfx@lists.freedesktop.org Date: Thu, 14 Mar 2019 14:19:23 +0000 Message-Id: <20190314141939.26246-9-chris@chris-wilson.co.uk> In-Reply-To: <20190314141939.26246-1-chris@chris-wilson.co.uk> References: <20190314141939.26246-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t 09/25] i915/gem_ctx_param: Remove kneecapping Precedence: list Cc: igt-dev@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
Series	[i-g-t,01/25] i915/gem_create: Always try to create an object of at least one page \| expand [i-g-t,01/25] i915/gem_create: Always try to create an object of at least one page [i-g-t,02/25] lib/i915: Pretty print HW semaphores [i-g-t,03/25] lib: Add GPU power measurement [i-g-t,04/25] i915/gem_exec_schedule: Measure semaphore power consumption [i-g-t,05/25] i915/gem_exec_whisper: Measure total power consumed [i-g-t,06/25] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block [i-g-t,07/25] i915/gem_exec_nop: poll-sequential requires ordering between rings [i-g-t,08/25] i915/gem_sync: Make switch-default asymmetric [i-g-t,09/25] i915/gem_ctx_param: Remove kneecapping [i-g-t,10/25] i915/gem_exec_big: Add a single shot test [i-g-t,11/25] kms_fence_pin_leak: Ask for the GPU before use [i-g-t,12/25] drm-uapi: Import i915_drm.h upto 364df3d04d51 [i-g-t,13/25] lib/i915: Improve gem_context error messages [i-g-t,14/25] i915/gem_ctx_param: Test set/get (copy) VM [i-g-t,15/25] i915/gem_ctx_create: Basic checks for constructor properties [i-g-t,16/25] i915: Add gem_ctx_clone [i-g-t,17/25] i915: Add gem_vm_create [i-g-t,18/25] i915: Exercise creating context with shared GTT [i-g-t,19/25] i915/gem_ctx_switch: Exercise queues [i-g-t,20/25] i915/gem_exec_whisper: Fork all-engine tests one-per-engine [i-g-t,21/25] i915/gem_exec_whisper: debugfs/next_seqno is defunct [i-g-t,22/25] i915: Add gem_ctx_engines [i-g-t,23/25] i915: Add gem_exec_balancer [i-g-t,24/25] i915/gem_exec_balancer: Exercise bonded pairs [i-g-t,25/25] i915/gem_exec_latency: Measure the latency of context switching

Commit Message

Chris Wilson March 14, 2019, 2:19 p.m. UTC

The invalid set/get tests do not serve the purpose of detecting whether
or not invalid parameters are indeed detect correctly -- simply because
the kernel is the arbiter of what is invalid and this test second
guesses that and is wrong.

The intent of this test was to ensure that we didn't include any holes
in the parameter space that may have been used for nefarious undisclosed
purposes, i.e. the maintainer's job backed up by reviewers.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 tests/i915/gem_ctx_param.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff mbox series

Patch

diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c
index acc1e6297..b3f8637df 100644
--- a/tests/i915/gem_ctx_param.c
+++ b/tests/i915/gem_ctx_param.c
@@ -296,22 +296,6 @@  igt_main
 
 	/* I915_CONTEXT_PARAM_SSEU tests are located in gem_ctx_sseu.c */
 
-	/* NOTE: This testcase intentionally tests for the next free parameter
-	 * to catch ABI extensions. Don't "fix" this testcase without adding all
-	 * the tests for the new param first.
-	 */
-	arg.param = I915_CONTEXT_PARAM_SSEU + 1;
-
-	igt_subtest("invalid-param-get") {
-		arg.ctx_id = ctx;
-		igt_assert_eq(__gem_context_get_param(fd, &arg), -EINVAL);
-	}
-
-	igt_subtest("invalid-param-set") {
-		arg.ctx_id = ctx;
-		igt_assert_eq(__gem_context_set_param(fd, &arg), -EINVAL);
-	}
-
 	igt_fixture
 		close(fd);
 }