diff mbox series

[3/3] drm/i915: Reject rotation for some hdr formats

Message ID 20190322135954.20434-3-maarten.lankhorst@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [1/3] drm/i915: Handle YUV subpixel support better | expand

Commit Message

Maarten Lankhorst March 22, 2019, 1:59 p.m. UTC 
90/270 rotation is not supported for Y21x and the 12/16 bits XVYU formats,
reject support for them.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_sprite.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Ville Syrjälä March 22, 2019, 2:06 p.m. UTC | #1 
On Fri, Mar 22, 2019 at 02:59:54PM +0100, Maarten Lankhorst wrote:
> 90/270 rotation is not supported for Y21x and the 12/16 bits XVYU formats,
> reject support for them.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_sprite.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 36ee39ec3687..65de7387bf1b 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1531,6 +1531,11 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
>  		case DRM_FORMAT_XBGR16161616F:
>  		case DRM_FORMAT_ARGB16161616F:
>  		case DRM_FORMAT_ABGR16161616F:
> +		case DRM_FORMAT_Y210:
> +		case DRM_FORMAT_Y212:
> +		case DRM_FORMAT_Y216:
> +		case DRM_FORMAT_XVYU12_16161616:
> +		case DRM_FORMAT_XVYU16161616:
>  			DRM_DEBUG_KMS("Unsupported pixel format %s for 90/270!\n",
>  				      drm_get_format_name(fb->format->format,
>  							  &format_name));
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Maarten Lankhorst March 27, 2019, 4:54 p.m. UTC | #2 
Op 22-03-2019 om 15:06 schreef Ville Syrjälä:
> On Fri, Mar 22, 2019 at 02:59:54PM +0100, Maarten Lankhorst wrote:
>> 90/270 rotation is not supported for Y21x and the 12/16 bits XVYU formats,
>> reject support for them.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>> ---
>>  drivers/gpu/drm/i915/intel_sprite.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
>> index 36ee39ec3687..65de7387bf1b 100644
>> --- a/drivers/gpu/drm/i915/intel_sprite.c
>> +++ b/drivers/gpu/drm/i915/intel_sprite.c
>> @@ -1531,6 +1531,11 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
>>  		case DRM_FORMAT_XBGR16161616F:
>>  		case DRM_FORMAT_ARGB16161616F:
>>  		case DRM_FORMAT_ABGR16161616F:
>> +		case DRM_FORMAT_Y210:
>> +		case DRM_FORMAT_Y212:
>> +		case DRM_FORMAT_Y216:
>> +		case DRM_FORMAT_XVYU12_16161616:
>> +		case DRM_FORMAT_XVYU16161616:
>>  			DRM_DEBUG_KMS("Unsupported pixel format %s for 90/270!\n",
>>  				      drm_get_format_name(fb->format->format,
>>  							  &format_name));
>> -- 
>> 2.20.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Pushed, thanks for review. :)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index 36ee39ec3687..65de7387bf1b 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -1531,6 +1531,11 @@  static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
 		case DRM_FORMAT_XBGR16161616F:
 		case DRM_FORMAT_ARGB16161616F:
 		case DRM_FORMAT_ABGR16161616F:
+		case DRM_FORMAT_Y210:
+		case DRM_FORMAT_Y212:
+		case DRM_FORMAT_Y216:
+		case DRM_FORMAT_XVYU12_16161616:
+		case DRM_FORMAT_XVYU16161616:
 			DRM_DEBUG_KMS("Unsupported pixel format %s for 90/270!\n",
 				      drm_get_format_name(fb->format->format,
 							  &format_name));