| Message ID | 20190501114541.10077-2-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/14] drm/i915/hangcheck: Track context changes | expand |
On 01/05/2019 12:45, Chris Wilson wrote: > Show the fence flags view of request completion in addition to the > normal hwsp check and whether signaling is enabled. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > index 6e40f8ea9a6a..f178f1268f4e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > @@ -1229,8 +1229,11 @@ static void print_request(struct drm_printer *m, > i915_request_completed(rq) ? "!" : > i915_request_started(rq) ? "*" : > "", > + test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, > + &rq->fence.flags) ? "+" : > test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, > - &rq->fence.flags) ? "+" : "", > + &rq->fence.flags) ? "-" : > + "", > buf, > jiffies_to_msecs(jiffies - rq->emitted_jiffies), > name); > We need a decoding cheat sheet now.. Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Can we make it somewhat self-explanatory? Maybe only in my head.. ">-|" (started/signaling enabled/completed) ">+" (started/signaled) Imagine more fun if completed would be '<'. :) Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index 6e40f8ea9a6a..f178f1268f4e 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -1229,8 +1229,11 @@ static void print_request(struct drm_printer *m, i915_request_completed(rq) ? "!" : i915_request_started(rq) ? "*" : "", + test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, + &rq->fence.flags) ? "+" : test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, - &rq->fence.flags) ? "+" : "", + &rq->fence.flags) ? "-" : + "", buf, jiffies_to_msecs(jiffies - rq->emitted_jiffies), name);
Show the fence flags view of request completion in addition to the normal hwsp check and whether signaling is enabled. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)