[i-g-t,16/21] gem_wsim: Some more example workloads

Message ID	20190508121058.27038-17-tvrtko.ursulin@linux.intel.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <intel-gfx-bounces@lists.freedesktop.org> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: igt-dev@lists.freedesktop.org Date: Wed, 8 May 2019 13:10:53 +0100 Message-Id: <20190508121058.27038-17-tvrtko.ursulin@linux.intel.com> In-Reply-To: <20190508121058.27038-1-tvrtko.ursulin@linux.intel.com> References: <20190508121058.27038-1-tvrtko.ursulin@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t 16/21] gem_wsim: Some more example workloads Precedence: list Cc: Intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
Series	Media scalability tooling \| expand [i-g-t,00/21] Media scalability tooling [i-g-t,01/21] scripts/trace.pl: Fix after intel_engine_notify removal [i-g-t,02/21] headers: bump [i-g-t,03/21] trace.pl: Virtual engine support [i-g-t,04/21] trace.pl: Virtual engine preemption support [i-g-t,05/21] wsim/media-bench: i915 balancing [i-g-t,06/21] gem_wsim: Use IGT uapi headers [i-g-t,07/21] gem_wsim: Factor out common error handling [i-g-t,08/21] gem_wsim: More wsim_err [i-g-t,09/21] gem_wsim: Submit fence support [i-g-t,10/21] gem_wsim: Extract str to engine lookup [i-g-t,11/21] gem_wsim: Engine map support [i-g-t,12/21] gem_wsim: Save some lines by changing to implicit NULL checking [i-g-t,13/21] gem_wsim: Compact int command parsing with a macro [i-g-t,14/21] gem_wsim: Engine map load balance command [i-g-t,15/21] gem_wsim: Engine bond command [i-g-t,16/21] gem_wsim: Some more example workloads [i-g-t,17/21] gem_wsim: Infinite batch support [i-g-t,18/21] gem_wsim: Command line switch for specifying low slice count workloads [i-g-t,19/21] gem_wsim: Per context SSEU control [i-g-t,20/21] gem_wsim: Allow RCS virtual engine with SSEU control [i-g-t,21/21] tests/i915_query: Engine discovery tests

Tvrtko Ursulin May 8, 2019, 12:10 p.m. UTC

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

A few additional workloads useful for experimenting with scheduling.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 benchmarks/wsim/frame-split-60fps.wsim      | 16 ++++++++++++++++
 benchmarks/wsim/high-composited-game.wsim   | 11 +++++++++++
 benchmarks/wsim/media-1080p-player.wsim     |  5 +++++
 benchmarks/wsim/medium-composited-game.wsim |  9 +++++++++
 4 files changed, 41 insertions(+)
 create mode 100644 benchmarks/wsim/frame-split-60fps.wsim
 create mode 100644 benchmarks/wsim/high-composited-game.wsim
 create mode 100644 benchmarks/wsim/media-1080p-player.wsim
 create mode 100644 benchmarks/wsim/medium-composited-game.wsim

Chris Wilson May 8, 2019, 12:27 p.m. UTC | #1

Quoting Tvrtko Ursulin (2019-05-08 13:10:53)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> A few additional workloads useful for experimenting with scheduling.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Are the extra modes & .wsim supported by scripts/media-bench.pl?
i.e. can I just run media-bench.pl and have it exercise all the new
features?
-Chris

Tvrtko Ursulin May 8, 2019, 1:50 p.m. UTC | #2

On 08/05/2019 13:27, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-05-08 13:10:53)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> A few additional workloads useful for experimenting with scheduling.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Are the extra modes & .wsim supported by scripts/media-bench.pl?
> i.e. can I just run media-bench.pl and have it exercise all the new
> features?

Not sure what you mean by extra modes? If all new wsim commands then no. 
They are not in the default media-bench.pl set. The workloads from this 
patch are not in that set so are just for reference.

Virtual engine (gem_wsim -b i915) is supported by media-bench.pl even 
with the old/default set of workloads.

The catch is old wsim workloads use VCS to mean any VCS and in those 
cases -b i915 will set up the virtual engine 
automatically/transparently. So those old workloads can be ran both with 
userspace or i915 balancing.

Regards,

Tvrtko

Chris Wilson May 8, 2019, 1:56 p.m. UTC | #3

Quoting Tvrtko Ursulin (2019-05-08 14:50:41)
> 
> On 08/05/2019 13:27, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-05-08 13:10:53)
> >> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >> A few additional workloads useful for experimenting with scheduling.
> >>
> >> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > Are the extra modes & .wsim supported by scripts/media-bench.pl?
> > i.e. can I just run media-bench.pl and have it exercise all the new
> > features?
> 
> Not sure what you mean by extra modes? If all new wsim commands then no. 
> They are not in the default media-bench.pl set. The workloads from this 
> patch are not in that set so are just for reference.

That's what I meant, are the new example.wsim with explicit engine maps
and so I presume inter-mixing of load-balanced workloads with other work
included in the default set run by ./scripts/media-bench.pl

What's the minimum amount of effort I need to exercise all the new
features of gem_wsim? :)

> Virtual engine (gem_wsim -b i915) is supported by media-bench.pl even 
> with the old/default set of workloads.
> 
> The catch is old wsim workloads use VCS to mean any VCS and in those 
> cases -b i915 will set up the virtual engine 
> automatically/transparently. So those old workloads can be ran both with 
> userspace or i915 balancing.

And seems to still be working.
-Chris

Tvrtko Ursulin May 8, 2019, 2:16 p.m. UTC | #4

On 08/05/2019 14:56, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-05-08 14:50:41)
>>
>> On 08/05/2019 13:27, Chris Wilson wrote:
>>> Quoting Tvrtko Ursulin (2019-05-08 13:10:53)
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> A few additional workloads useful for experimenting with scheduling.
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>
>>> Are the extra modes & .wsim supported by scripts/media-bench.pl?
>>> i.e. can I just run media-bench.pl and have it exercise all the new
>>> features?
>>
>> Not sure what you mean by extra modes? If all new wsim commands then no.
>> They are not in the default media-bench.pl set. The workloads from this
>> patch are not in that set so are just for reference.
> 
> That's what I meant, are the new example.wsim with explicit engine maps
> and so I presume inter-mixing of load-balanced workloads with other work
> included in the default set run by ./scripts/media-bench.pl

It's not in the default set but manual workloads can be given to 
media-bench.pl using the -w switch. String passed there is passed onto 
gem_wsim directly so one or more workloads can be manually specified.

> What's the minimum amount of effort I need to exercise all the new
> features of gem_wsim? :)

frame-split-60fps.wsim uses almost all new features: preemption control, 
engine map, load balance, bond, submit fence and the "endless" batch.

Only missing is SSEU control for which I did not add an example workload 
(there is a snippet in README though) since the access to uapi is 
blocked outside the gen11 special case. To use that the i915 IS_GEN11 
check in set_sseu needs to be lifted as well.

>> Virtual engine (gem_wsim -b i915) is supported by media-bench.pl even
>> with the old/default set of workloads.
>>
>> The catch is old wsim workloads use VCS to mean any VCS and in those
>> cases -b i915 will set up the virtual engine
>> automatically/transparently. So those old workloads can be ran both with
>> userspace or i915 balancing.
> 
> And seems to still be working.

I'd hope so, I mostly do test things! :)

Regards,

Tvrtko

Chris Wilson May 10, 2019, 1:37 p.m. UTC | #5

Quoting Tvrtko Ursulin (2019-05-08 13:10:53)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> A few additional workloads useful for experimenting with scheduling.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

[i-g-t,16/21] gem_wsim: Some more example workloads

Commit Message

Comments

Patch