diff mbox series

[i-g-t] lib/i915: Fix pointer cast build issue

Message ID 20190522150413.27697-1-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [i-g-t] lib/i915: Fix pointer cast build issue | expand

Commit Message

Tvrtko Ursulin May 22, 2019, 3:04 p.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Use from_user_pointer when casting __u64 to a pointer.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
 lib/i915/gem_engine_topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson May 22, 2019, 3:08 p.m. UTC | #1 
Quoting Tvrtko Ursulin (2019-05-22 16:04:13)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Use from_user_pointer when casting __u64 to a pointer.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
>  lib/i915/gem_engine_topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
> index dd26fae00853..7ca3616687b9 100644
> --- a/lib/i915/gem_engine_topology.c
> +++ b/lib/i915/gem_engine_topology.c
> @@ -81,7 +81,7 @@ static void ctx_map_engines(int fd, struct intel_engine_data *ed,
>                             struct drm_i915_gem_context_param *param)
>  {
>         struct i915_context_param_engines *engines =
> -                       (struct i915_context_param_engines *) param->value;
> +                       from_user_pointer(param->value);

Only a single tab indent required.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

>         int i = 0;
>  
>         for (typeof(engines->engines[0]) *p =

And struct i915_engine_class_instance was added to make this for() loop
nicer.
-Chris
Andi Shyti May 22, 2019, 9:08 p.m. UTC | #2 
Hi Tvrtko,

On Wed, May 22, 2019 at 04:04:13PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Use from_user_pointer when casting __u64 to a pointer.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
diff mbox series

Patch

diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
index dd26fae00853..7ca3616687b9 100644
--- a/lib/i915/gem_engine_topology.c
+++ b/lib/i915/gem_engine_topology.c
@@ -81,7 +81,7 @@  static void ctx_map_engines(int fd, struct intel_engine_data *ed,
 			    struct drm_i915_gem_context_param *param)
 {
 	struct i915_context_param_engines *engines =
-			(struct i915_context_param_engines *) param->value;
+			from_user_pointer(param->value);
 	int i = 0;
 
 	for (typeof(engines->engines[0]) *p =