diff mbox series

[37/39] drm/i915: Use forced preemptions in preference over hangcheck

Message ID 20190614071023.17929-38-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series [01/39] drm/i915: Discard some redundant cache domain flushes | expand

Commit Message

Chris Wilson June 14, 2019, 7:10 a.m. UTC 
How well does this work in practice? It means that unless someone else
is attempting to run we do not reset infinite loops. Maybe that is a
good thing.

Opens:

* This sacrifices error capture. Maybe make that an opt-in with a
watchdog.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index ae7155f0e063..9a4e58d637ee 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -43,7 +43,8 @@  static int intel_gt_unpark(struct intel_wakeref *wf)
 
 	i915_pmu_gt_unparked(i915);
 
-	i915_queue_hangcheck(i915);
+	if (!(i915->caps.scheduler & I915_SCHEDULER_CAP_PREEMPTION))
+		i915_queue_hangcheck(i915);
 
 	pm_notify(i915, INTEL_GT_UNPARK);