From patchwork Fri Jun 14 20:35:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10996503 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 18F74112C for ; Fri, 14 Jun 2019 20:36:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B45F2876B for ; Fri, 14 Jun 2019 20:36:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3D2928774; Fri, 14 Jun 2019 20:36:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BF0452876B for ; Fri, 14 Jun 2019 20:36:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4877F89333; Fri, 14 Jun 2019 20:36:27 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id A294E892CC for ; Fri, 14 Jun 2019 20:36:23 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id k8so5195189edr.11 for ; Fri, 14 Jun 2019 13:36:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NCigECl+eLv0j+gr5RVk62juHsPhtgdWifjAskWwSiY=; b=srzZOGVuiKxNcocdy6SpYYBQDtfDPymj7SCsmo28WA/Ucf3oNW3fTkJczvhdARI/mv W7OcVly0qj5N8K8yO8whscbuUvSPIpuNOh7oOx9SMpPjj9F3LWrbKnL+ZHE2GlWqDUFC Jp4kt1X9fk37MjxahSVGOmHew/PjlVLzp2MnRsgSfHHZJW50WZP5G3DBQYTnuO6F3WWY cgjKB9e3W8qLEyJ4tTHPqi3doEOWuCYPlJX/AHKpBHCI3ysWRwdAV3MhNuDh3DF46UyM QtyN0ykyU14ec/RdKjqWEtI+iucWRJyAprBtMYVgbS2ZjOaLK5/ziszeT38foP0sGmL8 /YLw== X-Gm-Message-State: APjAAAXfzEqy0606uwCTrkV5C42iSlYXA4hAxfB8jjD9a2MlvTZCrBAe MSi4dRdmooA9Hf4BR2ASAtjKng== X-Google-Smtp-Source: APXvYqxT3nBqL8oJ4M0ZY8FyqH+UmBFUSiZZ8sZRMVzCh3pErU/LZ7pZK42HigoG9iw2kI9F8i1Q8A== X-Received: by 2002:a17:906:31c8:: with SMTP id f8mr78452703ejf.131.1560544582301; Fri, 14 Jun 2019 13:36:22 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id n15sm1166672edd.49.2019.06.14.13.36.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 13:36:21 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Fri, 14 Jun 2019 22:35:17 +0200 Message-Id: <20190614203615.12639-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190614203615.12639-1-daniel.vetter@ffwll.ch> References: <20190614203615.12639-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NCigECl+eLv0j+gr5RVk62juHsPhtgdWifjAskWwSiY=; b=UR9o2pSzx9iUjZe80Z77JCadYkzDYmrMZbuBz7lJgZlxYKy8JQGWIR2lMSirJqZr3w 8k87vuljQsCaTvV4XgWG5yBbYhodZZD+KTchDT6j6rHpT+8vPUYpJX5FO9m9pzBgHpcQ cviy2No2WNl8wo+uzr+YTJRmnbOORuvPM6KIw= Subject: [Intel-gfx] [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Daniel Vetter , Intel Graphics Development , =?utf-8?q?Nor?= =?utf-8?q?alf_Tr=C3=B8nnes?= , Gerd Hoffmann , Thomas Zimmermann , Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP We're kinda going in the wrong direction. Spotted while typing better gem/prime docs. Cc: Thomas Zimmermann Cc: Gerd Hoffmann Cc: Rob Herring Cc: Noralf Trønnes Signed-off-by: Daniel Vetter Reviewed-by: Eric Anholt Acked-by: Gerd Hoffmann --- Documentation/gpu/todo.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index b4a76c2703e5..23583f0e3755 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -228,6 +228,10 @@ struct drm_gem_object_funcs GEM objects can now have a function table instead of having the callbacks on the DRM driver struct. This is now the preferred way and drivers can be moved over. +Unfortunately some of the recently added GEM helpers are going in the wrong +direction by adding OPS macros that use the old, deprecated hooks. See +DRM_GEM_CMA_VMAP_DRIVER_OPS, DRM_GEM_SHMEM_DRIVER_OPS, and DRM_GEM_VRAM_DRIVER_PRIME. + Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate ---------------------------------------------------------