diff mbox series

[01/22] drm/i915: Restore -Wunused-but-set-variable

Message ID 20190617071912.20256-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series [01/22] drm/i915: Restore -Wunused-but-set-variable | expand

Commit Message

Chris Wilson June 17, 2019, 7:18 a.m. UTC
We appear to be clear of this warning, so time to re-enable the gcc error
checking.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Chris Wilson June 17, 2019, 7:56 a.m. UTC | #1
Quoting Chris Wilson (2019-06-17 08:18:51)
> We appear to be clear of this warning, so time to re-enable the gcc error
> checking.

Scratch that, it is only showing up under W=1. Hmm.

I forget it is to cover the voluminous atomic macros.
-Chris
Chris Wilson June 17, 2019, 1:18 p.m. UTC | #2
Quoting Patchwork (2019-06-17 14:05:05)
> #### Possible regressions ####
> 
>   * igt@gem_close_race@basic-process:
>     - fi-hsw-peppy:       [PASS][1] -> [INCOMPLETE][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6282/fi-hsw-peppy/igt@gem_close_race@basic-process.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13302/fi-hsw-peppy/igt@gem_close_race@basic-process.html

Hmm, wasn't expecting an issue with the engine wakeref vs the batch
pool.

>   * igt@i915_module_load@reload:
>     - fi-kbl-8809g:       [PASS][9] -> [DMESG-WARN][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6282/fi-kbl-8809g/igt@i915_module_load@reload.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13302/fi-kbl-8809g/igt@i915_module_load@reload.html

Leaked the intel_framebuffer object.
-Chris
Jani Nikula June 18, 2019, 7:54 a.m. UTC | #3
On Mon, 17 Jun 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> We appear to be clear of this warning, so time to re-enable the gcc error
> checking.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Acked-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index c0a7b2994077..f4971900087a 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -17,7 +17,6 @@ subdir-ccflags-y += $(call cc-disable-warning, unused-parameter)
>  subdir-ccflags-y += $(call cc-disable-warning, type-limits)
>  subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
>  subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough)
> -subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
>  # clang warnings
>  subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
>  subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index c0a7b2994077..f4971900087a 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -17,7 +17,6 @@  subdir-ccflags-y += $(call cc-disable-warning, unused-parameter)
 subdir-ccflags-y += $(call cc-disable-warning, type-limits)
 subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
 subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough)
-subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
 # clang warnings
 subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
 subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)