From patchwork Thu Jun 27 07:36:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 11019007 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D106914C0 for ; Thu, 27 Jun 2019 07:36:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B90F728815 for ; Thu, 27 Jun 2019 07:36:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AA04A28978; Thu, 27 Jun 2019 07:36:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DBB9428815 for ; Thu, 27 Jun 2019 07:36:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F7AE6E80E; Thu, 27 Jun 2019 07:36:25 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27D796E80E; Thu, 27 Jun 2019 07:36:23 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 17039432-1500050 for multiple; Thu, 27 Jun 2019 08:36:18 +0100 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Thu, 27 Jun 2019 08:36:15 +0100 Message-Id: <20190627073615.15573-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t] i915/gem_pread/pwrite: Rename "basic" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The "basic" subtests perform no verification that the read/write work, only function as mere API exercisers and loose benchmarks. Rename them to reflect that they are poor benchmarks instead. Signed-off-by: Chris Wilson Reviewed-by: Simon Ser --- tests/i915/gem_pread.c | 2 +- tests/i915/gem_pwrite.c | 2 +- tests/intel-ci/fast-feedback.testlist | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/i915/gem_pread.c b/tests/i915/gem_pread.c index c64787653..0d3e10b80 100644 --- a/tests/i915/gem_pread.c +++ b/tests/i915/gem_pread.c @@ -159,7 +159,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL) dst_user = malloc(object_size); } - igt_subtest("basic") { + igt_subtest("bench") { for (count = 1; count <= 1<<17; count <<= 1) { struct timeval start, end; diff --git a/tests/i915/gem_pwrite.c b/tests/i915/gem_pwrite.c index 97703a2aa..37e978791 100644 --- a/tests/i915/gem_pwrite.c +++ b/tests/i915/gem_pwrite.c @@ -286,7 +286,7 @@ igt_main_args("s:", NULL, help_str, opt_handler, NULL) src_user = malloc(object_size); } - igt_subtest("basic") { + igt_subtest("bench") { for (count = 1; count <= 1<<17; count <<= 1) { struct timeval start, end; diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index 8618dfd28..5fcb5e76d 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -87,8 +87,6 @@ igt@gem_mmap_gtt@basic-write-gtt-no-prefault igt@gem_mmap_gtt@basic-write-no-prefault igt@gem_mmap_gtt@basic-write-read igt@gem_mmap_gtt@basic-write-read-distinct -igt@gem_pread@basic -igt@gem_pwrite@basic igt@gem_render_linear_blits@basic igt@gem_render_tiled_blits@basic igt@gem_ringfill@basic-default