From patchwork Tue Aug 20 17:06:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11104411 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E0AD51395 for ; Tue, 20 Aug 2019 17:06:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC8932087E for ; Tue, 20 Aug 2019 17:06:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC8932087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D3966E838; Tue, 20 Aug 2019 17:06:40 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAEDB6E838 for ; Tue, 20 Aug 2019 17:06:38 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id t50so4179094edd.2 for ; Tue, 20 Aug 2019 10:06:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yDjXHVtQjJobTZqDsmnLwaZjZ95OSIZ845oXtMqR7YA=; b=Fr3KtY8qcTCXrfaEZjnAw+q1ZZzT+ELDqTeSeRSwm6A34SLbVku/xvLUjluXLsL72B 6t9ULaBoiyWHSu07Q2gmsHKAQZuxWpYM7tYniPXq4udCAFNxVzhYMi4bbsA37EkBnrbF FV+lvYQ44nBVSfBtbijHvcO0E1piEd9T1/gkg3Ru8MaYlU1u82sYs2OLTlVjq2QJb25b zHtc0+4bxgTd9FTBJkOfu6g6aQbVZs/BuM9HY3Oy0Rx/A0TsWfX+QYJP/qdn83CfJLN/ 0xhPZuWSq8IkjLLK+syVQHuBDuHPfvehMsa9i8UP+R9P1a2gAc49ZqiNQ/fJpVNZK242 8yGg== X-Gm-Message-State: APjAAAX85ZGETnBYpqWysg90ahosWvblIvejCYPowWDOyY6Q6xZ++EUp TNJHXgRuwOZjDJ+5mw082BeLSMzYhF3bOA== X-Google-Smtp-Source: APXvYqxn1rTOQ3fAWoz3PLIVL4kQgtZ/+bOrOV8Xo5s1VXB3rlzo26K5w9q8G3eK6sxDgFZ5Bj/YTg== X-Received: by 2002:a17:907:217b:: with SMTP id rl27mr27171757ejb.154.1566320796975; Tue, 20 Aug 2019 10:06:36 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id x11sm2695201eju.26.2019.08.20.10.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 10:06:35 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Tue, 20 Aug 2019 19:06:31 +0200 Message-Id: <20190820170631.26570-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.23.0.rc1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yDjXHVtQjJobTZqDsmnLwaZjZ95OSIZ845oXtMqR7YA=; b=aZsU3uIIiTF7s4i30eGGuvOoafw49j2bGkYPXNqFdVj8Bjb07hL8KokQxH6YDIs+E8 rT2GS6BIN6PTZi1N7efU0IOJrWoGWvjBVA5/NWGuRde4Xf6OCtSDkYP3LQRYkm61ZzyW AzJk1c5uDbBFDT0+MtPxdVXpFZE0qiZWwloMQ= Subject: [Intel-gfx] [PATCH] drm/i915: disable set/get_tiling ioctl on gen12+ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Lucas De Marchi , Kenneth Graunke , Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The cpu (de)tiler hw is gone, this stopped being useful. Plus it never supported any of the fancy new tiling formats, which means userspace also stopped using the magic side-channel this provides. This would totally break a lot of the igts, but they're already broken for the same reasons as userspace on gen12 would be. Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Chris Wilson Cc: Lucas De Marchi Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c index ca0c2f451742..2ee96f27a294 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c @@ -313,10 +313,15 @@ int i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data, struct drm_file *file) { + struct drm_i915_private *dev_priv = to_i915(dev); struct drm_i915_gem_set_tiling *args = data; struct drm_i915_gem_object *obj; int err; + /* there is no cpu (de)tiling in the hw anymore on gen12+ */ + if (INTEL_GEN(dev_priv) >= 12) + return -EOPNOTSUPP; + obj = i915_gem_object_lookup(file, args->handle); if (!obj) return -ENOENT; @@ -402,6 +407,9 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data, struct drm_i915_gem_object *obj; int err = -ENOENT; + if (INTEL_GEN(dev_priv) >= 12) + return -EOPNOTSUPP; + rcu_read_lock(); obj = i915_gem_object_lookup_rcu(file, args->handle); if (obj) {