From patchwork Tue Sep 3 19:05:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11128609 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 72A771398 for ; Tue, 3 Sep 2019 19:05:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA8C221897 for ; Tue, 3 Sep 2019 19:05:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA8C221897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A566C89622; Tue, 3 Sep 2019 19:05:55 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3566A89622 for ; Tue, 3 Sep 2019 19:05:54 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id i8so5821042edn.13 for ; Tue, 03 Sep 2019 12:05:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rMbe/90UeFfqEUrk4ND8PxMTYBDDkx6JYpo4F1BWcC8=; b=gVnCfjrbe7MOdAnHSlQ4J/mFB2X1gM/hLcc2HAgoe+GCTtwmuwcYf7MZUgfsyam5gt gwP4zdJEIataP7XGb1Vx3ZrvyU7UHFkJ79sgQesdBisucyND/AWtEdyK0XDuHv1kfO2c WF7Pt+1gKcwAv5SRgSr0g3jY9c/nQqj47hXG9B9IHdz0PLBX9t9ocpoD6pF5cWmMKafp FpB977WRCqtGiffBGwZhwKN2y6NBc0aSPt/XfRLSHMOI4dUeEP7TNo66dh+FfE5vMGqe 2eGIThKdQKUY4MK1fj/E1Eb+qkz9OCao2bXjNO4W5lO6NnAMfMJCNJTvn+q1JPj75pCC I1Fg== X-Gm-Message-State: APjAAAXs0QXBCJOl0SnUo8XFvPY/Gf9iu8iDS1ndu9B3es4vCagNK7mp ilm6MsHwrda/Ya4D5uTj6r/R/w== X-Google-Smtp-Source: APXvYqxN/Y6aPD7JASs4itjBnR/gvRxtylDnevVJ/hnjg0KTrnwyas9PoqDn7aPPGvSQlIpIMTlLKQ== X-Received: by 2002:a50:b19c:: with SMTP id m28mr26549237edd.189.1567537552813; Tue, 03 Sep 2019 12:05:52 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id 60sm1766309edg.10.2019.09.03.12.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 12:05:52 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Tue, 3 Sep 2019 21:05:43 +0200 Message-Id: <20190903190545.31852-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rMbe/90UeFfqEUrk4ND8PxMTYBDDkx6JYpo4F1BWcC8=; b=PJ5ZC67poNYVba0KlxW5VX4k9UsYhOC7oyFZHGPHL8WmT0zU4uF+7ou/Z3Lso887c+ AnVR6mTC0FckX2sjbpPR8itM22iXZT3ETuj0USV/+XXti+uBQfsE4EKFYN8Oh5YqC7zw HV0X8JNTlzVuFlyeINVOs/3UjBLPBa95qpxjI= Subject: [Intel-gfx] [PATCH 1/3] drm/atomic: Reject FLIP_ASYNC unconditionally X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Intel Graphics Development , Adam Jackson , Alex Deucher , Daniel Vetter , =?utf-8?q?Michel_D=C3=A4nzer?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" It's never been wired up. Only userspace that tried to use it (and didn't actually check whether anything works, but hey it builds) is the -modesetting atomic implementation. And we just shut that up. If there's anyone else then we need to silently accept this flag no matter what, and find a new one. Because once a flag is tainted, it's lost. Cc: Maarten Lankhorst Cc: Michel Dänzer Cc: Alex Deucher Cc: Adam Jackson Cc: Sean Paul Cc: David Airlie Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic_uapi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index 5a5b42db6f2a..7a26bfb5329c 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -1305,8 +1305,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, if (arg->reserved) return -EINVAL; - if ((arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) && - !dev->mode_config.async_page_flip) + if (arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) return -EINVAL; /* can't test and expect an event at the same time. */