diff mbox series

[5/5] drm/i915: Make hdcp2_msg_timeout.timeout u16

Message ID 20191010145127.7487-5-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [1/5] drm/i915: Shrink eDRAM ways/sets arrays | expand

Commit Message

Ville Syrjälä Oct. 10, 2019, 2:51 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

All the timeout values fit in u16, so let's shrink the structure
a bit.

This ends up actually increasing the .text size a bit due to
some changes in instructions (constant imul+small jmps replaced
with mov+bigger jmpqs). Seems pretty arbitrary to me so I'll
just pretend I didn't see it.

    text	   data	    bss	    dec	    hex	filename
-  34521	    360	      0	  34881	   8841	intel_hdmi.o
+  34537	    360	      0	  34897	   8851	intel_hdmi.o

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ramalingam C Oct. 17, 2019, 7:08 a.m. UTC | #1 
On 2019-10-10 at 17:51:27 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> All the timeout values fit in u16, so let's shrink the structure
> a bit.
> 
> This ends up actually increasing the .text size a bit due to
> some changes in instructions (constant imul+small jmps replaced
> with mov+bigger jmpqs). Seems pretty arbitrary to me so I'll
> just pretend I didn't see it.
> 
>     text	   data	    bss	    dec	    hex	filename
> -  34521	    360	      0	  34881	   8841	intel_hdmi.o
> +  34537	    360	      0	  34897	   8851	intel_hdmi.o
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Looks Good to me.

Reviewed-by: Ramalingam C <ramalingam.c@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 2dd798d8b961..5e97df38d281 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1529,7 +1529,7 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)
>  
>  struct hdcp2_hdmi_msg_timeout {
>  	u8 msg_id;
> -	u32 timeout;
> +	u16 timeout;
>  };
>  
>  static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = {
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 2dd798d8b961..5e97df38d281 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1529,7 +1529,7 @@  bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)
 
 struct hdcp2_hdmi_msg_timeout {
 	u8 msg_id;
-	u32 timeout;
+	u16 timeout;
 };
 
 static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = {