diff mbox series

drm/i915: Correct the PCH type in irq postinstall

Message ID 20191016183514.11128-1-vivek.kasireddy@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Correct the PCH type in irq postinstall | expand

Commit Message

Kasireddy, Vivek Oct. 16, 2019, 6:35 p.m. UTC
JasperLake PCH (JSP) has DDI HPD pin mappings similar to TGP and not
MCC. Also add the correct HPD pin mappings for the MCC PCH.

Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Matt Roper Oct. 16, 2019, 11:47 p.m. UTC | #1
On Wed, Oct 16, 2019 at 11:35:14AM -0700, Vivek Kasireddy wrote:
> JasperLake PCH (JSP) has DDI HPD pin mappings similar to TGP and not
> MCC. Also add the correct HPD pin mappings for the MCC PCH.
> 
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>

Woops, yes.  Good catch.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_irq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index ef09fbb36f37..e618f4621308 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3803,8 +3803,11 @@ static void icp_irq_postinstall(struct drm_i915_private *dev_priv)
>  	if (HAS_PCH_TGP(dev_priv))
>  		icp_hpd_detection_setup(dev_priv, TGP_DDI_HPD_ENABLE_MASK,
>  					TGP_TC_HPD_ENABLE_MASK);
> -	else if (HAS_PCH_MCC(dev_priv))
> +	else if (HAS_PCH_JSP(dev_priv))
>  		icp_hpd_detection_setup(dev_priv, TGP_DDI_HPD_ENABLE_MASK, 0);
> +	else if (HAS_PCH_MCC(dev_priv))
> +		icp_hpd_detection_setup(dev_priv, ICP_DDI_HPD_ENABLE_MASK,
> +					ICP_TC_HPD_ENABLE(PORT_TC1));
>  	else
>  		icp_hpd_detection_setup(dev_priv, ICP_DDI_HPD_ENABLE_MASK,
>  					ICP_TC_HPD_ENABLE_MASK);
> -- 
> 2.21.0
>
Matt Roper Oct. 17, 2019, 3:47 p.m. UTC | #2
On Thu, Oct 17, 2019 at 01:35:20AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Correct the PCH type in irq postinstall
> URL   : https://patchwork.freedesktop.org/series/68116/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7114 -> Patchwork_14843
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_14843 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_14843, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_14843:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_selftest@live_execlists:
>     - fi-icl-u2:          [PASS][1] -> [DMESG-FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-u2/igt@i915_selftest@live_execlists.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u2/igt@i915_selftest@live_execlists.html
>     - fi-icl-u3:          [PASS][3] -> [DMESG-FAIL][4]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-u3/igt@i915_selftest@live_execlists.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt@i915_selftest@live_execlists.html

These appear to be a GPU hang and "i915/intel_execlists_live_selftests:
live_timeslice_preempt failed with error -5;" not related to the PCH
fix in this patch.

> 
>   * igt@i915_selftest@live_gem_contexts:
>     - fi-cfl-8109u:       [PASS][5] -> [DMESG-FAIL][6]
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html


This is some kind of a timeout during a GEM selftest
("i915/i915_gem_context_live_selftests: live_parallel_switch failed with
error -62").  Errno -62 is -ETIME.  Also not related to this patch.

Will poke CI for a retest.


Matt


> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_14843 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@prime_busy@basic-wait-after-default:
>     - fi-icl-u3:          [PASS][7] -> [DMESG-WARN][8] ([fdo#107724]) +2 similar issues
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-u3/igt@prime_busy@basic-wait-after-default.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt@prime_busy@basic-wait-after-default.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_ctx_create@basic-files:
>     - fi-bdw-gvtdvm:      [DMESG-WARN][9] -> [PASS][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-bdw-gvtdvm/igt@gem_ctx_create@basic-files.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-bdw-gvtdvm/igt@gem_ctx_create@basic-files.html
> 
>   * igt@gem_flink_basic@double-flink:
>     - fi-icl-u3:          [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] +2 similar issues
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-u3/igt@gem_flink_basic@double-flink.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt@gem_flink_basic@double-flink.html
> 
>   * igt@i915_selftest@live_execlists:
>     - fi-cfl-guc:         [DMESG-FAIL][13] -> [PASS][14]
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cfl-guc/igt@i915_selftest@live_execlists.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cfl-guc/igt@i915_selftest@live_execlists.html
>     - fi-cml-u:           [DMESG-FAIL][15] -> [PASS][16]
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cml-u/igt@i915_selftest@live_execlists.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cml-u/igt@i915_selftest@live_execlists.html
>     - fi-whl-u:           [INCOMPLETE][17] -> [PASS][18]
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-whl-u/igt@i915_selftest@live_execlists.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-whl-u/igt@i915_selftest@live_execlists.html
> 
>   * igt@i915_selftest@live_gtt:
>     - {fi-icl-guc}:       [INCOMPLETE][19] ([fdo#107713]) -> [PASS][20]
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-guc/igt@i915_selftest@live_gtt.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-guc/igt@i915_selftest@live_gtt.html
> 
>   * igt@kms_busy@basic-flip-a:
>     - {fi-tgl-u2}:        [DMESG-WARN][21] ([fdo#111600]) -> [PASS][22]
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>   [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
>   [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
>   [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
>   [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
> 
> 
> Participating hosts (52 -> 45)
> ------------------------------
> 
>   Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-apl-guc fi-icl-y fi-byt-clapper fi-bdw-samus 
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7114 -> Patchwork_14843
> 
>   CI-20190529: 20190529
>   CI_DRM_7114: d9e909272a022597067d3ac2dfcedacd63c61af9 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5231: e293051f8f99c72cb01d21e4b73a5928ea351eb3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_14843: fc78057da300be38f969bdde6934ef344543235d @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> fc78057da300 drm/i915: Correct the PCH type in irq postinstall
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Saarinen, Jani Oct. 17, 2019, 4:03 p.m. UTC | #3
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Matt Roper
> Sent: torstai 17. lokakuuta 2019 18.47
> To: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Correct the PCH type in irq
> postinstall
> 
> On Thu, Oct 17, 2019 at 01:35:20AM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: drm/i915: Correct the PCH type in irq postinstall
> > URL   : https://patchwork.freedesktop.org/series/68116/
> > State : failure
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_7114 -> Patchwork_14843
> > ====================================================
> >
> > Summary
> > -------
> >
> >   **FAILURE**
> >
> >   Serious unknown changes coming with Patchwork_14843 absolutely need to be
> >   verified manually.
> >
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_14843, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> >
> >   External URL:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/index.html
> >
> > Possible new issues
> > -------------------
> >
> >   Here are the unknown changes that may have been introduced in
> Patchwork_14843:
> >
> > ### IGT changes ###
> >
> > #### Possible regressions ####
> >
> >   * igt@i915_selftest@live_execlists:
> >     - fi-icl-u2:          [PASS][1] -> [DMESG-FAIL][2]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> u2/igt@i915_selftest@live_execlists.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-
> u2/igt@i915_selftest@live_execlists.html
> >     - fi-icl-u3:          [PASS][3] -> [DMESG-FAIL][4]
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> u3/igt@i915_selftest@live_execlists.html
> >    [4]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt
> > @i915_selftest@live_execlists.html
> 
> These appear to be a GPU hang and "i915/intel_execlists_live_selftests:
> live_timeslice_preempt failed with error -5;" not related to the PCH fix in this patch.

These are seen lately on many series, don’t we have bug about these? 
> 
> >
> >   * igt@i915_selftest@live_gem_contexts:
> >     - fi-cfl-8109u:       [PASS][5] -> [DMESG-FAIL][6]
> >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cfl-
> 8109u/igt@i915_selftest@live_gem_contexts.html
> >    [6]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cfl-8109u/
> > igt@i915_selftest@live_gem_contexts.html
> 
> 
> This is some kind of a timeout during a GEM selftest
> ("i915/i915_gem_context_live_selftests: live_parallel_switch failed with error -62").
> Errno -62 is -ETIME.  Also not related to this patch.
Same this too. 


> 
> Will poke CI for a retest.
> 
> 
> Matt
> 
> 
> >
> >
> > Known issues
> > ------------
> >
> >   Here are the changes found in Patchwork_14843 that come from known issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> >   * igt@prime_busy@basic-wait-after-default:
> >     - fi-icl-u3:          [PASS][7] -> [DMESG-WARN][8] ([fdo#107724]) +2 similar issues
> >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> u3/igt@prime_busy@basic-wait-after-default.html
> >    [8]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt
> > @prime_busy@basic-wait-after-default.html
> >
> >
> > #### Possible fixes ####
> >
> >   * igt@gem_ctx_create@basic-files:
> >     - fi-bdw-gvtdvm:      [DMESG-WARN][9] -> [PASS][10]
> >    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-bdw-
> gvtdvm/igt@gem_ctx_create@basic-files.html
> >    [10]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-bdw-gvtdvm
> > /igt@gem_ctx_create@basic-files.html
> >
> >   * igt@gem_flink_basic@double-flink:
> >     - fi-icl-u3:          [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] +2 similar
> issues
> >    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> u3/igt@gem_flink_basic@double-flink.html
> >    [12]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt
> > @gem_flink_basic@double-flink.html
> >
> >   * igt@i915_selftest@live_execlists:
> >     - fi-cfl-guc:         [DMESG-FAIL][13] -> [PASS][14]
> >    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cfl-
> guc/igt@i915_selftest@live_execlists.html
> >    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cfl-
> guc/igt@i915_selftest@live_execlists.html
> >     - fi-cml-u:           [DMESG-FAIL][15] -> [PASS][16]
> >    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cml-
> u/igt@i915_selftest@live_execlists.html
> >    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cml-
> u/igt@i915_selftest@live_execlists.html
> >     - fi-whl-u:           [INCOMPLETE][17] -> [PASS][18]
> >    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-whl-
> u/igt@i915_selftest@live_execlists.html
> >    [18]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-whl-u/igt@
> > i915_selftest@live_execlists.html
> >
> >   * igt@i915_selftest@live_gtt:
> >     - {fi-icl-guc}:       [INCOMPLETE][19] ([fdo#107713]) -> [PASS][20]
> >    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> guc/igt@i915_selftest@live_gtt.html
> >    [20]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-guc/ig
> > t@i915_selftest@live_gtt.html
> >
> >   * igt@kms_busy@basic-flip-a:
> >     - {fi-tgl-u2}:        [DMESG-WARN][21] ([fdo#111600]) -> [PASS][22]
> >    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-tgl-
> u2/igt@kms_busy@basic-flip-a.html
> >    [22]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-tgl-u2/igt
> > @kms_busy@basic-flip-a.html
> >
> >
> >   {name}: This element is suppressed. This means it is ignored when computing
> >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> >
> >   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
> >   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
> >   [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
> >   [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
> >   [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
> >   [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
> >
> >
> > Participating hosts (52 -> 45)
> > ------------------------------
> >
> >   Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-apl-guc fi-icl-y fi-byt-
> clapper fi-bdw-samus
> >
> >
> > Build changes
> > -------------
> >
> >   * CI: CI-20190529 -> None
> >   * Linux: CI_DRM_7114 -> Patchwork_14843
> >
> >   CI-20190529: 20190529
> >   CI_DRM_7114: d9e909272a022597067d3ac2dfcedacd63c61af9 @
> git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_5231: e293051f8f99c72cb01d21e4b73a5928ea351eb3 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >   Patchwork_14843: fc78057da300be38f969bdde6934ef344543235d @
> > git://anongit.freedesktop.org/gfx-ci/linux
> >
> >
> > == Linux commits ==
> >
> > fc78057da300 drm/i915: Correct the PCH type in irq postinstall
> >
> > == Logs ==
> >
> > For more details see:
> > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/index.html
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Matt Roper
> Graphics Software Engineer
> VTT-OSGC Platform Enablement
> Intel Corporation
> (916) 356-2795
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Matt Roper Oct. 17, 2019, 4:18 p.m. UTC | #4
On Thu, Oct 17, 2019 at 09:03:20AM -0700, Saarinen, Jani wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Matt Roper
> > Sent: torstai 17. lokakuuta 2019 18.47
> > To: intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Correct the PCH type in irq
> > postinstall
> > 
> > On Thu, Oct 17, 2019 at 01:35:20AM +0000, Patchwork wrote:
> > > == Series Details ==
> > >
> > > Series: drm/i915: Correct the PCH type in irq postinstall
> > > URL   : https://patchwork.freedesktop.org/series/68116/
> > > State : failure
> > >
> > > == Summary ==
> > >
> > > CI Bug Log - changes from CI_DRM_7114 -> Patchwork_14843
> > > ====================================================
> > >
> > > Summary
> > > -------
> > >
> > >   **FAILURE**
> > >
> > >   Serious unknown changes coming with Patchwork_14843 absolutely need to be
> > >   verified manually.
> > >
> > >   If you think the reported changes have nothing to do with the changes
> > >   introduced in Patchwork_14843, please notify your bug team to allow them
> > >   to document this new failure mode, which will reduce false positives in CI.
> > >
> > >   External URL:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/index.html
> > >
> > > Possible new issues
> > > -------------------
> > >
> > >   Here are the unknown changes that may have been introduced in
> > Patchwork_14843:
> > >
> > > ### IGT changes ###
> > >
> > > #### Possible regressions ####
> > >
> > >   * igt@i915_selftest@live_execlists:
> > >     - fi-icl-u2:          [PASS][1] -> [DMESG-FAIL][2]
> > >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> > u2/igt@i915_selftest@live_execlists.html
> > >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-
> > u2/igt@i915_selftest@live_execlists.html
> > >     - fi-icl-u3:          [PASS][3] -> [DMESG-FAIL][4]
> > >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> > u3/igt@i915_selftest@live_execlists.html
> > >    [4]:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt
> > > @i915_selftest@live_execlists.html
> > 
> > These appear to be a GPU hang and "i915/intel_execlists_live_selftests:
> > live_timeslice_preempt failed with error -5;" not related to the PCH fix in this patch.
> 
> These are seen lately on many series, don’t we have bug about these? 

It matches the title of
https://bugs.freedesktop.org/show_bug.cgi?id=111872 which is already
resolved, but I don't have enough GEM insight to know if it's truly the
same root cause or not?

> > 
> > >
> > >   * igt@i915_selftest@live_gem_contexts:
> > >     - fi-cfl-8109u:       [PASS][5] -> [DMESG-FAIL][6]
> > >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cfl-
> > 8109u/igt@i915_selftest@live_gem_contexts.html
> > >    [6]:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cfl-8109u/
> > > igt@i915_selftest@live_gem_contexts.html
> > 
> > 
> > This is some kind of a timeout during a GEM selftest
> > ("i915/i915_gem_context_live_selftests: live_parallel_switch failed with error -62").
> > Errno -62 is -ETIME.  Also not related to this patch.
> Same this too. 
> 

I don't see anything obvious in the bug list that matches this one.


Matt

> 
> > 
> > Will poke CI for a retest.
> > 
> > 
> > Matt
> > 
> > 
> > >
> > >
> > > Known issues
> > > ------------
> > >
> > >   Here are the changes found in Patchwork_14843 that come from known issues:
> > >
> > > ### IGT changes ###
> > >
> > > #### Issues hit ####
> > >
> > >   * igt@prime_busy@basic-wait-after-default:
> > >     - fi-icl-u3:          [PASS][7] -> [DMESG-WARN][8] ([fdo#107724]) +2 similar issues
> > >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> > u3/igt@prime_busy@basic-wait-after-default.html
> > >    [8]:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt
> > > @prime_busy@basic-wait-after-default.html
> > >
> > >
> > > #### Possible fixes ####
> > >
> > >   * igt@gem_ctx_create@basic-files:
> > >     - fi-bdw-gvtdvm:      [DMESG-WARN][9] -> [PASS][10]
> > >    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-bdw-
> > gvtdvm/igt@gem_ctx_create@basic-files.html
> > >    [10]:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-bdw-gvtdvm
> > > /igt@gem_ctx_create@basic-files.html
> > >
> > >   * igt@gem_flink_basic@double-flink:
> > >     - fi-icl-u3:          [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] +2 similar
> > issues
> > >    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> > u3/igt@gem_flink_basic@double-flink.html
> > >    [12]:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-u3/igt
> > > @gem_flink_basic@double-flink.html
> > >
> > >   * igt@i915_selftest@live_execlists:
> > >     - fi-cfl-guc:         [DMESG-FAIL][13] -> [PASS][14]
> > >    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cfl-
> > guc/igt@i915_selftest@live_execlists.html
> > >    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cfl-
> > guc/igt@i915_selftest@live_execlists.html
> > >     - fi-cml-u:           [DMESG-FAIL][15] -> [PASS][16]
> > >    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-cml-
> > u/igt@i915_selftest@live_execlists.html
> > >    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-cml-
> > u/igt@i915_selftest@live_execlists.html
> > >     - fi-whl-u:           [INCOMPLETE][17] -> [PASS][18]
> > >    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-whl-
> > u/igt@i915_selftest@live_execlists.html
> > >    [18]:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-whl-u/igt@
> > > i915_selftest@live_execlists.html
> > >
> > >   * igt@i915_selftest@live_gtt:
> > >     - {fi-icl-guc}:       [INCOMPLETE][19] ([fdo#107713]) -> [PASS][20]
> > >    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-icl-
> > guc/igt@i915_selftest@live_gtt.html
> > >    [20]:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-icl-guc/ig
> > > t@i915_selftest@live_gtt.html
> > >
> > >   * igt@kms_busy@basic-flip-a:
> > >     - {fi-tgl-u2}:        [DMESG-WARN][21] ([fdo#111600]) -> [PASS][22]
> > >    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7114/fi-tgl-
> > u2/igt@kms_busy@basic-flip-a.html
> > >    [22]:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/fi-tgl-u2/igt
> > > @kms_busy@basic-flip-a.html
> > >
> > >
> > >   {name}: This element is suppressed. This means it is ignored when computing
> > >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> > >
> > >   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
> > >   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
> > >   [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
> > >   [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
> > >   [fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
> > >   [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
> > >
> > >
> > > Participating hosts (52 -> 45)
> > > ------------------------------
> > >
> > >   Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-apl-guc fi-icl-y fi-byt-
> > clapper fi-bdw-samus
> > >
> > >
> > > Build changes
> > > -------------
> > >
> > >   * CI: CI-20190529 -> None
> > >   * Linux: CI_DRM_7114 -> Patchwork_14843
> > >
> > >   CI-20190529: 20190529
> > >   CI_DRM_7114: d9e909272a022597067d3ac2dfcedacd63c61af9 @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > >   IGT_5231: e293051f8f99c72cb01d21e4b73a5928ea351eb3 @
> > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > >   Patchwork_14843: fc78057da300be38f969bdde6934ef344543235d @
> > > git://anongit.freedesktop.org/gfx-ci/linux
> > >
> > >
> > > == Linux commits ==
> > >
> > > fc78057da300 drm/i915: Correct the PCH type in irq postinstall
> > >
> > > == Logs ==
> > >
> > > For more details see:
> > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14843/index.html
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > 
> > --
> > Matt Roper
> > Graphics Software Engineer
> > VTT-OSGC Platform Enablement
> > Intel Corporation
> > (916) 356-2795
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Matt Roper Oct. 18, 2019, 4:30 p.m. UTC | #5
On Fri, Oct 18, 2019 at 04:01:56AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Correct the PCH type in irq postinstall (rev2)
> URL   : https://patchwork.freedesktop.org/series/68116/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7122_full -> Patchwork_14860_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_14860_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_14860_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 

The failures below are both GEM selftest failures unrelated to the PCH
changes here.  Applied to dinq; thanks for the patch.

>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_14860_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
>     - shard-kbl:          [PASS][1] -> [TIMEOUT][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-kbl1/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-kbl6/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

(gem_persistent_relocs:1348) CRITICAL: Failed assertion: test == 0xdeadbeef
(gem_persistent_relocs:1348) CRITICAL: mismatch in buffer 0: 0x00000000 instead of 0xdeadbeef at offset 192

Seems similar to https://bugs.freedesktop.org/show_bug.cgi?id=112037
even though that bug is reported as resolved?

>   * igt@gem_persistent_relocs@forked-interruptible-thrashing:
>     - shard-iclb:         [PASS][3] -> [FAIL][4]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html

<3> [666.513462] BUG: sleeping function called from invalid context at kernel/sched/completion.c:99
<3> [666.513471] in_atomic(): 0, irqs_disabled(): 0, non_block: 0, pid: 2066, name: gem_persistent_
<4> [666.513985] INFO: lockdep is turned off.
<3> [666.513991] Preemption disabled at:
<4> [666.513992] [<0000000000000000>] 0x0
<4> [666.514004] CPU: 2 PID: 2066 Comm: gem_persistent_ Tainted: G     UD           5.4.0-rc3-CI-Patchwork_14860+ #1
<4> [666.514015] Hardware name:  /NUC7i5BNB, BIOS BNKBL357.86A.0054.2017.1025.1822 10/25/2017
<4> [666.514026] Call Trace:
<4> [666.514036]  dump_stack+0x67/0x9b
<4> [666.514046]  ___might_sleep+0x178/0x260
<4> [666.514055]  wait_for_completion+0x37/0x1a0
<4> [666.514067]  virt_efi_query_variable_info+0x161/0x1b0
<4> [666.514077]  efi_query_variable_store+0xb3/0x1a0
<4> [666.514087]  ? efivar_entry_set_safe+0x19c/0x220
<4> [666.514096]  ? efi_delete_dummy_variable+0x90/0x90
<4> [666.514103]  efivar_entry_set_safe+0x19c/0x220
<4> [666.514112]  ? efi_pstore_write+0x10b/0x150
<4> [666.514119]  efi_pstore_write+0x10b/0x150
<4> [666.514132]  pstore_dump+0x127/0x340
<4> [666.514142]  kmsg_dump+0x87/0x1c0
<4> [666.514150]  oops_end+0x3e/0x90
<4> [666.514158]  do_trap+0x80/0x100
<4> [666.514217]  ? __i915_vma_unbind.part.39+0x207/0x460 [i915]
<4> [666.514227]  do_invalid_op+0x23/0x30
<4> [666.514283]  ? __i915_vma_unbind.part.39+0x207/0x460 [i915]
<4> [666.514293]  invalid_op+0x23/0x30
<4> [666.514345] RIP: 0010:__i915_vma_unbind.part.39+0x207/0x460 [i915]
<4> [666.514355] Code: 48 96 db e0 48 8b 35 00 6a 1d 00 49 c7 c0 da ec 4a a0 b9 7e 04 00 00 48 c7 c2 80 0c 45 a0 48 c7 c7 52 19 37 a0 e8 19 92 e2 e0 <0f> 0b 48 c7 c1 da ec 4a a0 ba 84 04 00 00 48 c7 c6 80 0c 45 a0 48
<4> [666.514375] RSP: 0018:ffffc9000039fc78 EFLAGS: 00010286
<4> [666.514382] RAX: 000000000000000c RBX: ffff888275b00988 RCX: 0000000000000000
<4> [666.514391] RDX: 0000000000000001 RSI: 0000000000000008 RDI: ffff88827596a800
<4> [666.514399] RBP: ffff8882677a4f00 R08: 000000000014ce79 R09: ffff888251014000
<4> [666.514408] R10: ffffc9000039fc10 R11: ffff88827596a800 R12: ffff88813fc76648
<4> [666.514419] R13: ffffc9000039fcd0 R14: ffff88813fc76440 R15: ffffc9000039fcd0
<4> [666.514479]  ? __i915_vma_unbind.part.39+0x207/0x460 [i915]
<4> [666.514533]  i915_vma_unbind+0x2d/0x50 [i915]
<4> [666.514585]  i915_gem_object_unbind+0x11c/0x250 [i915]
<4> [666.514637]  i915_gem_shrink+0x297/0x5f0 [i915]
<4> [666.514684]  ? i915_drop_caches_set+0x141/0x250 [i915]
<4> [666.514725]  i915_drop_caches_set+0x141/0x250 [i915]
<4> [666.514737]  simple_attr_write+0xb0/0xd0
<4> [666.514747]  full_proxy_write+0x51/0x80
<4> [666.514757]  vfs_write+0xb9/0x1d0
<4> [666.514765]  ksys_write+0x9f/0xe0
<4> [666.514774]  do_syscall_64+0x4f/0x210
<4> [666.514782]  entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4> [666.514790] RIP: 0033:0x7f7235a54281
<4> [666.514796] Code: c3 0f 1f 84 00 00 00 00 00 48 8b 05 59 8d 20 00 c3 0f 1f 84 00 00 00 00 00 8b 05 8a d1 20 00 85 c0 75 16 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 57 f3 c3 0f 1f 44 00 00 41 54 55 49 89 d4 53
<4> [666.514815] RSP: 002b:00007fff5621f168 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
<4> [666.514825] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f7235a54281
<4> [666.514835] RDX: 0000000000000003 RSI: 00007fff5621f1c0 RDI: 0000000000000008
<4> [666.514846] RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000000
<4> [666.514856] R10: 0000000000000000 R11: 0000000000000246 R12: 00007fff5621f1c0
<4> [666.514866] R13: 0000000000000008 R14: 00007fff5621f1c0 R15: 0000000000000000

I don't see any obvious fdo bugs that match this?


Matt

> 
>   
> #### Suppressed ####
> 
>   The following results come from untrusted machines, tests, or statuses.
>   They do not affect the overall result.
> 
>   * {igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding}:
>     - {shard-tglb}:       NOTRUN -> [FAIL][5] +4 similar issues
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding.html
> 
>   * {igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen}:
>     - {shard-tglb}:       NOTRUN -> [SKIP][6] +2 similar issues
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-tglb5/igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen.html
> 
>   
> New tests
> ---------
> 
>   New tests have been introduced between CI_DRM_7122_full and Patchwork_14860_full:
> 
> ### New Piglit tests (3) ###
> 
>   * spec@arb_texture_compression@fbo-generatemipmap-formats:
>     - Statuses : 1 incomplete(s)
>     - Exec time: [0.0] s
> 
>   * spec@arb_texture_compression_bptc@fbo-generatemipmap-formats float:
>     - Statuses : 1 incomplete(s)
>     - Exec time: [0.0] s
> 
>   * spec@arb_texture_compression_bptc@fbo-generatemipmap-formats unorm:
>     - Statuses : 1 incomplete(s)
>     - Exec time: [0.0] s
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_14860_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_exec_schedule@preempt-queue-chain-bsd2:
>     - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109276]) +12 similar issues
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb1/igt@gem_exec_schedule@preempt-queue-chain-bsd2.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb8/igt@gem_exec_schedule@preempt-queue-chain-bsd2.html
> 
>   * igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
>     - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#111325]) +3 similar issues
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb7/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb1/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
> 
>   * igt@gem_userptr_blits@dmabuf-unsync:
>     - shard-snb:          [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-snb5/igt@gem_userptr_blits@dmabuf-unsync.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-snb2/igt@gem_userptr_blits@dmabuf-unsync.html
> 
>   * igt@gem_userptr_blits@sync-unmap-after-close:
>     - shard-apl:          [PASS][13] -> [DMESG-WARN][14] ([fdo#109385] / [fdo#111870])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-apl8/igt@gem_userptr_blits@sync-unmap-after-close.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-apl4/igt@gem_userptr_blits@sync-unmap-after-close.html
> 
>   * igt@i915_pm_rpm@i2c:
>     - shard-glk:          [PASS][15] -> [FAIL][16] ([fdo#104097])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-glk4/igt@i915_pm_rpm@i2c.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-glk8/igt@i915_pm_rpm@i2c.html
> 
>   * igt@kms_color@pipe-b-ctm-blue-to-red:
>     - shard-skl:          [PASS][17] -> [DMESG-WARN][18] ([fdo#106107])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-skl5/igt@kms_color@pipe-b-ctm-blue-to-red.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-skl9/igt@kms_color@pipe-b-ctm-blue-to-red.html
> 
>   * igt@kms_flip@2x-flip-vs-expired-vblank:
>     - shard-glk:          [PASS][19] -> [FAIL][20] ([fdo#105363])
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank.html
> 
>   * igt@kms_flip@2x-modeset-vs-vblank-race:
>     - shard-glk:          [PASS][21] -> [FAIL][22] ([fdo#111609])
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-glk7/igt@kms_flip@2x-modeset-vs-vblank-race.html
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-glk9/igt@kms_flip@2x-modeset-vs-vblank-race.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-skl:          [PASS][23] -> [FAIL][24] ([fdo#105363])
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-rte:
>     - shard-iclb:         [PASS][25] -> [FAIL][26] ([fdo#103167] / [fdo#110378]) +1 similar issue
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt:
>     - shard-iclb:         [PASS][27] -> [FAIL][28] ([fdo#103167]) +4 similar issues
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
> 
>   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
>     - shard-skl:          [PASS][29] -> [FAIL][30] ([fdo#108145])
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> 
>   * igt@kms_psr@psr2_sprite_plane_move:
>     - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +2 similar issues
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
> 
>   * igt@kms_vblank@pipe-a-ts-continuation-suspend:
>     - shard-apl:          [PASS][33] -> [DMESG-WARN][34] ([fdo#108566]) +5 similar issues
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
> 
>   * igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
>     - shard-iclb:         [PASS][35] -> [INCOMPLETE][36] ([fdo#107713]) +1 similar issue
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb4/igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm.html
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb1/igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_exec_schedule@preempt-queue-bsd1:
>     - shard-iclb:         [SKIP][37] ([fdo#109276]) -> [PASS][38] +17 similar issues
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
> 
>   * igt@gem_exec_schedule@reorder-wide-bsd:
>     - shard-iclb:         [SKIP][39] ([fdo#111325]) -> [PASS][40] +6 similar issues
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
> 
>   * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
>     - shard-apl:          [INCOMPLETE][41] ([fdo#103927]) -> [PASS][42] +4 similar issues
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-apl3/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-apl3/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
> 
>   * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
>     - shard-snb:          [DMESG-WARN][43] ([fdo#111870]) -> [PASS][44]
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> 
>   * igt@gem_userptr_blits@sync-unmap-after-close:
>     - shard-hsw:          [DMESG-WARN][45] ([fdo#111870]) -> [PASS][46]
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html
> 
>   * igt@i915_selftest@live_execlists:
>     - shard-skl:          [DMESG-FAIL][47] -> [PASS][48]
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-skl9/igt@i915_selftest@live_execlists.html
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-skl1/igt@i915_selftest@live_execlists.html
> 
>   * igt@i915_suspend@sysfs-reader:
>     - shard-apl:          [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +3 similar issues
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-apl2/igt@i915_suspend@sysfs-reader.html
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-apl1/igt@i915_suspend@sysfs-reader.html
> 
>   * igt@kms_atomic@crtc_invalid_params:
>     - shard-snb:          [SKIP][51] ([fdo#109271]) -> [PASS][52]
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-snb7/igt@kms_atomic@crtc_invalid_params.html
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-snb7/igt@kms_atomic@crtc_invalid_params.html
> 
>   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
>     - shard-hsw:          [FAIL][53] ([fdo#105767]) -> [PASS][54]
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-apl:          [FAIL][55] ([fdo#105363]) -> [PASS][56]
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-apl6/igt@kms_flip@flip-vs-expired-vblank.html
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-apl7/igt@kms_flip@flip-vs-expired-vblank.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
>     - shard-iclb:         [FAIL][57] ([fdo#103167]) -> [PASS][58] +2 similar issues
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> 
>   * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
>     - shard-skl:          [FAIL][59] ([fdo#108145]) -> [PASS][60]
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          [FAIL][61] ([fdo#99912]) -> [PASS][62]
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-apl4/igt@kms_setmode@basic.html
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-apl4/igt@kms_setmode@basic.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_ctx_isolation@vcs1-nonpriv:
>     - shard-iclb:         [SKIP][63] ([fdo#109276]) -> [FAIL][64] ([fdo#111329])
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7122/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
>   [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
>   [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>   [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
>   [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
>   [fdo#109385]: https://bugs.freedesktop.org/show_bug.cgi?id=109385
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
>   [fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
>   [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
>   [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
>   [fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
>   [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
>   [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
>   [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> 
> 
> Participating hosts (11 -> 11)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_7122 -> Patchwork_14860
> 
>   CI-20190529: 20190529
>   CI_DRM_7122: c2f6bdc09f8f046cd38e3c39c92e14e6033dbd44 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5232: bb5735423eaf6fdbf6b2f94ef0b8520e74eab993 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_14860: 44f036318c26aba453888e79cedbe7f64b54bde7 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14860/index.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index ef09fbb36f37..e618f4621308 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -3803,8 +3803,11 @@  static void icp_irq_postinstall(struct drm_i915_private *dev_priv)
 	if (HAS_PCH_TGP(dev_priv))
 		icp_hpd_detection_setup(dev_priv, TGP_DDI_HPD_ENABLE_MASK,
 					TGP_TC_HPD_ENABLE_MASK);
-	else if (HAS_PCH_MCC(dev_priv))
+	else if (HAS_PCH_JSP(dev_priv))
 		icp_hpd_detection_setup(dev_priv, TGP_DDI_HPD_ENABLE_MASK, 0);
+	else if (HAS_PCH_MCC(dev_priv))
+		icp_hpd_detection_setup(dev_priv, ICP_DDI_HPD_ENABLE_MASK,
+					ICP_TC_HPD_ENABLE(PORT_TC1));
 	else
 		icp_hpd_detection_setup(dev_priv, ICP_DDI_HPD_ENABLE_MASK,
 					ICP_TC_HPD_ENABLE_MASK);