diff mbox series

[1/2] drm/i915/cml: Remove unsupport PCI ID

Message ID 20191025154933.22607-1-shawn.c.lee@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/i915/cml: Remove unsupport PCI ID | expand

Commit Message

Lee, Shawn C Oct. 25, 2019, 3:49 p.m. UTC
commit 'a7b4deeb02b9 ("drm/i915/cml: Add CML PCI IDS)'
introduced new PCI ID that CML support. But some sku
is not support yet so remove them avoid unexpected issue.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
 include/drm/i915_pciids.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Jani Nikula Oct. 25, 2019, 8:41 a.m. UTC | #1
On Fri, 25 Oct 2019, Lee Shawn C <shawn.c.lee@intel.com> wrote:
> commit 'a7b4deeb02b9 ("drm/i915/cml: Add CML PCI IDS)'
> introduced new PCI ID that CML support. But some sku
> is not support yet so remove them avoid unexpected issue.

Please elaborate.

BR,
Jani.


>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
>  include/drm/i915_pciids.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index a70c982ddff9..56e823cdc717 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -448,9 +448,7 @@
>  #define INTEL_CML_GT1_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x9B21, info), \
>  	INTEL_VGA_DEVICE(0x9BAA, info), \
> -	INTEL_VGA_DEVICE(0x9BAB, info), \
>  	INTEL_VGA_DEVICE(0x9BAC, info), \
> -	INTEL_VGA_DEVICE(0x9BA0, info), \
>  	INTEL_VGA_DEVICE(0x9BA5, info), \
>  	INTEL_VGA_DEVICE(0x9BA8, info), \
>  	INTEL_VGA_DEVICE(0x9BA4, info), \
> @@ -460,9 +458,7 @@
>  #define INTEL_CML_GT2_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x9B41, info), \
>  	INTEL_VGA_DEVICE(0x9BCA, info), \
> -	INTEL_VGA_DEVICE(0x9BCB, info), \
>  	INTEL_VGA_DEVICE(0x9BCC, info), \
> -	INTEL_VGA_DEVICE(0x9BC0, info), \
>  	INTEL_VGA_DEVICE(0x9BC5, info), \
>  	INTEL_VGA_DEVICE(0x9BC8, info), \
>  	INTEL_VGA_DEVICE(0x9BC4, info), \
Lee, Shawn C Oct. 25, 2019, 11:56 a.m. UTC | #2
On Fri, 25 Oct 2019, Jani Nikula <jani.nikula@intel.com> wrote:
>On Fri, 25 Oct 2019, Lee Shawn C <shawn.c.lee@intel.com> wrote:
>> commit 'a7b4deeb02b9 ("drm/i915/cml: Add CML PCI IDS)'
>> introduced new PCI ID that CML support. But some sku is not support 
>> yet so remove them avoid unexpected issue.
>
>Please elaborate.
>
>BR,
>Jani.
>

So far, I did not meet real issue. Just find some sku were removed
from support list.

>
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>>  include/drm/i915_pciids.h | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h 
>> index a70c982ddff9..56e823cdc717 100644
>> --- a/include/drm/i915_pciids.h
>> +++ b/include/drm/i915_pciids.h
>> @@ -448,9 +448,7 @@
>>  #define INTEL_CML_GT1_IDS(info)	\
>>  	INTEL_VGA_DEVICE(0x9B21, info), \
>>  	INTEL_VGA_DEVICE(0x9BAA, info), \
>> -	INTEL_VGA_DEVICE(0x9BAB, info), \
>>  	INTEL_VGA_DEVICE(0x9BAC, info), \
>> -	INTEL_VGA_DEVICE(0x9BA0, info), \
>>  	INTEL_VGA_DEVICE(0x9BA5, info), \
>>  	INTEL_VGA_DEVICE(0x9BA8, info), \
>>  	INTEL_VGA_DEVICE(0x9BA4, info), \
>> @@ -460,9 +458,7 @@
>>  #define INTEL_CML_GT2_IDS(info)	\
>>  	INTEL_VGA_DEVICE(0x9B41, info), \
>>  	INTEL_VGA_DEVICE(0x9BCA, info), \
>> -	INTEL_VGA_DEVICE(0x9BCB, info), \
>>  	INTEL_VGA_DEVICE(0x9BCC, info), \
>> -	INTEL_VGA_DEVICE(0x9BC0, info), \
>>  	INTEL_VGA_DEVICE(0x9BC5, info), \
>>  	INTEL_VGA_DEVICE(0x9BC8, info), \
>>  	INTEL_VGA_DEVICE(0x9BC4, info), \
>
>--
>Jani Nikula, Intel Open Source Graphics Center
>
diff mbox series

Patch

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index a70c982ddff9..56e823cdc717 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -448,9 +448,7 @@ 
 #define INTEL_CML_GT1_IDS(info)	\
 	INTEL_VGA_DEVICE(0x9B21, info), \
 	INTEL_VGA_DEVICE(0x9BAA, info), \
-	INTEL_VGA_DEVICE(0x9BAB, info), \
 	INTEL_VGA_DEVICE(0x9BAC, info), \
-	INTEL_VGA_DEVICE(0x9BA0, info), \
 	INTEL_VGA_DEVICE(0x9BA5, info), \
 	INTEL_VGA_DEVICE(0x9BA8, info), \
 	INTEL_VGA_DEVICE(0x9BA4, info), \
@@ -460,9 +458,7 @@ 
 #define INTEL_CML_GT2_IDS(info)	\
 	INTEL_VGA_DEVICE(0x9B41, info), \
 	INTEL_VGA_DEVICE(0x9BCA, info), \
-	INTEL_VGA_DEVICE(0x9BCB, info), \
 	INTEL_VGA_DEVICE(0x9BCC, info), \
-	INTEL_VGA_DEVICE(0x9BC0, info), \
 	INTEL_VGA_DEVICE(0x9BC5, info), \
 	INTEL_VGA_DEVICE(0x9BC8, info), \
 	INTEL_VGA_DEVICE(0x9BC4, info), \