diff mbox series

[07/10] drm/i915: Pass dev_priv to cpt_verify_modeset()

Message ID 20191112141503.1116-8-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Cleanups around .crtc_enable/disable() | expand

Commit Message

Ville Syrjälä Nov. 12, 2019, 2:15 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Get rid of the last 'dev' usage in ironlake_crtc_enable() by
passing dev_priv to cpt_verify_modeset().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Navare, Manasi Nov. 14, 2019, 12:23 a.m. UTC | #1 
On Tue, Nov 12, 2019 at 04:15:00PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Get rid of the last 'dev' usage in ironlake_crtc_enable() by
> passing dev_priv to cpt_verify_modeset().
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Manasi

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 77b739cda053..6afdbfbb3264 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5462,9 +5462,9 @@ static void lpt_pch_enable(const struct intel_atomic_state *state,
>  	lpt_enable_pch_transcoder(dev_priv, cpu_transcoder);
>  }
>  
> -static void cpt_verify_modeset(struct drm_device *dev, enum pipe pipe)
> +static void cpt_verify_modeset(struct drm_i915_private *dev_priv,
> +			       enum pipe pipe)
>  {
> -	struct drm_i915_private *dev_priv = to_i915(dev);
>  	i915_reg_t dslreg = PIPEDSL(pipe);
>  	u32 temp;
>  
> @@ -6538,7 +6538,7 @@ static void ironlake_crtc_enable(struct intel_crtc_state *pipe_config,
>  	intel_encoders_enable(state, intel_crtc);
>  
>  	if (HAS_PCH_CPT(dev_priv))
> -		cpt_verify_modeset(dev, intel_crtc->pipe);
> +		cpt_verify_modeset(dev_priv, pipe);
>  
>  	/*
>  	 * Must wait for vblank to avoid spurious PCH FIFO underruns.
> -- 
> 2.23.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 77b739cda053..6afdbfbb3264 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -5462,9 +5462,9 @@  static void lpt_pch_enable(const struct intel_atomic_state *state,
 	lpt_enable_pch_transcoder(dev_priv, cpu_transcoder);
 }
 
-static void cpt_verify_modeset(struct drm_device *dev, enum pipe pipe)
+static void cpt_verify_modeset(struct drm_i915_private *dev_priv,
+			       enum pipe pipe)
 {
-	struct drm_i915_private *dev_priv = to_i915(dev);
 	i915_reg_t dslreg = PIPEDSL(pipe);
 	u32 temp;
 
@@ -6538,7 +6538,7 @@  static void ironlake_crtc_enable(struct intel_crtc_state *pipe_config,
 	intel_encoders_enable(state, intel_crtc);
 
 	if (HAS_PCH_CPT(dev_priv))
-		cpt_verify_modeset(dev, intel_crtc->pipe);
+		cpt_verify_modeset(dev_priv, pipe);
 
 	/*
 	 * Must wait for vblank to avoid spurious PCH FIFO underruns.