| Message ID | 20191215213307.689830-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/i915/dsi: Remove readback of panel orientation on BYT / CHT | expand |
On Sun, Dec 15, 2019 at 10:33:06PM +0100, Hans de Goede wrote: > Commit 82daca297506 ("drm/i915: Add "panel orientation" property to the > panel connector, v6.") uses hardware state readback to determine if the > GOP is rotating the image by 180 degrees to compensate for upside-down > mounted panels. > > When I wrote that commit I tried to find the VBT bits the GOP used to > decide to rotate the image, but I could not find them. Back then I only > looked at the rotation bits in struct mipi_config and these read 0 on > the 1 BYT device I have with an upside-down mounted panel > (a GP-electronic T701 tablet). While working on a similar problem on a > BYT device with an eDP panel I noticed that the new > intel_dsi_get_panel_orientation() helper which gets used on newer > SoCs (Apollo-Lake, etc.) checks the rotate_180 bit in the > BDB_GENERAL_FEATURES VBT block. > > I've checked and this bit indeed is set on the GP-electronic T701 tablet, > so using the generic intel_dsi_get_panel_orientation() helper there does > the right thing without needing any extra readback of hw state. > > This commit removes the special handling of the panel orientation for > DSI panels on BYT/CHT devices, bringing the handling in line with the > handling of DSI panels on other devices. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Same as https://patchwork.freedesktop.org/patch/257787/?series=51274&rev=4 which I apparently never pushed. But feel free to go with your version since you have more meat in the commit msg. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/vlv_dsi.c | 55 +------------------------- > 1 file changed, 1 insertion(+), 54 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c > index 0ca49b1604c6..18f7616e6c27 100644 > --- a/drivers/gpu/drm/i915/display/vlv_dsi.c > +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c > @@ -1563,59 +1563,6 @@ static const struct drm_connector_funcs intel_dsi_connector_funcs = { > .atomic_duplicate_state = intel_digital_connector_duplicate_state, > }; > > -static enum drm_panel_orientation > -vlv_dsi_get_hw_panel_orientation(struct intel_connector *connector) > -{ > - struct drm_i915_private *dev_priv = to_i915(connector->base.dev); > - struct intel_encoder *encoder = connector->encoder; > - enum intel_display_power_domain power_domain; > - enum drm_panel_orientation orientation; > - struct intel_plane *plane; > - struct intel_crtc *crtc; > - intel_wakeref_t wakeref; > - enum pipe pipe; > - u32 val; > - > - if (!encoder->get_hw_state(encoder, &pipe)) > - return DRM_MODE_PANEL_ORIENTATION_UNKNOWN; > - > - crtc = intel_get_crtc_for_pipe(dev_priv, pipe); > - plane = to_intel_plane(crtc->base.primary); > - > - power_domain = POWER_DOMAIN_PIPE(pipe); > - wakeref = intel_display_power_get_if_enabled(dev_priv, power_domain); > - if (!wakeref) > - return DRM_MODE_PANEL_ORIENTATION_UNKNOWN; > - > - val = I915_READ(DSPCNTR(plane->i9xx_plane)); > - > - if (!(val & DISPLAY_PLANE_ENABLE)) > - orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN; > - else if (val & DISPPLANE_ROTATE_180) > - orientation = DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP; > - else > - orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL; > - > - intel_display_power_put(dev_priv, power_domain, wakeref); > - > - return orientation; > -} > - > -static enum drm_panel_orientation > -vlv_dsi_get_panel_orientation(struct intel_connector *connector) > -{ > - struct drm_i915_private *dev_priv = to_i915(connector->base.dev); > - enum drm_panel_orientation orientation; > - > - if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) { > - orientation = vlv_dsi_get_hw_panel_orientation(connector); > - if (orientation != DRM_MODE_PANEL_ORIENTATION_UNKNOWN) > - return orientation; > - } > - > - return intel_dsi_get_panel_orientation(connector); > -} > - > static void vlv_dsi_add_properties(struct intel_connector *connector) > { > struct drm_i915_private *dev_priv = to_i915(connector->base.dev); > @@ -1633,7 +1580,7 @@ static void vlv_dsi_add_properties(struct intel_connector *connector) > connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT; > > connector->base.display_info.panel_orientation = > - vlv_dsi_get_panel_orientation(connector); > + intel_dsi_get_panel_orientation(connector); > drm_connector_init_panel_orientation_property( > &connector->base, > connector->panel.fixed_mode->hdisplay, > -- > 2.23.0
Hi all, On 16-12-2019 21:55, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915/dsi: Remove readback of panel orientation on BYT / CHT (rev2) > URL : https://patchwork.freedesktop.org/series/70952/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7574_full -> Patchwork_15786_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_15786_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_15786_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_15786_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@kms_big_fb@linear-16bpp-rotate-180: > - shard-tglb: [PASS][1] -> [DMESG-WARN][2] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb3/igt@kms_big_fb@linear-16bpp-rotate-180.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb8/igt@kms_big_fb@linear-16bpp-rotate-180.html False positive, the dmesg-warn is a lockdep splat and this patch does not touch any locking. Regards, Hans > > > > ### Piglit changes ### > > #### Possible regressions #### > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 2 (NEW): > - {pig-hsw-4770r}: NOTRUN -> [FAIL][3] +19 similar issues > [3]: None > > > New tests > --------- > > New tests have been introduced between CI_DRM_7574_full and Patchwork_15786_full: > > ### New Piglit tests (20) ### > > * object namespace pollution@texture with glcopyimagesubdata: > - Statuses : 1 fail(s) > - Exec time: [0.10] s > > * spec@arb_gpu_shader5@texturegather@vs-rgba-1-float-cubearray: > - Statuses : 1 fail(s) > - Exec time: [1.95] s > > * spec@arb_query_buffer_object@coherency: > - Statuses : 1 fail(s) > - Exec time: [5.09] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 42 8 64 3: > - Statuses : 1 fail(s) > - Exec time: [0.11] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 42 8 64 8: > - Statuses : 1 fail(s) > - Exec time: [0.08] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 32 42 8 8 8: > - Statuses : 1 fail(s) > - Exec time: [0.12] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 1: > - Statuses : 1 fail(s) > - Exec time: [0.26] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 128 8: > - Statuses : 1 fail(s) > - Exec time: [0.24] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 64 1: > - Statuses : 1 fail(s) > - Exec time: [0.23] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 64 4: > - Statuses : 1 fail(s) > - Exec time: [0.33] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 8 1: > - Statuses : 1 fail(s) > - Exec time: [0.22] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 8 3: > - Statuses : 1 fail(s) > - Exec time: [0.25] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 8 4: > - Statuses : 1 fail(s) > - Exec time: [0.24] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 8 7: > - Statuses : 1 fail(s) > - Exec time: [0.24] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 1 8 8 8: > - Statuses : 1 fail(s) > - Exec time: [0.28] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 128 7: > - Statuses : 1 fail(s) > - Exec time: [0.17] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 128 8: > - Statuses : 1 fail(s) > - Exec time: [0.18] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 2: > - Statuses : 1 fail(s) > - Exec time: [0.18] s > > * spec@arb_texture_barrier@arb_texture_barrier-blending-in-shader 512 42 1 8 8: > - Statuses : 1 fail(s) > - Exec time: [0.13] s > > * spec@arb_vertex_attrib_64bit@execution@vs_in@vs-input-position-uint_uvec2_array3-double_dmat3x2: > - Statuses : 1 fail(s) > - Exec time: [0.18] s > > > > Known issues > ------------ > > Here are the changes found in Patchwork_15786_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_ctx_isolation@vcs1-reset: > - shard-iclb: [PASS][4] -> [SKIP][5] ([fdo#109276] / [fdo#112080]) +1 similar issue > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb2/igt@gem_ctx_isolation@vcs1-reset.html > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb8/igt@gem_ctx_isolation@vcs1-reset.html > > * igt@gem_ctx_isolation@vecs0-s3: > - shard-tglb: [PASS][6] -> [INCOMPLETE][7] ([i915#456]) > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb7/igt@gem_ctx_isolation@vecs0-s3.html > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb5/igt@gem_ctx_isolation@vecs0-s3.html > > * igt@gem_ctx_persistence@processes: > - shard-skl: [PASS][8] -> [FAIL][9] ([i915#570]) > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-skl10/igt@gem_ctx_persistence@processes.html > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-skl3/igt@gem_ctx_persistence@processes.html > > * igt@gem_eio@suspend: > - shard-tglb: [PASS][10] -> [INCOMPLETE][11] ([i915#460]) +1 similar issue > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb3/igt@gem_eio@suspend.html > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb8/igt@gem_eio@suspend.html > > * igt@gem_exec_await@wide-contexts: > - shard-tglb: [PASS][12] -> [INCOMPLETE][13] ([fdo#111736]) > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb7/igt@gem_exec_await@wide-contexts.html > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb6/igt@gem_exec_await@wide-contexts.html > > * igt@gem_exec_balancer@smoke: > - shard-iclb: [PASS][14] -> [SKIP][15] ([fdo#110854]) > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb2/igt@gem_exec_balancer@smoke.html > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb8/igt@gem_exec_balancer@smoke.html > > * igt@gem_exec_parallel@fds: > - shard-tglb: [PASS][16] -> [INCOMPLETE][17] ([i915#470]) > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb3/igt@gem_exec_parallel@fds.html > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb6/igt@gem_exec_parallel@fds.html > > * igt@gem_exec_schedule@in-order-bsd: > - shard-iclb: [PASS][18] -> [SKIP][19] ([fdo#112146]) +2 similar issues > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb5/igt@gem_exec_schedule@in-order-bsd.html > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb2/igt@gem_exec_schedule@in-order-bsd.html > > * igt@gem_exec_schedule@preempt-queue-contexts-vebox: > - shard-tglb: [PASS][20] -> [INCOMPLETE][21] ([fdo#111677]) > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb2/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-vebox.html > > * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing: > - shard-iclb: [PASS][22] -> [INCOMPLETE][23] ([i915#140] / [i915#530]) > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb4/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html > > * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive: > - shard-hsw: [PASS][24] -> [TIMEOUT][25] ([i915#530]) > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-hsw1/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html > > * igt@gem_persistent_relocs@forked-thrashing: > - shard-tglb: [PASS][26] -> [TIMEOUT][27] ([i915#530]) > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb2/igt@gem_persistent_relocs@forked-thrashing.html > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb5/igt@gem_persistent_relocs@forked-thrashing.html > > * igt@gem_userptr_blits@sync-unmap-after-close: > - shard-snb: [PASS][28] -> [DMESG-WARN][29] ([fdo#111870]) +1 similar issue > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-snb1/igt@gem_userptr_blits@sync-unmap-after-close.html > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-snb5/igt@gem_userptr_blits@sync-unmap-after-close.html > > * igt@i915_selftest@mock_sanitycheck: > - shard-hsw: [PASS][30] -> [DMESG-WARN][31] ([i915#747]) > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-hsw7/igt@i915_selftest@mock_sanitycheck.html > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-hsw7/igt@i915_selftest@mock_sanitycheck.html > - shard-snb: [PASS][32] -> [DMESG-WARN][33] ([i915#747]) > [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-snb4/igt@i915_selftest@mock_sanitycheck.html > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-snb1/igt@i915_selftest@mock_sanitycheck.html > > * igt@kms_color@pipe-a-ctm-negative: > - shard-skl: [PASS][34] -> [DMESG-WARN][35] ([i915#109]) > [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-skl2/igt@kms_color@pipe-a-ctm-negative.html > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-skl6/igt@kms_color@pipe-a-ctm-negative.html > > * igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding: > - shard-skl: [PASS][36] -> [FAIL][37] ([i915#54]) +4 similar issues > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html > > * igt@kms_flip@flip-vs-expired-vblank: > - shard-skl: [PASS][38] -> [FAIL][39] ([i915#79]) +1 similar issue > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html > > * igt@kms_flip@flip-vs-expired-vblank-interruptible: > - shard-glk: [PASS][40] -> [FAIL][41] ([i915#79]) > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html > > * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: > - shard-tglb: [PASS][42] -> [FAIL][43] ([i915#49]) +1 similar issue > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html > > * igt@kms_frontbuffer_tracking@fbc-suspend: > - shard-tglb: [PASS][44] -> [INCOMPLETE][45] ([i915#456] / [i915#460] / [i915#474]) > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-suspend.html > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move: > - shard-iclb: [PASS][46] -> [INCOMPLETE][47] ([i915#123] / [i915#140]) > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move.html > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move.html > > * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping: > - shard-skl: [PASS][48] -> [INCOMPLETE][49] ([i915#648] / [i915#667]) > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-skl9/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-skl5/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html > > * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: > - shard-skl: [PASS][50] -> [FAIL][51] ([fdo#108145]) > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html > > * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: > - shard-skl: [PASS][52] -> [FAIL][53] ([fdo#108145] / [i915#265]) > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > > * igt@kms_psr@psr2_primary_mmap_cpu: > - shard-iclb: [PASS][54] -> [SKIP][55] ([fdo#109441]) +1 similar issue > [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html > [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html > > * igt@kms_vblank@pipe-a-ts-continuation-suspend: > - shard-kbl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +7 similar issues > [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html > [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html > - shard-apl: [PASS][58] -> [DMESG-WARN][59] ([i915#180]) +2 similar issues > [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html > [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html > > * igt@kms_vblank@pipe-c-ts-continuation-suspend: > - shard-tglb: [PASS][60] -> [INCOMPLETE][61] ([i915#456] / [i915#460]) +2 similar issues > [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html > [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html > > * igt@perf@disabled-read-error: > - shard-hsw: [PASS][62] -> [INCOMPLETE][63] ([i915#61]) +1 similar issue > [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-hsw7/igt@perf@disabled-read-error.html > [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-hsw8/igt@perf@disabled-read-error.html > > * igt@perf_pmu@busy-accuracy-98-vcs1: > - shard-iclb: [PASS][64] -> [SKIP][65] ([fdo#112080]) +2 similar issues > [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb2/igt@perf_pmu@busy-accuracy-98-vcs1.html > [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb8/igt@perf_pmu@busy-accuracy-98-vcs1.html > > * igt@prime_vgem@fence-wait-bsd2: > - shard-iclb: [PASS][66] -> [SKIP][67] ([fdo#109276]) +3 similar issues > [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html > [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb8/igt@prime_vgem@fence-wait-bsd2.html > > > #### Possible fixes #### > > * igt@gem_ctx_persistence@vcs1-mixed-process: > - shard-iclb: [SKIP][68] ([fdo#109276] / [fdo#112080]) -> [PASS][69] > [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb5/igt@gem_ctx_persistence@vcs1-mixed-process.html > [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed-process.html > > * igt@gem_ctx_shared@q-smoketest-bsd1: > - shard-tglb: [INCOMPLETE][70] ([fdo#111735]) -> [PASS][71] > [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb9/igt@gem_ctx_shared@q-smoketest-bsd1.html > [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb5/igt@gem_ctx_shared@q-smoketest-bsd1.html > > * {igt@gem_exec_schedule@pi-userfault-bsd}: > - shard-iclb: [SKIP][72] ([i915#677]) -> [PASS][73] > [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb2/igt@gem_exec_schedule@pi-userfault-bsd.html > [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb8/igt@gem_exec_schedule@pi-userfault-bsd.html > > * igt@gem_exec_schedule@preempt-other-chain-bsd: > - shard-iclb: [SKIP][74] ([fdo#112146]) -> [PASS][75] +1 similar issue > [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html > [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html > > * igt@gem_exec_schedule@preempt-queue-bsd2: > - shard-iclb: [SKIP][76] ([fdo#109276]) -> [PASS][77] +6 similar issues > [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd2.html > [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd2.html > > * igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive: > - shard-glk: [TIMEOUT][78] ([i915#530]) -> [PASS][79] > [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-glk7/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html > [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-glk4/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html > > * igt@gem_softpin@noreloc-s3: > - shard-apl: [DMESG-WARN][80] ([i915#180]) -> [PASS][81] +1 similar issue > [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-apl8/igt@gem_softpin@noreloc-s3.html > [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-apl4/igt@gem_softpin@noreloc-s3.html > > * igt@gem_userptr_blits@sync-unmap-cycles: > - shard-snb: [DMESG-WARN][82] ([fdo#111870]) -> [PASS][83] +1 similar issue > [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-snb4/igt@gem_userptr_blits@sync-unmap-cycles.html > [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html > > * igt@i915_suspend@fence-restore-untiled: > - shard-kbl: [DMESG-WARN][84] ([i915#180]) -> [PASS][85] +1 similar issue > [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-kbl2/igt@i915_suspend@fence-restore-untiled.html > [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-kbl7/igt@i915_suspend@fence-restore-untiled.html > > * igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen: > - shard-hsw: [DMESG-WARN][86] ([IGT#6]) -> [PASS][87] +1 similar issue > [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-hsw6/igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen.html > [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-hsw1/igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen.html > > * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding: > - shard-apl: [DMESG-WARN][88] ([IGT#6]) -> [PASS][89] > [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html > [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html > > * igt@kms_cursor_crc@pipe-c-cursor-suspend: > - shard-tglb: [INCOMPLETE][90] ([i915#456] / [i915#460]) -> [PASS][91] > [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html > [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html > > * igt@kms_flip@2x-dpms-vs-vblank-race: > - shard-hsw: [DMESG-FAIL][92] ([i915#407] / [i915#44]) -> [PASS][93] > [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-hsw5/igt@kms_flip@2x-dpms-vs-vblank-race.html > [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-hsw7/igt@kms_flip@2x-dpms-vs-vblank-race.html > > * igt@kms_flip@plain-flip-fb-recreate: > - shard-hsw: [DMESG-FAIL][94] ([i915#44]) -> [PASS][95] > [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-hsw5/igt@kms_flip@plain-flip-fb-recreate.html > [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-hsw6/igt@kms_flip@plain-flip-fb-recreate.html > > * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render: > - shard-iclb: [INCOMPLETE][96] ([i915#123] / [i915#140]) -> [PASS][97] > [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html > [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html > > * igt@perf@create-destroy-userspace-config: > - shard-hsw: [INCOMPLETE][98] ([i915#61]) -> [PASS][99] > [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-hsw6/igt@perf@create-destroy-userspace-config.html > [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-hsw7/igt@perf@create-destroy-userspace-config.html > > * igt@perf_pmu@busy-check-all-vcs1: > - shard-iclb: [SKIP][100] ([fdo#112080]) -> [PASS][101] > [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-iclb6/igt@perf_pmu@busy-check-all-vcs1.html > [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html > > > #### Warnings #### > > * igt@i915_pm_dc@dc6-dpms: > - shard-tglb: [FAIL][102] ([i915#454]) -> [SKIP][103] ([i915#468]) > [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7574/shard-tglb7/igt@i915_pm_dc@dc6-dpms.html > [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/shard-tglb6/igt@i915_pm_dc@dc6-dpms.html > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6 > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 > [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 > [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677 > [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735 > [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736 > [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 > [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 > [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 > [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 > [i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123 > [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140 > [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 > [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 > [i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407 > [i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44 > [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 > [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456 > [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460 > [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 > [i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470 > [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474 > [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 > [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530 > [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 > [i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570 > [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 > [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648 > [i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667 > [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 > [i915#747]: https://gitlab.freedesktop.org/drm/intel/issues/747 > [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 > > > Participating hosts (10 -> 11) > ------------------------------ > > Additional (1): pig-hsw-4770r > > > Build changes > ------------- > > * CI: CI-20190529 -> None > * Linux: CI_DRM_7574 -> Patchwork_15786 > > CI-20190529: 20190529 > CI_DRM_7574: 950244ca586c6f0efe243bf8c505c01ea5e579fa @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_15786: 668ae1782e77fe0fd8056e7936b76c08139112b7 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15786/index.html >
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c index 0ca49b1604c6..18f7616e6c27 100644 --- a/drivers/gpu/drm/i915/display/vlv_dsi.c +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c @@ -1563,59 +1563,6 @@ static const struct drm_connector_funcs intel_dsi_connector_funcs = { .atomic_duplicate_state = intel_digital_connector_duplicate_state, }; -static enum drm_panel_orientation -vlv_dsi_get_hw_panel_orientation(struct intel_connector *connector) -{ - struct drm_i915_private *dev_priv = to_i915(connector->base.dev); - struct intel_encoder *encoder = connector->encoder; - enum intel_display_power_domain power_domain; - enum drm_panel_orientation orientation; - struct intel_plane *plane; - struct intel_crtc *crtc; - intel_wakeref_t wakeref; - enum pipe pipe; - u32 val; - - if (!encoder->get_hw_state(encoder, &pipe)) - return DRM_MODE_PANEL_ORIENTATION_UNKNOWN; - - crtc = intel_get_crtc_for_pipe(dev_priv, pipe); - plane = to_intel_plane(crtc->base.primary); - - power_domain = POWER_DOMAIN_PIPE(pipe); - wakeref = intel_display_power_get_if_enabled(dev_priv, power_domain); - if (!wakeref) - return DRM_MODE_PANEL_ORIENTATION_UNKNOWN; - - val = I915_READ(DSPCNTR(plane->i9xx_plane)); - - if (!(val & DISPLAY_PLANE_ENABLE)) - orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN; - else if (val & DISPPLANE_ROTATE_180) - orientation = DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP; - else - orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL; - - intel_display_power_put(dev_priv, power_domain, wakeref); - - return orientation; -} - -static enum drm_panel_orientation -vlv_dsi_get_panel_orientation(struct intel_connector *connector) -{ - struct drm_i915_private *dev_priv = to_i915(connector->base.dev); - enum drm_panel_orientation orientation; - - if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) { - orientation = vlv_dsi_get_hw_panel_orientation(connector); - if (orientation != DRM_MODE_PANEL_ORIENTATION_UNKNOWN) - return orientation; - } - - return intel_dsi_get_panel_orientation(connector); -} - static void vlv_dsi_add_properties(struct intel_connector *connector) { struct drm_i915_private *dev_priv = to_i915(connector->base.dev); @@ -1633,7 +1580,7 @@ static void vlv_dsi_add_properties(struct intel_connector *connector) connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT; connector->base.display_info.panel_orientation = - vlv_dsi_get_panel_orientation(connector); + intel_dsi_get_panel_orientation(connector); drm_connector_init_panel_orientation_property( &connector->base, connector->panel.fixed_mode->hdisplay,
Commit 82daca297506 ("drm/i915: Add "panel orientation" property to the panel connector, v6.") uses hardware state readback to determine if the GOP is rotating the image by 180 degrees to compensate for upside-down mounted panels. When I wrote that commit I tried to find the VBT bits the GOP used to decide to rotate the image, but I could not find them. Back then I only looked at the rotation bits in struct mipi_config and these read 0 on the 1 BYT device I have with an upside-down mounted panel (a GP-electronic T701 tablet). While working on a similar problem on a BYT device with an eDP panel I noticed that the new intel_dsi_get_panel_orientation() helper which gets used on newer SoCs (Apollo-Lake, etc.) checks the rotate_180 bit in the BDB_GENERAL_FEATURES VBT block. I've checked and this bit indeed is set on the GP-electronic T701 tablet, so using the generic intel_dsi_get_panel_orientation() helper there does the right thing without needing any extra readback of hw state. This commit removes the special handling of the panel orientation for DSI panels on BYT/CHT devices, bringing the handling in line with the handling of DSI panels on other devices. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/i915/display/vlv_dsi.c | 55 +------------------------- 1 file changed, 1 insertion(+), 54 deletions(-)