From patchwork Tue Feb 18 22:02:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 11389829 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 60E3F1395 for ; Tue, 18 Feb 2020 22:03:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EA1A207FD for ; Tue, 18 Feb 2020 22:03:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="AYb70cRS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EA1A207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 59C306EA9F; Tue, 18 Feb 2020 22:03:36 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-yb1-xb43.google.com (mail-yb1-xb43.google.com [IPv6:2607:f8b0:4864:20::b43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 204626EA9E for ; Tue, 18 Feb 2020 22:03:33 +0000 (UTC) Received: by mail-yb1-xb43.google.com with SMTP id b4so511515ybk.11 for ; Tue, 18 Feb 2020 14:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4qNH+oSfqFDiH2zka2uZ4hJzeTVR/EM2vBf7regMnHc=; b=AYb70cRSStT7hJ5LEFO8cXFXuepTztaeDvLCDtdB1J1uZgtv4i/w5wmnHk3fH+QFJt Vqax+mDv9dTqokLITrmqqCogu27IYV69h1bySWRhS8eqY6gRsZrm4P1tHCPqiF3fiylL AucQoMP2Nc22vyrsYPSex7q373EZDNXd2or1xBnI+zZiFoMVCb2irVMgDbvaWozHNyUJ cMEvUDuXKPQI6dW8MWK+NVVhb8pSfvfXqp6J4SVM0xLZQblKBmuLG6zgVlkkqv3DeI5L AoL1UgoRXAMhudEgbfMf0lkBtt9QXkSxD7HTePlMClPSdbHrorG74SAuyVK9/mtaCY8J nk+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4qNH+oSfqFDiH2zka2uZ4hJzeTVR/EM2vBf7regMnHc=; b=UZSGrsg7MmUhqB4O+PZZSJDk3hJIBmZcQOPPU1W/izXDipLifBTT4epFZcLYad5j6K Yj93B2IM0APTMu9Juzgw81llj3ine+JoYIZ07i50poXwb63cgFfmyrfXyNjiCMUTHdj+ EG0UgYOFkRbhQvYsNtRULt6OA1Jbw8bvKSHQvbu6YHz0yG+pplbuLZ4ttH5LuLGCVK26 QLOHLtd8JSCnzy21ABeVn1a3SWLFPzzBnwwr5TR3uGNJ3QMSQTeSbd/bvFnwmQMa0HAZ Rl8i8cY0rYUm8QiRRMWS6Ef2gstoLaWQjmtXXWNGpdi1nUoFzIdc2aM7GbxQAi3i0A9d RTsg== X-Gm-Message-State: APjAAAXTO5Lzly9kABu1MKRF28aNRPMHLDpLoDp+N6rlPqWppSlpy6kn KCkMNbI6d3k9ck86PfbFKIbLYZLe/tg= X-Google-Smtp-Source: APXvYqwQWZnE3drxBc2jf/95A7ugFTExO8dzBboEUUhM9PPH0bsgsFMSypa/pmU0+MRcN2VtIgMa5w== X-Received: by 2002:a25:5c07:: with SMTP id q7mr22814879ybb.376.1582063412369; Tue, 18 Feb 2020 14:03:32 -0800 (PST) Received: from localhost ([2620:0:1013:11:1e1:4760:6ce4:fc64]) by smtp.gmail.com with ESMTPSA id v133sm11992ywb.86.2020.02.18.14.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 14:03:31 -0800 (PST) From: Sean Paul To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Tue, 18 Feb 2020 17:02:31 -0500 Message-Id: <20200218220242.107265-4-sean@poorly.run> X-Mailer: git-send-email 2.25.0.265.gbab2e86ba0-goog In-Reply-To: <20200218220242.107265-1-sean@poorly.run> References: <20200218220242.107265-1-sean@poorly.run> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v4 03/14] drm/i915: WARN if HDCP signalling is enabled upon disable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.vetter@ffwll.ch, Sean Paul Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Sean Paul HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä Cc: Daniel Vetter Reviewed-by: Ramalingam C Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-sean@poorly.run #v2 Link: https://patchwork.freedesktop.org/patch/msgid/20200117193103.156821-4-sean@poorly.run #v3 Changes in v2: -Added to the set in lieu of just clearing the bit Changes in v3: -None Changes in v4: -None --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index a1fd8fd67c855..fc84cd7c724fb 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -2013,6 +2013,8 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_state val = intel_de_read(dev_priv, TRANS_DDI_FUNC_CTL(cpu_transcoder)); val &= ~TRANS_DDI_FUNC_ENABLE; + WARN_ON(val & TRANS_DDI_HDCP_SIGNALLING); + if (INTEL_GEN(dev_priv) >= 12) { if (!intel_dp_mst_is_master_trans(crtc_state)) { val &= ~(TGL_TRANS_DDI_PORT_MASK |