| Message ID | 20200228114110.187792-3-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Some upside-down panel handling fixes | expand |
On Fri, Feb 28, 2020 at 12:41:10PM +0100, Hans de Goede wrote: > Some devices with a builtin panel have the panel mounted upside down, > this is indicated by the rotate_180 bit in the BDB_GENERAL_FEATURES VBT > block. > > We store this info in dev_priv->vbt.orientation, use this to set the > connector's orientation property so that fbcon and userspace will show > the image the right way up on devices with an upside-down mounted panel. > > This fixes the image being upside-down on a Teclast X89 tablet. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 2db8d46f61a1..c31f5233941c 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -7608,9 +7608,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, > intel_panel_setup_backlight(connector, pipe); > > if (fixed_mode) { > - /* We do not know the orientation, but their might be a quirk */ > drm_connector_set_panel_orientation_with_quirk(connector, > - DRM_MODE_PANEL_ORIENTATION_UNKNOWN, > + dev_priv->vbt.orientation, That's the non-DSI specific one I presume... yes. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > fixed_mode->hdisplay, fixed_mode->vdisplay); > } > > -- > 2.24.1
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 2db8d46f61a1..c31f5233941c 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -7608,9 +7608,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, intel_panel_setup_backlight(connector, pipe); if (fixed_mode) { - /* We do not know the orientation, but their might be a quirk */ drm_connector_set_panel_orientation_with_quirk(connector, - DRM_MODE_PANEL_ORIENTATION_UNKNOWN, + dev_priv->vbt.orientation, fixed_mode->hdisplay, fixed_mode->vdisplay); }
Some devices with a builtin panel have the panel mounted upside down, this is indicated by the rotate_180 bit in the BDB_GENERAL_FEATURES VBT block. We store this info in dev_priv->vbt.orientation, use this to set the connector's orientation property so that fbcon and userspace will show the image the right way up on devices with an upside-down mounted panel. This fixes the image being upside-down on a Teclast X89 tablet. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)