Message ID | 20200302222631.3861340-28-daniel.vetter@ffwll.ch (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm_device managed resources, v4 | expand |
On Mon, Mar 02, 2020 at 11:26:07PM +0100, Daniel Vetter wrote: > Small mistake that crept into > > commit 81da8c3b8d3df6f05b11300b7d17ccd1f3017fab > Author: Gerd Hoffmann <kraxel@redhat.com> > Date: Tue Feb 11 14:52:18 2020 +0100 > > drm/bochs: add drm_driver.release callback > > where drm_atomic_helper_shutdown was left in both places. The > ->release callback really shouldn't touch hardware. > > Cc: Gerd Hoffmann <kraxel@redhat.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Acked-by: Gerd Hoffmann <kraxel@redhat.com> > --- > drivers/gpu/drm/bochs/bochs_kms.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c > index 8066d7d370d5..e8cc8156d773 100644 > --- a/drivers/gpu/drm/bochs/bochs_kms.c > +++ b/drivers/gpu/drm/bochs/bochs_kms.c > @@ -166,6 +166,5 @@ void bochs_kms_fini(struct bochs_device *bochs) > if (!bochs->dev->mode_config.num_connector) > return; > > - drm_atomic_helper_shutdown(bochs->dev); > drm_mode_config_cleanup(bochs->dev); > } > -- > 2.24.1 >
diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index 8066d7d370d5..e8cc8156d773 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs/bochs_kms.c @@ -166,6 +166,5 @@ void bochs_kms_fini(struct bochs_device *bochs) if (!bochs->dev->mode_config.num_connector) return; - drm_atomic_helper_shutdown(bochs->dev); drm_mode_config_cleanup(bochs->dev); }
Small mistake that crept into commit 81da8c3b8d3df6f05b11300b7d17ccd1f3017fab Author: Gerd Hoffmann <kraxel@redhat.com> Date: Tue Feb 11 14:52:18 2020 +0100 drm/bochs: add drm_driver.release callback where drm_atomic_helper_shutdown was left in both places. The ->release callback really shouldn't touch hardware. Cc: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/bochs/bochs_kms.c | 1 - 1 file changed, 1 deletion(-)