| Message ID | 20200504225227.464666-7-matthew.d.roper@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce Rocket Lake | expand |
On Mon, May 04, 2020 at 03:52:11PM -0700, Matt Roper wrote: > The RKL platform has different memory characteristics from past > platforms. Update the values used by our memory bandwidth calculations > accordingly. > > Bspec: 53998 > Cc: James Ausmus <james.ausmus@intel.com> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com> > --- > drivers/gpu/drm/i915/display/intel_bw.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c > index 6e7cc3a4f1aa..d435cc6019e4 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -176,6 +176,12 @@ static const struct intel_sa_info tgl_sa_info = { > .displayrtids = 256, > }; > > +static const struct intel_sa_info rkl_sa_info = { > + .deburst = 16, > + .deprogbwlimit = 20, /* GB/s */ > + .displayrtids = 128, > +}; Numbers appear to match the spec. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > + > static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel_sa_info *sa) > { > struct intel_qgv_info qi = {}; > @@ -271,7 +277,9 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv) > if (!HAS_DISPLAY(dev_priv)) > return; > > - if (IS_GEN(dev_priv, 12)) > + if (IS_ROCKETLAKE(dev_priv)) > + icl_get_bw_info(dev_priv, &rkl_sa_info); > + else if (IS_GEN(dev_priv, 12)) > icl_get_bw_info(dev_priv, &tgl_sa_info); > else if (IS_GEN(dev_priv, 11)) > icl_get_bw_info(dev_priv, &icl_sa_info); > -- > 2.24.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index 6e7cc3a4f1aa..d435cc6019e4 100644 --- a/drivers/gpu/drm/i915/display/intel_bw.c +++ b/drivers/gpu/drm/i915/display/intel_bw.c @@ -176,6 +176,12 @@ static const struct intel_sa_info tgl_sa_info = { .displayrtids = 256, }; +static const struct intel_sa_info rkl_sa_info = { + .deburst = 16, + .deprogbwlimit = 20, /* GB/s */ + .displayrtids = 128, +}; + static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel_sa_info *sa) { struct intel_qgv_info qi = {}; @@ -271,7 +277,9 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv) if (!HAS_DISPLAY(dev_priv)) return; - if (IS_GEN(dev_priv, 12)) + if (IS_ROCKETLAKE(dev_priv)) + icl_get_bw_info(dev_priv, &rkl_sa_info); + else if (IS_GEN(dev_priv, 12)) icl_get_bw_info(dev_priv, &tgl_sa_info); else if (IS_GEN(dev_priv, 11)) icl_get_bw_info(dev_priv, &icl_sa_info);
The RKL platform has different memory characteristics from past platforms. Update the values used by our memory bandwidth calculations accordingly. Bspec: 53998 Cc: James Ausmus <james.ausmus@intel.com> Signed-off-by: Matt Roper <matthew.d.roper@intel.com> --- drivers/gpu/drm/i915/display/intel_bw.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)