| Message ID | 20200513182340.3968668-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Remove duplicate inline specifier on write_pte | expand |
Quoting Nathan Chancellor (2020-05-13 19:23:40) > When building with clang: > > drivers/gpu/drm/i915/gt/gen8_ppgtt.c:392:24: warning: duplicate > 'inline' declaration specifier [-Wduplicate-decl-specifier] > declaration specifier [-Wduplicate-decl-specifier] > static __always_inline inline void > ^ > include/linux/compiler_types.h:138:16: note: expanded from macro > 'inline' > #define inline inline __gnu_inline __inline_maybe_unused notrace > ^ > 1 warning generated. > > __always_inline is defined as 'inline __attribute__((__always_inline))' > so we do not need to specify it twice. > > Fixes: 84eac0c65940 ("drm/i915/gt: Force pte cacheline to main memory") > Link: https://github.com/ClangBuiltLinux/linux/issues/1024 > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> I forgot to ping Mika about this, Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c index 2dc88e76ebec..699125928272 100644 --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c @@ -389,7 +389,7 @@ static int gen8_ppgtt_alloc(struct i915_address_space *vm, return err; } -static __always_inline inline void +static __always_inline void write_pte(gen8_pte_t *pte, const gen8_pte_t val) { /* Magic delays? Or can we refine these to flush all in one pass? */
When building with clang: drivers/gpu/drm/i915/gt/gen8_ppgtt.c:392:24: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier] declaration specifier [-Wduplicate-decl-specifier] static __always_inline inline void ^ include/linux/compiler_types.h:138:16: note: expanded from macro 'inline' #define inline inline __gnu_inline __inline_maybe_unused notrace ^ 1 warning generated. __always_inline is defined as 'inline __attribute__((__always_inline))' so we do not need to specify it twice. Fixes: 84eac0c65940 ("drm/i915/gt: Force pte cacheline to main memory") Link: https://github.com/ClangBuiltLinux/linux/issues/1024 Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: e098d7762d602be640c53565ceca342f81e55ad2