| Message ID | 20200716145857.6911-1-uma.shankar@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/i915/display/fbc: Disable fbc by default on TGL | expand |
On Thu, Jul 16, 2020 at 08:28:57PM +0530, Uma Shankar wrote: > Fbc is causing random underruns in CI execution on TGL platforms. > Disabling the same while the problem is being debugged and analyzed. > > v2: Moved the check below the module param check (Ville) > > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Uma Shankar <uma.shankar@intel.com> Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c > index 3a4f980788a6..195b8be4532a 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbc.c > +++ b/drivers/gpu/drm/i915/display/intel_fbc.c > @@ -1426,6 +1426,13 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) > if (!HAS_FBC(dev_priv)) > return 0; > > + /* > + * Fbc is causing random underruns in CI execution on TGL platforms. > + * Disabling the same while the problem is being debugged and analyzed. > + */ > + if (IS_TIGERLAKE(dev_priv)) > + return 0; > + > if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) > return 1; > > -- > 2.22.0
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Thursday, July 16, 2020 9:13 PM
To: Shankar, Uma <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2)
Patch Details
Series:
drm/i915/display/fbc: Disable fbc by default on TGL (rev2)
URL:
https://patchwork.freedesktop.org/series/79541/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/index.html
CI Bug Log - changes from CI_DRM_8754 -> Patchwork_18191
Summary
FAILURE
Serious unknown changes coming with Patchwork_18191 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18191, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/index.html
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_18191:
IGT changes
Possible regressions
* igt@i915_selftest@live@execlists:
* fi-icl-u2: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-icl-u2/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-icl-u2/igt@i915_selftest@live@execlists.html>
Hi Lakshmi,
This is not related to this change, can you please help report it and trigger the CI run.
Regards,
Uma Shankar
Known issues
Here are the changes found in Patchwork_18191 that come from known issues:
IGT changes
Issues hit
* igt@gem_exec_suspend@basic-s3:
* fi-tgl-y: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) +2 similar issues
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
* fi-icl-u2: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)
Possible fixes
* igt@gem_flink_basic@basic:
* fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-y/igt@gem_flink_basic@basic.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-y/igt@gem_flink_basic@basic.html> +1 similar issue
* igt@i915_module_load@reload:
* fi-tgl-u2: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-u2/igt@i915_module_load@reload.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-u2/igt@i915_module_load@reload.html>
* igt@i915_pm_rpm@basic-pci-d3-state:
* {fi-tgl-dsi}: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-dsi/igt@i915_pm_rpm@basic-pci-d3-state.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-dsi/igt@i915_pm_rpm@basic-pci-d3-state.html>
* fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html>
* igt@i915_selftest@live@gem_contexts:
* fi-tgl-u2: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html> (i915#2045<https://gitlab.freedesktop.org/drm/intel/issues/2045>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html>
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
* fi-bsw-n3050: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html>
Warnings
* igt@kms_flip@basic-flip-vs-dpms@a-dp1:
* fi-kbl-x1275: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms@a-dp1.html> (i915#62<https://gitlab.freedesktop.org/drm/intel/issues/62> / i915#92<https://gitlab.freedesktop.org/drm/intel/issues/92> / i915#95<https://gitlab.freedesktop.org/drm/intel/issues/95>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms@a-dp1.html> (i915#62<https://gitlab.freedesktop.org/drm/intel/issues/62> / i915#92<https://gitlab.freedesktop.org/drm/intel/issues/92>) +3 similar issues
* igt@prime_vgem@basic-fence-flip:
* fi-kbl-x1275: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html> (i915#62<https://gitlab.freedesktop.org/drm/intel/issues/62> / i915#92<https://gitlab.freedesktop.org/drm/intel/issues/92>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html> (i915#62<https://gitlab.freedesktop.org/drm/intel/issues/62> / i915#92<https://gitlab.freedesktop.org/drm/intel/issues/92> / i915#95<https://gitlab.freedesktop.org/drm/intel/issues/95>) +4 similar issues
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Participating hosts (45 -> 40)
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
* Linux: CI_DRM_8754 -> Patchwork_18191
CI-20190529: 20190529
CI_DRM_8754: 5e2a3a9c4ca7fe59db74a1fffe29e6a2012e2225 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5738: bc8b56fe177af34fbde7b96f1f66614a0014c6ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18191: 4789b824888d4c8edf513cc6b86303f08ab83d1b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4789b824888d drm/i915/display/fbc: Disable fbc by default on TGL
Re-reported. From: Shankar, Uma <uma.shankar@intel.com> Sent: Thursday, July 16, 2020 6:51 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2) From: Patchwork <patchwork@emeril.freedesktop.org<mailto:patchwork@emeril.freedesktop.org>> Sent: Thursday, July 16, 2020 9:13 PM To: Shankar, Uma <uma.shankar@intel.com<mailto:uma.shankar@intel.com>> Cc: intel-gfx@lists.freedesktop.org<mailto:intel-gfx@lists.freedesktop.org> Subject: ✗ Fi.CI.BAT: failure for drm/i915/display/fbc: Disable fbc by default on TGL (rev2) Patch Details Series: drm/i915/display/fbc: Disable fbc by default on TGL (rev2) URL: https://patchwork.freedesktop.org/series/79541/ State: failure Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/index.html CI Bug Log - changes from CI_DRM_8754 -> Patchwork_18191 Summary FAILURE Serious unknown changes coming with Patchwork_18191 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_18191, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/index.html Possible new issues Here are the unknown changes that may have been introduced in Patchwork_18191: IGT changes Possible regressions * igt@i915_selftest@live@execlists: * fi-icl-u2: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-icl-u2/igt@i915_selftest@live@execlists.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-icl-u2/igt@i915_selftest@live@execlists.html> Hi Lakshmi, This is not related to this change, can you please help report it and trigger the CI run. Regards, Uma Shankar Known issues Here are the changes found in Patchwork_18191 that come from known issues: IGT changes Issues hit * igt@gem_exec_suspend@basic-s3: * fi-tgl-y: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) +2 similar issues * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy: * fi-icl-u2: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) Possible fixes * igt@gem_flink_basic@basic: * fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-y/igt@gem_flink_basic@basic.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-y/igt@gem_flink_basic@basic.html> +1 similar issue * igt@i915_module_load@reload: * fi-tgl-u2: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-u2/igt@i915_module_load@reload.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-u2/igt@i915_module_load@reload.html> * igt@i915_pm_rpm@basic-pci-d3-state: * {fi-tgl-dsi}: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-dsi/igt@i915_pm_rpm@basic-pci-d3-state.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-dsi/igt@i915_pm_rpm@basic-pci-d3-state.html> * fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html> * igt@i915_selftest@live@gem_contexts: * fi-tgl-u2: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html> (i915#2045<https://gitlab.freedesktop.org/drm/intel/issues/2045>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html> * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: * fi-bsw-n3050: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> Warnings * igt@kms_flip@basic-flip-vs-dpms@a-dp1: * fi-kbl-x1275: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms@a-dp1.html> (i915#62<https://gitlab.freedesktop.org/drm/intel/issues/62> / i915#92<https://gitlab.freedesktop.org/drm/intel/issues/92> / i915#95<https://gitlab.freedesktop.org/drm/intel/issues/95>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms@a-dp1.html> (i915#62<https://gitlab.freedesktop.org/drm/intel/issues/62> / i915#92<https://gitlab.freedesktop.org/drm/intel/issues/92>) +3 similar issues * igt@prime_vgem@basic-fence-flip: * fi-kbl-x1275: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8754/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html> (i915#62<https://gitlab.freedesktop.org/drm/intel/issues/62> / i915#92<https://gitlab.freedesktop.org/drm/intel/issues/92>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18191/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html> (i915#62<https://gitlab.freedesktop.org/drm/intel/issues/62> / i915#92<https://gitlab.freedesktop.org/drm/intel/issues/92> / i915#95<https://gitlab.freedesktop.org/drm/intel/issues/95>) +4 similar issues {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). Participating hosts (45 -> 40) Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper Build changes * Linux: CI_DRM_8754 -> Patchwork_18191 CI-20190529: 20190529 CI_DRM_8754: 5e2a3a9c4ca7fe59db74a1fffe29e6a2012e2225 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5738: bc8b56fe177af34fbde7b96f1f66614a0014c6ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18191: 4789b824888d4c8edf513cc6b86303f08ab83d1b @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 4789b824888d drm/i915/display/fbc: Disable fbc by default on TGL
> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > Sent: Thursday, July 16, 2020 8:15 PM > To: Shankar, Uma <uma.shankar@intel.com> > Cc: intel-gfx@lists.freedesktop.org; Lisovskiy, Stanislav > <stanislav.lisovskiy@intel.com> > Subject: Re: [v2] drm/i915/display/fbc: Disable fbc by default on TGL > > On Thu, Jul 16, 2020 at 08:28:57PM +0530, Uma Shankar wrote: > > Fbc is causing random underruns in CI execution on TGL platforms. > > Disabling the same while the problem is being debugged and analyzed. > > > > v2: Moved the check below the module param check (Ville) > > > > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Signed-off-by: Uma Shankar <uma.shankar@intel.com> > > Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> This is pushed to dinq. Thanks for the review. Regards, Uma Shankar > > --- > > drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c > b/drivers/gpu/drm/i915/display/intel_fbc.c > > index 3a4f980788a6..195b8be4532a 100644 > > --- a/drivers/gpu/drm/i915/display/intel_fbc.c > > +++ b/drivers/gpu/drm/i915/display/intel_fbc.c > > @@ -1426,6 +1426,13 @@ static int intel_sanitize_fbc_option(struct > drm_i915_private *dev_priv) > > if (!HAS_FBC(dev_priv)) > > return 0; > > > > + /* > > + * Fbc is causing random underruns in CI execution on TGL platforms. > > + * Disabling the same while the problem is being debugged and analyzed. > > + */ > > + if (IS_TIGERLAKE(dev_priv)) > > + return 0; > > + > > if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) > > return 1; > > > > -- > > 2.22.0 > > -- > Ville Syrjälä > Intel
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index 3a4f980788a6..195b8be4532a 100644 --- a/drivers/gpu/drm/i915/display/intel_fbc.c +++ b/drivers/gpu/drm/i915/display/intel_fbc.c @@ -1426,6 +1426,13 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) if (!HAS_FBC(dev_priv)) return 0; + /* + * Fbc is causing random underruns in CI execution on TGL platforms. + * Disabling the same while the problem is being debugged and analyzed. + */ + if (IS_TIGERLAKE(dev_priv)) + return 0; + if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) return 1;
Fbc is causing random underruns in CI execution on TGL platforms. Disabling the same while the problem is being debugged and analyzed. v2: Moved the check below the module param check (Ville) Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Uma Shankar <uma.shankar@intel.com> --- drivers/gpu/drm/i915/display/intel_fbc.c | 7 +++++++ 1 file changed, 7 insertions(+)