diff mbox series

[04/14] drm/i915: Add SKL GT1.5 PCI IDs

Message ID 20200716172106.2656-5-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: PCI ID cleanup | expand

Commit Message

Ville Syrjala July 16, 2020, 5:20 p.m. UTC 
From: Alexei Podtelezhnikov <apodtele@gmail.com>

Add three new devices 0x1913, 0x1915, and 0x1917 also known as
iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15.

Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
[vsyrjala: Split separate changes into separate patchs,
           Sort the IDs]
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 include/drm/i915_pciids.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Srivatsa, Anusha Sept. 24, 2020, 12:37 a.m. UTC | #1 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville
> Syrjala
> Sent: Thursday, July 16, 2020 10:21 AM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 04/14] drm/i915: Add SKL GT1.5 PCI IDs
> 
> From: Alexei Podtelezhnikov <apodtele@gmail.com>
> 
> Add three new devices 0x1913, 0x1915, and 0x1917 also known as
> iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15.
> 
> Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
> [vsyrjala: Split separate changes into separate patchs,
>            Sort the IDs]
The above comment appears in every patch. If this is v2 of the patches then it goes right after the commit message as:

 V2: Split separate changes into separate patches, sort the IDs (Ville)
 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
The code changes itself look good.

Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

> ---
>  include/drm/i915_pciids.h | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index
> 9df3697f074d..c906088ccffe 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -329,17 +329,20 @@
>  	INTEL_VGA_DEVICE(0x22b3, info)
> 
>  #define INTEL_SKL_ULT_GT1_IDS(info) \
> -	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
> +	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
> +	INTEL_VGA_DEVICE(0x1913, info)  /* ULT GT1.5 */
> 
>  #define INTEL_SKL_ULX_GT1_IDS(info) \
> -	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */
> +	INTEL_VGA_DEVICE(0x190E, info), /* ULX GT1 */ \
> +	INTEL_VGA_DEVICE(0x1915, info)  /* ULX GT1.5 */
> 
>  #define INTEL_SKL_GT1_IDS(info)	\
>  	INTEL_SKL_ULT_GT1_IDS(info), \
>  	INTEL_SKL_ULX_GT1_IDS(info), \
>  	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
>  	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
> -	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
> +	INTEL_VGA_DEVICE(0x190A, info), /* SRV GT1 */ \
> +	INTEL_VGA_DEVICE(0x1917, info)  /* DT  GT1.5 */
> 
>  #define INTEL_SKL_ULT_GT2_IDS(info) \
>  	INTEL_VGA_DEVICE(0x1916, info), /* ULT GT2 */ \
> --
> 2.26.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Ville Syrjala Sept. 24, 2020, 10:46 a.m. UTC | #2 
On Thu, Sep 24, 2020 at 12:37:47AM +0000, Srivatsa, Anusha wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville
> > Syrjala
> > Sent: Thursday, July 16, 2020 10:21 AM
> > To: intel-gfx@lists.freedesktop.org
> > Subject: [Intel-gfx] [PATCH 04/14] drm/i915: Add SKL GT1.5 PCI IDs
> > 
> > From: Alexei Podtelezhnikov <apodtele@gmail.com>
> > 
> > Add three new devices 0x1913, 0x1915, and 0x1917 also known as
> > iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15.
> > 
> > Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
> > [vsyrjala: Split separate changes into separate patchs,
> >            Sort the IDs]
> The above comment appears in every patch. If this is v2 of the patches then it goes right after the commit message as:
> 
>  V2: Split separate changes into separate patches, sort the IDs (Ville)

No. I use the [vsyrjala: blah] notation to indicate I modified the
original patch which was authored by someone else.

>  
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> The code changes itself look good.
> 
> Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> 
> > ---
> >  include/drm/i915_pciids.h | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index
> > 9df3697f074d..c906088ccffe 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -329,17 +329,20 @@
> >  	INTEL_VGA_DEVICE(0x22b3, info)
> > 
> >  #define INTEL_SKL_ULT_GT1_IDS(info) \
> > -	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
> > +	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
> > +	INTEL_VGA_DEVICE(0x1913, info)  /* ULT GT1.5 */
> > 
> >  #define INTEL_SKL_ULX_GT1_IDS(info) \
> > -	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */
> > +	INTEL_VGA_DEVICE(0x190E, info), /* ULX GT1 */ \
> > +	INTEL_VGA_DEVICE(0x1915, info)  /* ULX GT1.5 */
> > 
> >  #define INTEL_SKL_GT1_IDS(info)	\
> >  	INTEL_SKL_ULT_GT1_IDS(info), \
> >  	INTEL_SKL_ULX_GT1_IDS(info), \
> >  	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
> >  	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
> > -	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
> > +	INTEL_VGA_DEVICE(0x190A, info), /* SRV GT1 */ \
> > +	INTEL_VGA_DEVICE(0x1917, info)  /* DT  GT1.5 */
> > 
> >  #define INTEL_SKL_ULT_GT2_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x1916, info), /* ULT GT2 */ \
> > --
> > 2.26.2
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Srivatsa, Anusha Sept. 24, 2020, 5:54 p.m. UTC | #3 
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Thursday, September 24, 2020 3:46 AM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 04/14] drm/i915: Add SKL GT1.5 PCI IDs
> 
> On Thu, Sep 24, 2020 at 12:37:47AM +0000, Srivatsa, Anusha wrote:
> >
> >
> > > -----Original Message-----
> > > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf
> > > Of Ville Syrjala
> > > Sent: Thursday, July 16, 2020 10:21 AM
> > > To: intel-gfx@lists.freedesktop.org
> > > Subject: [Intel-gfx] [PATCH 04/14] drm/i915: Add SKL GT1.5 PCI IDs
> > >
> > > From: Alexei Podtelezhnikov <apodtele@gmail.com>
> > >
> > > Add three new devices 0x1913, 0x1915, and 0x1917 also known as
> > > iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15.
> > >
> > > Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
> > > [vsyrjala: Split separate changes into separate patchs,
> > >            Sort the IDs]
> > The above comment appears in every patch. If this is v2 of the patches
> then it goes right after the commit message as:
> >
> >  V2: Split separate changes into separate patches, sort the IDs
> > (Ville)
> 
> No. I use the [vsyrjala: blah] notation to indicate I modified the original
> patch which was authored by someone else.
> 
> >
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > The code changes itself look good.

Ah. Ok.
Makes sense

Anusha 
> > Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> >
> > > ---
> > >  include/drm/i915_pciids.h | 9 ++++++---
> > >  1 file changed, 6 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > > index 9df3697f074d..c906088ccffe 100644
> > > --- a/include/drm/i915_pciids.h
> > > +++ b/include/drm/i915_pciids.h
> > > @@ -329,17 +329,20 @@
> > >  	INTEL_VGA_DEVICE(0x22b3, info)
> > >
> > >  #define INTEL_SKL_ULT_GT1_IDS(info) \
> > > -	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
> > > +	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
> > > +	INTEL_VGA_DEVICE(0x1913, info)  /* ULT GT1.5 */
> > >
> > >  #define INTEL_SKL_ULX_GT1_IDS(info) \
> > > -	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */
> > > +	INTEL_VGA_DEVICE(0x190E, info), /* ULX GT1 */ \
> > > +	INTEL_VGA_DEVICE(0x1915, info)  /* ULX GT1.5 */
> > >
> > >  #define INTEL_SKL_GT1_IDS(info)	\
> > >  	INTEL_SKL_ULT_GT1_IDS(info), \
> > >  	INTEL_SKL_ULX_GT1_IDS(info), \
> > >  	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
> > >  	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
> > > -	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
> > > +	INTEL_VGA_DEVICE(0x190A, info), /* SRV GT1 */ \
> > > +	INTEL_VGA_DEVICE(0x1917, info)  /* DT  GT1.5 */
> > >
> > >  #define INTEL_SKL_ULT_GT2_IDS(info) \
> > >  	INTEL_VGA_DEVICE(0x1916, info), /* ULT GT2 */ \
> > > --
> > > 2.26.2
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Ville Syrjälä
> Intel
diff mbox series

Patch

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 9df3697f074d..c906088ccffe 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -329,17 +329,20 @@ 
 	INTEL_VGA_DEVICE(0x22b3, info)
 
 #define INTEL_SKL_ULT_GT1_IDS(info) \
-	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
+	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
+	INTEL_VGA_DEVICE(0x1913, info)  /* ULT GT1.5 */
 
 #define INTEL_SKL_ULX_GT1_IDS(info) \
-	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */
+	INTEL_VGA_DEVICE(0x190E, info), /* ULX GT1 */ \
+	INTEL_VGA_DEVICE(0x1915, info)  /* ULX GT1.5 */
 
 #define INTEL_SKL_GT1_IDS(info)	\
 	INTEL_SKL_ULT_GT1_IDS(info), \
 	INTEL_SKL_ULX_GT1_IDS(info), \
 	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
 	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
-	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
+	INTEL_VGA_DEVICE(0x190A, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x1917, info)  /* DT  GT1.5 */
 
 #define INTEL_SKL_ULT_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x1916, info), /* ULT GT2 */ \