| Message ID | 20200717141138.4a4289ac@xhacker.debian (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Don't force IOSF_MBI | expand |
Quoting Jisheng Zhang (2020-07-17 07:11:38) > The i915 doesn't depend on IOSF_MBI, asm/iosf_mbi.h already defines > isof_mbi_* APIs when ISOF_MBI is disabled. > > Don't force IOSF_MBI to allow disabling IOSF_MBI for non SoC platforms. But it is required for Valleyview/Cherryview and we want to support those by default. Tricky. -Chris
On Fri, 17 Jul 2020 20:32:44 +0100 Chris Wilson wrote: > > > Quoting Jisheng Zhang (2020-07-17 07:11:38) > > The i915 doesn't depend on IOSF_MBI, asm/iosf_mbi.h already defines > > isof_mbi_* APIs when ISOF_MBI is disabled. > > > > Don't force IOSF_MBI to allow disabling IOSF_MBI for non SoC platforms. > > But it is required for Valleyview/Cherryview and we want to support > those by default. Tricky. If linux kernel is built for Valleyview/Cherryview, ISOF_MBI has to be enabled. The dependency is met there. Thanks
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 9afa5c4a6bf0..b76874989292 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -21,7 +21,6 @@ config DRM_I915 select ACPI_VIDEO if ACPI select ACPI_BUTTON if ACPI select SYNC_FILE - select IOSF_MBI select CRC32 select SND_HDA_I915 if SND_HDA_CORE select CEC_CORE if CEC_NOTIFIER
The i915 doesn't depend on IOSF_MBI, asm/iosf_mbi.h already defines isof_mbi_* APIs when ISOF_MBI is disabled. Don't force IOSF_MBI to allow disabling IOSF_MBI for non SoC platforms. Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> --- drivers/gpu/drm/i915/Kconfig | 1 - 1 file changed, 1 deletion(-)