diff mbox series

[CI] drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling tests

Message ID 20200723153805.8076-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series [CI] drm/i915/selftests: Downgrade severity of CS/SRM frequency scaling tests | expand

Commit Message

Chris Wilson July 23, 2020, 3:38 p.m. UTC
Gracefully skip over the failures in the frequency scaling for the
moment, the results are under review.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/1754
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Sundaresan, Sujaritha" <sujaritha.sundaresan@intel.com>
Cc: "Ewins, Jon" <jon.ewins@intel.com>
Reviewed-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
 drivers/gpu/drm/i915/gt/selftest_rps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rodrigo Vivi Sept. 11, 2020, 8:27 p.m. UTC | #1
On Thu, Jul 23, 2020 at 04:38:05PM +0100, Chris Wilson wrote:
> Gracefully skip over the failures in the frequency scaling for the
> moment, the results are under review.

We need to clock gate media sampler to be able to scale the
frequency without getting throttled.

Reference: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6684

> 
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/1754
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Sundaresan, Sujaritha" <sujaritha.sundaresan@intel.com>
> Cc: "Ewins, Jon" <jon.ewins@intel.com>
> Reviewed-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/selftest_rps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index 8624f5d2a1f3..34b403d47840 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -700,7 +700,7 @@ int live_rps_frequency_cs(void *arg)
>  				f = act; /* may skip ahead [pcu granularity] */
>  			}
>  
> -			err = -EINVAL;
> +			err = -EINTR; /* ignore error, continue on with test */
>  		}
>  
>  err_vma:
> @@ -841,7 +841,7 @@ int live_rps_frequency_srm(void *arg)
>  				f = act; /* may skip ahead [pcu granularity] */
>  			}
>  
> -			err = -EINVAL;
> +			err = -EINTR; /* ignore error, continue on with test */
>  		}
>  
>  err_vma:
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
index 8624f5d2a1f3..34b403d47840 100644
--- a/drivers/gpu/drm/i915/gt/selftest_rps.c
+++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
@@ -700,7 +700,7 @@  int live_rps_frequency_cs(void *arg)
 				f = act; /* may skip ahead [pcu granularity] */
 			}
 
-			err = -EINVAL;
+			err = -EINTR; /* ignore error, continue on with test */
 		}
 
 err_vma:
@@ -841,7 +841,7 @@  int live_rps_frequency_srm(void *arg)
 				f = act; /* may skip ahead [pcu granularity] */
 			}
 
-			err = -EINVAL;
+			err = -EINTR; /* ignore error, continue on with test */
 		}
 
 err_vma: