diff mbox series

[1/7] drm/i915: Drop one more usless master_transcoder assignment

Message ID 20201019214337.19330-1-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [1/7] drm/i915: Drop one more usless master_transcoder assignment | expand

Commit Message

Ville Syrjala Oct. 19, 2020, 9:43 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We dropped the other redundant master_transcoder assignments
earlier, but this one slipped through. Get rid of it as well.
The crtc state gets fully reset before readout so there is
no point in doing this.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Navare, Manasi Oct. 19, 2020, 10:31 p.m. UTC | #1
On Tue, Oct 20, 2020 at 12:43:31AM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>

 
> We dropped the other redundant master_transcoder assignments
> earlier, but this one slipped through. Get rid of it as well.
> The crtc state gets fully reset before readout so there is
> no point in doing this.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Manasi

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 24d85b2689d5..30303088a344 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -11250,8 +11250,6 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
>  	bool active;
>  	u32 tmp;
>  
> -	pipe_config->master_transcoder = INVALID_TRANSCODER;
> -
>  	power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
>  	wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
>  	if (!wf)
> -- 
> 2.26.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 24d85b2689d5..30303088a344 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -11250,8 +11250,6 @@  static bool hsw_get_pipe_config(struct intel_crtc *crtc,
 	bool active;
 	u32 tmp;
 
-	pipe_config->master_transcoder = INVALID_TRANSCODER;
-
 	power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
 	wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
 	if (!wf)