diff mbox series

[CI,1/2] drm/i915/guc: skip disabling CTBs before sanitizing the GuC

Message ID 20201023222247.5926-1-daniele.ceraolospurio@intel.com
State New, archived
Headers show
Series [CI,1/2] drm/i915/guc: skip disabling CTBs before sanitizing the GuC | expand

Commit Message

Daniele Ceraolo Spurio Oct. 23, 2020, 10:22 p.m. UTC
If we're about to sanitize the GuC, something might have gone wrong
beforehand, so we should avoid trying to talk to it. Even if GuC is
still running fine, the sanitize will reset its internal state and clear
the CTB registration, so there is still no need to explicitly do so.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/2469
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
 drivers/gpu/drm/i915/gt/uc/intel_uc.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
diff mbox series


diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 4e6070e95fe9..309eef9313e8 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -486,7 +486,7 @@  static int __uc_init_hw(struct intel_uc *uc)
 	ret = intel_guc_sample_forcewake(guc);
 	if (ret)
-		goto err_communication;
+		goto err_log_capture;
 	if (intel_uc_uses_guc_submission(uc))
@@ -511,8 +511,6 @@  static int __uc_init_hw(struct intel_uc *uc)
 	 * We've failed to load the firmware :(
-	guc_disable_communication(guc);
@@ -540,9 +538,6 @@  static void __uc_fini_hw(struct intel_uc *uc)
 	if (intel_uc_uses_guc_submission(uc))
-	if (guc_communication_enabled(guc))
-		guc_disable_communication(guc);
@@ -559,7 +554,6 @@  void intel_uc_reset_prepare(struct intel_uc *uc)
 	if (!intel_guc_is_ready(guc))
-	guc_disable_communication(guc);