diff mbox series

[v3,1/6] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes

Message ID 20201028214232.5631-1-manasi.d.navare@intel.com
State New, archived
Headers show
Series [v3,1/6] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes | expand

Commit Message

Manasi Navare Oct. 28, 2020, 9:42 p.m. UTC
No functional changes. This patch just moves some mode checks
around to prepare for adding bigjoiner related mode validation

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Manasi Navare Oct. 28, 2020, 11:44 p.m. UTC | #1
I don’t see how these failures are related to the patch series

Manasi

From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Wednesday, October 28, 2020 4:31 PM
To: Navare, Manasi D <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.BAT: failure for series starting with [v3,1/6] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes

Patch Details
Series:

series starting with [v3,1/6] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes

URL:

https://patchwork.freedesktop.org/series/83173/

State:

failure

Details:

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/index.html

CI Bug Log - changes from CI_DRM_9214 -> Patchwork_18802
Summary

FAILURE

Serious unknown changes coming with Patchwork_18802 absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18802, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/index.html

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_18802:

IGT changes
Possible regressions

  *   igt@kms_force_connector_basic@force-load-detect:
     *   fi-hsw-4770: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-hsw-4770/igt@kms_force_connector_basic@force-load-detect.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-hsw-4770/igt@kms_force_connector_basic@force-load-detect.html>
     *   fi-elk-e7500: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-elk-e7500/igt@kms_force_connector_basic@force-load-detect.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-elk-e7500/igt@kms_force_connector_basic@force-load-detect.html>
     *   fi-ivb-3770: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-ivb-3770/igt@kms_force_connector_basic@force-load-detect.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-ivb-3770/igt@kms_force_connector_basic@force-load-detect.html>
     *   fi-byt-j1900: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-byt-j1900/igt@kms_force_connector_basic@force-load-detect.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-byt-j1900/igt@kms_force_connector_basic@force-load-detect.html>
     *   fi-blb-e6850: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-blb-e6850/igt@kms_force_connector_basic@force-load-detect.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-blb-e6850/igt@kms_force_connector_basic@force-load-detect.html>
     *   fi-ilk-650: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-ilk-650/igt@kms_force_connector_basic@force-load-detect.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-ilk-650/igt@kms_force_connector_basic@force-load-detect.html>
     *   fi-snb-2520m: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-snb-2520m/igt@kms_force_connector_basic@force-load-detect.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-snb-2520m/igt@kms_force_connector_basic@force-load-detect.html>
     *   fi-bwr-2160: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-bwr-2160/igt@kms_force_connector_basic@force-load-detect.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-bwr-2160/igt@kms_force_connector_basic@force-load-detect.html>
     *   fi-snb-2600: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-snb-2600/igt@kms_force_connector_basic@force-load-detect.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-snb-2600/igt@kms_force_connector_basic@force-load-detect.html>
  *   igt@runner@aborted:
     *   fi-pnv-d510: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-pnv-d510/igt@runner@aborted.html>
     *   fi-gdg-551: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-gdg-551/igt@runner@aborted.html>
     *   fi-bwr-2160: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-bwr-2160/igt@runner@aborted.html>
     *   fi-blb-e6850: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-blb-e6850/igt@runner@aborted.html>

New tests

New tests have been introduced between CI_DRM_9214 and Patchwork_18802:

New CI tests (1)

  *   boot:
     *   Statuses : 39 pass(s)
     *   Exec time: [0.0] s

Known issues

Here are the changes found in Patchwork_18802 that come from known issues:

IGT changes
Issues hit

  *   igt@i915_module_load@reload:
     *   fi-tgl-u2: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-tgl-u2/igt@i915_module_load@reload.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-tgl-u2/igt@i915_module_load@reload.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982> / k.org#205379<https://bugzilla.kernel.org/show_bug.cgi?id=205379>)
  *   igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
     *   fi-bsw-kefka: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)
  *   igt@kms_flip@basic-flip-vs-dpms@c-edp1:
     *   fi-tgl-y: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-tgl-y/igt@kms_flip@basic-flip-vs-dpms@c-edp1.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-tgl-y/igt@kms_flip@basic-flip-vs-dpms@c-edp1.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)
  *   igt@kms_force_connector_basic@force-load-detect:
     *   fi-pnv-d510: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-pnv-d510/igt@kms_force_connector_basic@force-load-detect.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-pnv-d510/igt@kms_force_connector_basic@force-load-detect.html> (i915#299<https://gitlab.freedesktop.org/drm/intel/issues/299>)
     *   fi-gdg-551: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-gdg-551/igt@kms_force_connector_basic@force-load-detect.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-gdg-551/igt@kms_force_connector_basic@force-load-detect.html> (i915#172<https://gitlab.freedesktop.org/drm/intel/issues/172>)
  *   igt@prime_self_import@basic-with_two_bos:
     *   fi-tgl-y: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) +1 similar issue

Possible fixes

  *   igt@debugfs_test@read_all_entries:
     *   fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-tgl-y/igt@debugfs_test@read_all_entries.html> (i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-tgl-y/igt@debugfs_test@read_all_entries.html> +2 similar issues
     *   {fi-kbl-7560u}: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html> (i915#2417<https://gitlab.freedesktop.org/drm/intel/issues/2417>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html>
  *   igt@i915_pm_rpm@basic-pci-d3-state:
     *   fi-apl-guc: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-apl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-apl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html>
  *   igt@kms_busy@basic@flip:
     *   fi-kbl-soraka: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-kbl-soraka/igt@kms_busy@basic@flip.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-kbl-soraka/igt@kms_busy@basic@flip.html>
     *   fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-tgl-y/igt@kms_busy@basic@flip.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-tgl-y/igt@kms_busy@basic@flip.html>

Warnings

  *   igt@gem_exec_suspend@basic-s3:
     *   fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html> (i915#2411<https://gitlab.freedesktop.org/drm/intel/issues/2411>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html> (i915#2411<https://gitlab.freedesktop.org/drm/intel/issues/2411> / i915#402<https://gitlab.freedesktop.org/drm/intel/issues/402>)
  *   igt@i915_pm_rpm@module-reload:
     *   fi-tgl-y: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9214/fi-tgl-y/igt@i915_pm_rpm@module-reload.html> (i915#2411<https://gitlab.freedesktop.org/drm/intel/issues/2411>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18802/fi-tgl-y/igt@i915_pm_rpm@module-reload.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982> / i915#2411<https://gitlab.freedesktop.org/drm/intel/issues/2411>)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (41 -> 39)

Missing (2): fi-bsw-cyan fi-bdw-samus

Build changes

  *   Linux: CI_DRM_9214 -> Patchwork_18802

CI-20190529: 20190529
CI_DRM_9214: c485050a56cf0edaed15b8297d5540bd0f4310b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5827: 7fd7e3fb8b42eb4e62a4575f6edc5a048e5bec3d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18802: 1388a0c36ca0a250e8f8dc39240096d044d5cb65 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

1388a0c36ca0 drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.
779bec036a45 drm/i915/dp: Prep for bigjoiner atomic check
a5f14d0b240f drm/i915: Pass intel_atomic_state instead of drm_atomic_state
f4900e21412a drm/i915: Add pipe_mode readout in verify_crtc_state
7b5090a4c566 drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split
29b307e050f4 drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 818daab252f3..2c29e7f5281b 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -721,6 +721,9 @@  intel_dp_mode_valid(struct drm_connector *connector,
 	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
 		return MODE_NO_DBLESCAN;
 
+	if (mode->flags & DRM_MODE_FLAG_DBLCLK)
+		return MODE_H_ILLEGAL;
+
 	if (intel_dp_is_edp(intel_dp) && fixed_mode) {
 		if (mode->hdisplay > fixed_mode->hdisplay)
 			return MODE_PANEL;
@@ -731,6 +734,9 @@  intel_dp_mode_valid(struct drm_connector *connector,
 		target_clock = fixed_mode->clock;
 	}
 
+	if (mode->clock < 10000)
+		return MODE_CLOCK_LOW;
+
 	max_link_clock = intel_dp_max_link_rate(intel_dp);
 	max_lanes = intel_dp_max_lane_count(intel_dp);
 
@@ -771,12 +777,6 @@  intel_dp_mode_valid(struct drm_connector *connector,
 	    target_clock > max_dotclk)
 		return MODE_CLOCK_HIGH;
 
-	if (mode->clock < 10000)
-		return MODE_CLOCK_LOW;
-
-	if (mode->flags & DRM_MODE_FLAG_DBLCLK)
-		return MODE_H_ILLEGAL;
-
 	status = intel_dp_mode_valid_downstream(intel_connector,
 						mode, target_clock);
 	if (status != MODE_OK)