| Message ID | 20201115210815.5272-6-sean.z.huang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/27] drm/i915/pxp: Introduce Intel PXP component | expand |
Quoting Huang, Sean Z (2020-11-15 23:07:54) > Rename the whitelist to allowlist as suggested This patch should really be a separate series and most likely needs to be done in one go to avoid confusion. $ git grep -E '(whitelist|blacklist)' | wc -l 173 The next patch also uses "passlist" terminology, highlighting the need to reach an agreement about which term to use. Regards, Joonas > Signed-off-by: Huang, Sean Z <sean.z.huang@intel.com> > --- > drivers/gpu/drm/i915/intel_uncore.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c > index 1c14a07eba7d..c9ef0025c60e 100644 > --- a/drivers/gpu/drm/i915/intel_uncore.c > +++ b/drivers/gpu/drm/i915/intel_uncore.c > @@ -1989,12 +1989,12 @@ void intel_uncore_fini_mmio(struct intel_uncore *uncore) > uncore_mmio_cleanup(uncore); > } > > -static const struct reg_whitelist { > +static const struct reg_allowlist { > i915_reg_t offset_ldw; > i915_reg_t offset_udw; > u16 gen_mask; > u8 size; > -} reg_read_whitelist[] = { { > +} reg_read_allowlist[] = { { > .offset_ldw = RING_TIMESTAMP(RENDER_RING_BASE), > .offset_udw = RING_TIMESTAMP_UDW(RENDER_RING_BASE), > .gen_mask = INTEL_GEN_MASK(4, 12), > @@ -2007,14 +2007,14 @@ int i915_reg_read_ioctl(struct drm_device *dev, > struct drm_i915_private *i915 = to_i915(dev); > struct intel_uncore *uncore = &i915->uncore; > struct drm_i915_reg_read *reg = data; > - struct reg_whitelist const *entry; > + struct reg_allowlist const *entry; > intel_wakeref_t wakeref; > unsigned int flags; > int remain; > int ret = 0; > > - entry = reg_read_whitelist; > - remain = ARRAY_SIZE(reg_read_whitelist); > + entry = reg_read_allowlist; > + remain = ARRAY_SIZE(reg_read_allowlist); > while (remain) { > u32 entry_offset = i915_mmio_reg_offset(entry->offset_ldw); > > -- > 2.17.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Joonas Lahtinen (2020-11-16 10:26:31) > Quoting Huang, Sean Z (2020-11-15 23:07:54) > > Rename the whitelist to allowlist as suggested > > This patch should really be a separate series and most likely needs to > be done in one go to avoid confusion. > > $ git grep -E '(whitelist|blacklist)' | wc -l > 173 > > The next patch also uses "passlist" terminology, highlighting the need > to reach an agreement about which term to use. (allow|deny)list is the trend. -Chris
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 1c14a07eba7d..c9ef0025c60e 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -1989,12 +1989,12 @@ void intel_uncore_fini_mmio(struct intel_uncore *uncore) uncore_mmio_cleanup(uncore); } -static const struct reg_whitelist { +static const struct reg_allowlist { i915_reg_t offset_ldw; i915_reg_t offset_udw; u16 gen_mask; u8 size; -} reg_read_whitelist[] = { { +} reg_read_allowlist[] = { { .offset_ldw = RING_TIMESTAMP(RENDER_RING_BASE), .offset_udw = RING_TIMESTAMP_UDW(RENDER_RING_BASE), .gen_mask = INTEL_GEN_MASK(4, 12), @@ -2007,14 +2007,14 @@ int i915_reg_read_ioctl(struct drm_device *dev, struct drm_i915_private *i915 = to_i915(dev); struct intel_uncore *uncore = &i915->uncore; struct drm_i915_reg_read *reg = data; - struct reg_whitelist const *entry; + struct reg_allowlist const *entry; intel_wakeref_t wakeref; unsigned int flags; int remain; int ret = 0; - entry = reg_read_whitelist; - remain = ARRAY_SIZE(reg_read_whitelist); + entry = reg_read_allowlist; + remain = ARRAY_SIZE(reg_read_allowlist); while (remain) { u32 entry_offset = i915_mmio_reg_offset(entry->offset_ldw);
Rename the whitelist to allowlist as suggested Signed-off-by: Huang, Sean Z <sean.z.huang@intel.com> --- drivers/gpu/drm/i915/intel_uncore.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)