From patchwork Mon Nov 16 13:59:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Lee, Shawn C" X-Patchwork-Id: 11908579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD60C4742C for ; Mon, 16 Nov 2020 13:54:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35BA622280 for ; Mon, 16 Nov 2020 13:54:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35BA622280 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9662D898CA; Mon, 16 Nov 2020 13:54:35 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D76F898CA for ; Mon, 16 Nov 2020 13:54:35 +0000 (UTC) IronPort-SDR: 9NSdeVTt0OprS/2k6R2thxPuRLABe0lpu5au64HsrfAs62UqzXhcFnf7lt8mPYNPrbCUkfssKR j/NNxRqqvVfQ== X-IronPort-AV: E=McAfee;i="6000,8403,9806"; a="234899062" X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="234899062" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 05:54:33 -0800 IronPort-SDR: oENBhCMp9K9wZjSl6V2TQeY/wUJEAp1VuqGBUTFxoRR4bhV94Ubb6282EJCfZGVfzwzHjSi0Vo DBoBbJPgjziQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="531852505" Received: from shawnle1-build-machine.itwn.intel.com ([10.5.253.9]) by fmsmga006.fm.intel.com with ESMTP; 16 Nov 2020 05:54:32 -0800 From: Lee Shawn C To: intel-gfx@lists.freedesktop.org Date: Mon, 16 Nov 2020 21:59:13 +0800 Message-Id: <20201116135913.20782-1-shawn.c.lee@intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cooper Chiou Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" After system boot up, LSPCON will be configured as PCON mode. But it never go into power saving state. Source driver can do the following. Then LSPCON can enter standby mode automatically to save more power. 1. At PCON mode, source driver write 0x2 to DPCD 600h. 2. At LS mode, try to disable DP_DUAL_MODE_TMDS_OEN. Cc: Ville Syrjälä Cc: Jani Nikula Cc: Uma Shankar Cc: Cooper Chiou Cc: Khaled Almahallawy Signed-off-by: Lee Shawn C --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++++++- drivers/gpu/drm/i915/display/intel_lspcon.c | 8 ++++++++ drivers/gpu/drm/i915/display/intel_lspcon.h | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index ec8359f03aaf..7dd16d6bd5ba 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -6536,6 +6536,7 @@ intel_dp_detect(struct drm_connector *connector, struct drm_i915_private *dev_priv = to_i915(connector->dev); struct intel_dp *intel_dp = intel_attached_dp(to_intel_connector(connector)); struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); + struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp); struct intel_encoder *encoder = &dig_port->base; enum drm_connector_status status; @@ -6632,9 +6633,13 @@ intel_dp_detect(struct drm_connector *connector, intel_dp_check_service_irq(intel_dp); out: - if (status != connector_status_connected && !intel_dp->is_mst) + if (status != connector_status_connected && !intel_dp->is_mst) { intel_dp_unset_edid(intel_dp); + if (lspcon && lspcon->active) + lspcon_standby(dp_to_dig_port(intel_dp)); + } + /* * Make sure the refs for power wells enabled during detect are * dropped to avoid a new detect cycle triggered by HPD polling. diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c index e37d45e531df..4913ff20d7b4 100644 --- a/drivers/gpu/drm/i915/display/intel_lspcon.c +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c @@ -550,6 +550,14 @@ static bool lspcon_init(struct intel_digital_port *dig_port) return true; } +void lspcon_standby(struct intel_digital_port *dig_port) +{ + struct intel_dp *dp = &dig_port->dp; + + if (drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, DP_SET_POWER_D3) <= 0) + DRM_DEBUG_KMS("Failed to write EDID checksum\n"); +} + void lspcon_resume(struct intel_digital_port *dig_port) { struct intel_lspcon *lspcon = &dig_port->lspcon; diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h index b03dcb7076d8..658a2e5b22db 100644 --- a/drivers/gpu/drm/i915/display/intel_lspcon.h +++ b/drivers/gpu/drm/i915/display/intel_lspcon.h @@ -16,6 +16,7 @@ struct intel_encoder; struct intel_lspcon; void lspcon_resume(struct intel_digital_port *dig_port); +void lspcon_standby(struct intel_digital_port *dig_port); void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon); void lspcon_write_infoframe(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state,