mbox series

[PULL] drm-intel-fixes

Message ID 20201203003624.GA1517510@intel.com (mailing list archive)
State New, archived
Headers show
Series [PULL] drm-intel-fixes | expand

Pull-request

git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2020-12-02

Message

Rodrigo Vivi Dec. 3, 2020, 12:36 a.m. UTC
Hi Dave and Daniel,

Fixes for GPU hang, null dereference, suspend-resume, power consumption, and use-after-free.

The commit 6db58901c2aa ("drm/i915/display: return earlier from intel_modeset_init() without display") was not actually a crucial fix, but it allowed a clean pick of the use-after-free one.

Here goes drm-intel-fixes-2020-12-02:

Fixes for GPU hang, null dereference, suspend-resume, power consumption, and use-after-free.

- Program mocs:63 for cache eviction on gen9 (Chris)
- Split the breadcrumb spinlock between global and contexts (Chris)
- Retain default context state across shrinking (Venkata)
- Limit frequency drop to RPe on parking (Chris)
- Return earlier from intel_modeset_init() without display (Jani)
- Defer initial modeset until after GGTT is initialized (Chris).

Thanks,
Rodrigo.

The following changes since commit b65054597872ce3aefbc6a666385eabdf9e288da:

  Linux 5.10-rc6 (2020-11-29 15:50:50 -0800)

are available in the Git repository at:

  git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2020-12-02

for you to fetch changes up to f2f2b21feadcb1eb08687a8b20dcf6442d22be18:

  drm/i915/display: Defer initial modeset until after GGTT is initialised (2020-12-01 08:36:37 -0800)

----------------------------------------------------------------
Fixes for GPU hang, null dereference, suspend-resume, power consumption, and use-after-free.

- Program mocs:63 for cache eviction on gen9 (Chris)
- Split the breadcrumb spinlock between global and contexts (Chris)
- Retain default context state across shrinking (Venkata)
- Limit frequency drop to RPe on parking (Chris)
- Return earlier from intel_modeset_init() without display (Jani)
- Defer initial modeset until after GGTT is initialized (Chris).

----------------------------------------------------------------
Chris Wilson (4):
      drm/i915/gt: Program mocs:63 for cache eviction on gen9
      drm/i915/gt: Split the breadcrumb spinlock between global and contexts
      drm/i915/gt: Limit frequency drop to RPe on parking
      drm/i915/display: Defer initial modeset until after GGTT is initialised

Jani Nikula (1):
      drm/i915/display: return earlier from intel_modeset_init() without display

Venkata Ramana Nayana (1):
      drm/i915/gt: Retain default context state across shrinking

 drivers/gpu/drm/i915/display/intel_display.c      |  24 ++--
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c       | 168 ++++++++++------------
 drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h |   6 +-
 drivers/gpu/drm/i915/gt/intel_context.c           |   3 +-
 drivers/gpu/drm/i915/gt/intel_context_types.h     |  12 +-
 drivers/gpu/drm/i915/gt/intel_mocs.c              |  14 +-
 drivers/gpu/drm/i915/gt/intel_rps.c               |   4 +
 drivers/gpu/drm/i915/gt/shmem_utils.c             |   7 +-
 drivers/gpu/drm/i915/i915_request.h               |   6 +-
 9 files changed, 124 insertions(+), 120 deletions(-)

Comments

Rodrigo Vivi Dec. 3, 2020, 1:07 a.m. UTC | #1
On Wed, Dec 02, 2020 at 04:36:24PM -0800, Rodrigo Vivi wrote:
> Hi Dave and Daniel,
> 
> Fixes for GPU hang, null dereference, suspend-resume, power consumption, and use-after-free.
> 
> The commit 6db58901c2aa ("drm/i915/display: return earlier from intel_modeset_init() without display") was not actually a crucial fix, but it allowed a clean pick of the use-after-free one.
> 
> Here goes drm-intel-fixes-2020-12-02:
> 
> Fixes for GPU hang, null dereference, suspend-resume, power consumption, and use-after-free.
> 
> - Program mocs:63 for cache eviction on gen9 (Chris)
> - Split the breadcrumb spinlock between global and contexts (Chris)

Please ignore this for now. I was informed that I missed one patch
that helps this one here. So I'm going to push a new fixes branch now
and will prepare another pull request tomorrow.

> - Retain default context state across shrinking (Venkata)
> - Limit frequency drop to RPe on parking (Chris)
> - Return earlier from intel_modeset_init() without display (Jani)
> - Defer initial modeset until after GGTT is initialized (Chris).
> 
> Thanks,
> Rodrigo.
> 
> The following changes since commit b65054597872ce3aefbc6a666385eabdf9e288da:
> 
>   Linux 5.10-rc6 (2020-11-29 15:50:50 -0800)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2020-12-02
> 
> for you to fetch changes up to f2f2b21feadcb1eb08687a8b20dcf6442d22be18:
> 
>   drm/i915/display: Defer initial modeset until after GGTT is initialised (2020-12-01 08:36:37 -0800)
> 
> ----------------------------------------------------------------
> Fixes for GPU hang, null dereference, suspend-resume, power consumption, and use-after-free.
> 
> - Program mocs:63 for cache eviction on gen9 (Chris)
> - Split the breadcrumb spinlock between global and contexts (Chris)
> - Retain default context state across shrinking (Venkata)
> - Limit frequency drop to RPe on parking (Chris)
> - Return earlier from intel_modeset_init() without display (Jani)
> - Defer initial modeset until after GGTT is initialized (Chris).
> 
> ----------------------------------------------------------------
> Chris Wilson (4):
>       drm/i915/gt: Program mocs:63 for cache eviction on gen9
>       drm/i915/gt: Split the breadcrumb spinlock between global and contexts
>       drm/i915/gt: Limit frequency drop to RPe on parking
>       drm/i915/display: Defer initial modeset until after GGTT is initialised
> 
> Jani Nikula (1):
>       drm/i915/display: return earlier from intel_modeset_init() without display
> 
> Venkata Ramana Nayana (1):
>       drm/i915/gt: Retain default context state across shrinking
> 
>  drivers/gpu/drm/i915/display/intel_display.c      |  24 ++--
>  drivers/gpu/drm/i915/gt/intel_breadcrumbs.c       | 168 ++++++++++------------
>  drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h |   6 +-
>  drivers/gpu/drm/i915/gt/intel_context.c           |   3 +-
>  drivers/gpu/drm/i915/gt/intel_context_types.h     |  12 +-
>  drivers/gpu/drm/i915/gt/intel_mocs.c              |  14 +-
>  drivers/gpu/drm/i915/gt/intel_rps.c               |   4 +
>  drivers/gpu/drm/i915/gt/shmem_utils.c             |   7 +-
>  drivers/gpu/drm/i915/i915_request.h               |   6 +-
>  9 files changed, 124 insertions(+), 120 deletions(-)