diff mbox series

[4/4] drm/i915/selftests: Include engine name after reset failure

Message ID 20210111105735.21515-4-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series [1/4] drm/i915/gt: Disable arbitration around Braswell's pdp updates | expand

Commit Message

Chris Wilson Jan. 11, 2021, 10:57 a.m. UTC
During igt_reset_nop_engine, an engine reset unexpectedly failed. For the
next time this happens, mention which engine that was.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Tvrtko Ursulin Jan. 11, 2021, 4:20 p.m. UTC | #1
On 11/01/2021 10:57, Chris Wilson wrote:
> During igt_reset_nop_engine, an engine reset unexpectedly failed. For the
> next time this happens, mention which engine that was.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> index 28f71cc2004d..09301e8b92c7 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> @@ -506,7 +506,8 @@ static int igt_reset_nop_engine(void *arg)
>   			}
>   			err = intel_engine_reset(engine, NULL);
>   			if (err) {
> -				pr_err("i915_reset_engine failed\n");
> +				pr_err("intel_engine_reset(%s) failed, err:%d\n",
> +				       engine->name, err);
>   				break;
>   			}
>   
> @@ -610,7 +611,8 @@ static int __igt_reset_engine(struct intel_gt *gt, bool active)
>   
>   			err = intel_engine_reset(engine, NULL);
>   			if (err) {
> -				pr_err("i915_reset_engine failed\n");
> +				pr_err("intel_engine_reset(%s) failed, err:%d\n",
> +				       engine->name, err);
>   				break;
>   			}
>   
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
index 28f71cc2004d..09301e8b92c7 100644
--- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
+++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
@@ -506,7 +506,8 @@  static int igt_reset_nop_engine(void *arg)
 			}
 			err = intel_engine_reset(engine, NULL);
 			if (err) {
-				pr_err("i915_reset_engine failed\n");
+				pr_err("intel_engine_reset(%s) failed, err:%d\n",
+				       engine->name, err);
 				break;
 			}
 
@@ -610,7 +611,8 @@  static int __igt_reset_engine(struct intel_gt *gt, bool active)
 
 			err = intel_engine_reset(engine, NULL);
 			if (err) {
-				pr_err("i915_reset_engine failed\n");
+				pr_err("intel_engine_reset(%s) failed, err:%d\n",
+				       engine->name, err);
 				break;
 			}