diff mbox series

drm/i915: Add DEBUG_GEM to the recommended CI config

Message ID 20210114111817.3849-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series drm/i915: Add DEBUG_GEM to the recommended CI config | expand

Commit Message

Chris Wilson Jan. 14, 2021, 11:18 a.m. UTC
Now that i915 compiles cleanly with Werror, we can enforce enabling
DEBUG_GEM when selecting the default debug config.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/Kconfig.debug | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Jani Nikula Jan. 22, 2021, 8:58 a.m. UTC | #1
On Thu, 14 Jan 2021, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Now that i915 compiles cleanly with Werror, we can enforce enabling
> DEBUG_GEM when selecting the default debug config.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/Kconfig.debug | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index 0fb7fd0ef717..3701bae5b855 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -39,10 +39,12 @@ config DRM_I915_DEBUG
>  	select DRM_DEBUG_SELFTEST
>  	select DMABUF_SELFTESTS
>  	select SW_SYNC # signaling validation framework (igt/syncobj*)
> +	select DRM_I915_WERROR

I think this line should be removed to fix [1]. Keep DRM_I915_WERROR
orthogonal.

BR,
Jani.


[1] http://lore.kernel.org/r/20210122115918.63b56fa1@canb.auug.org.au


> +	select DRM_I915_DEBUG_GEM
> +	select DRM_I915_DEBUG_MMIO
> +	select DRM_I915_DEBUG_RUNTIME_PM
>  	select DRM_I915_SW_FENCE_DEBUG_OBJECTS
>  	select DRM_I915_SELFTEST
> -	select DRM_I915_DEBUG_RUNTIME_PM
> -	select DRM_I915_DEBUG_MMIO
>  	select BROKEN # for prototype uAPI
>  	default n
>  	help
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index 0fb7fd0ef717..3701bae5b855 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -39,10 +39,12 @@  config DRM_I915_DEBUG
 	select DRM_DEBUG_SELFTEST
 	select DMABUF_SELFTESTS
 	select SW_SYNC # signaling validation framework (igt/syncobj*)
+	select DRM_I915_WERROR
+	select DRM_I915_DEBUG_GEM
+	select DRM_I915_DEBUG_MMIO
+	select DRM_I915_DEBUG_RUNTIME_PM
 	select DRM_I915_SW_FENCE_DEBUG_OBJECTS
 	select DRM_I915_SELFTEST
-	select DRM_I915_DEBUG_RUNTIME_PM
-	select DRM_I915_DEBUG_MMIO
 	select BROKEN # for prototype uAPI
 	default n
 	help