diff mbox series

[2/7] drm/i915: Remove dead TPS3->TPS2 fallback code

Message ID 20210114205046.8247-3-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Shuffle DP code around | expand

Commit Message

Ville Syrjälä Jan. 14, 2021, 8:50 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

If we ever get here with TPS3 then intel_dp_training_pattern()
is just broken. Replace the creful fallback with just
MISSING_CASE().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 6ed93cbef828..10930884ce42 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3148,11 +3148,9 @@  cpt_set_link_train(struct intel_dp *intel_dp,
 	case DP_TRAINING_PATTERN_2:
 		*DP |= DP_LINK_TRAIN_PAT_2_CPT;
 		break;
-	case DP_TRAINING_PATTERN_3:
-		drm_dbg_kms(&dev_priv->drm,
-			    "TPS3 not supported, using TPS2 instead\n");
-		*DP |= DP_LINK_TRAIN_PAT_2_CPT;
-		break;
+	default:
+		MISSING_CASE(intel_dp_training_pattern_symbol(dp_train_pat));
+		return;
 	}
 
 	intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);
@@ -3453,11 +3451,9 @@  g4x_set_link_train(struct intel_dp *intel_dp,
 	case DP_TRAINING_PATTERN_2:
 		*DP |= DP_LINK_TRAIN_PAT_2;
 		break;
-	case DP_TRAINING_PATTERN_3:
-		drm_dbg_kms(&dev_priv->drm,
-			    "TPS3 not supported, using TPS2 instead\n");
-		*DP |= DP_LINK_TRAIN_PAT_2;
-		break;
+	default:
+		MISSING_CASE(intel_dp_training_pattern_symbol(dp_train_pat));
+		return;
 	}
 
 	intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);