diff mbox series

[3/3] drm/i915/hdcp: disable the QSES check for HDCP2.2 over MST

Message ID 20210126200805.2499944-3-juston.li@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/3] drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg() | expand

Commit Message

Juston Li Jan. 26, 2021, 8:08 p.m. UTC 
Like the patch to disable QSES for HDCP 1.4 over MST
https://patchwork.freedesktop.org/patch/415297/ the HDCP2.2 spec
doesn't require QSES as well and we've seen QSES not supported on a
couple HDCP2.2 docks so far (Dell WD19 and Lenovo LDC-G2)

Remove it for now until we get a better idea of how widely supported
QSES is and how to support it optionally.

Signed-off-by: Juston Li <juston.li@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 31 +-------------------
 1 file changed, 1 insertion(+), 30 deletions(-)

Comments

kernel test robot Jan. 27, 2021, 7:39 a.m. UTC | #1 
Hi Juston,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210125]
[cannot apply to v5.11-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Juston-Li/drm-i915-hdcp-update-cp_irq_count_cached-in-intel_dp_hdcp2_read_msg/20210127-082615
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a003-20210126 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 74784a5aa47bb8967e5868831e359fa631abe465)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/46e1277aaec81a0c1a754855cc0f077f4ef866e0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Juston-Li/drm-i915-hdcp-update-cp_irq_count_cached-in-intel_dp_hdcp2_read_msg/20210127-082615
        git checkout 46e1277aaec81a0c1a754855cc0f077f4ef866e0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_dp_hdcp.c:709:9: error: implicit declaration of function 'intel_dp_mst_get_qses_status' [-Werror,-Wimplicit-function-declaration]
           return intel_dp_mst_get_qses_status(dig_port, connector);
                  ^
   1 error generated.


vim +/intel_dp_mst_get_qses_status +709 drivers/gpu/drm/i915/display/intel_dp_hdcp.c

1a67a168f57b68 Anshuman Gupta 2021-01-11  701  
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  702  static
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  703  bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  704  				  struct intel_connector *connector)
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  705  {
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  706  	if (!intel_dp_hdcp_check_link(dig_port, connector))
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  707  		return false;
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  708  
e9fd05c3e4f21a Anshuman Gupta 2021-01-11 @709  	return intel_dp_mst_get_qses_status(dig_port, connector);
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  710  }
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  711  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
kernel test robot Jan. 27, 2021, 11:54 p.m. UTC | #2 
Hi Juston,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210125]
[cannot apply to v5.11-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Juston-Li/drm-i915-hdcp-update-cp_irq_count_cached-in-intel_dp_hdcp2_read_msg/20210127-082615
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/46e1277aaec81a0c1a754855cc0f077f4ef866e0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Juston-Li/drm-i915-hdcp-update-cp_irq_count_cached-in-intel_dp_hdcp2_read_msg/20210127-082615
        git checkout 46e1277aaec81a0c1a754855cc0f077f4ef866e0
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/display/intel_dp_hdcp.c: In function 'intel_dp_mst_hdcp_check_link':
>> drivers/gpu/drm/i915/display/intel_dp_hdcp.c:709:9: error: implicit declaration of function 'intel_dp_mst_get_qses_status'; did you mean 'intel_dpll_get_hw_state'? [-Werror=implicit-function-declaration]
     709 |  return intel_dp_mst_get_qses_status(dig_port, connector);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |         intel_dpll_get_hw_state
   cc1: some warnings being treated as errors


vim +709 drivers/gpu/drm/i915/display/intel_dp_hdcp.c

1a67a168f57b68 Anshuman Gupta 2021-01-11  701  
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  702  static
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  703  bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  704  				  struct intel_connector *connector)
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  705  {
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  706  	if (!intel_dp_hdcp_check_link(dig_port, connector))
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  707  		return false;
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  708  
e9fd05c3e4f21a Anshuman Gupta 2021-01-11 @709  	return intel_dp_mst_get_qses_status(dig_port, connector);
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  710  }
e9fd05c3e4f21a Anshuman Gupta 2021-01-11  711  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
index e312aa8038ff..b7cb6948869e 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
@@ -699,30 +699,6 @@  intel_dp_mst_hdcp_stream_encryption(struct intel_connector *connector,
 	return 0;
 }
 
-static bool intel_dp_mst_get_qses_status(struct intel_digital_port *dig_port,
-					 struct intel_connector *connector)
-{
-	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
-	struct drm_dp_query_stream_enc_status_ack_reply reply;
-	struct intel_dp *intel_dp = &dig_port->dp;
-	int ret;
-
-	ret = drm_dp_send_query_stream_enc_status(&intel_dp->mst_mgr,
-						  connector->port, &reply);
-	if (ret) {
-		drm_dbg_kms(&i915->drm,
-			    "[%s:%d] failed QSES ret=%d\n",
-			    connector->base.name, connector->base.base.id, ret);
-		return false;
-	}
-
-	drm_dbg_kms(&i915->drm, "[%s:%d] QSES stream auth: %d stream enc: %d\n",
-		    connector->base.name, connector->base.base.id,
-		    reply.auth_completed, reply.encryption_enabled);
-
-	return reply.auth_completed && reply.encryption_enabled;
-}
-
 static
 bool intel_dp_mst_hdcp_check_link(struct intel_digital_port *dig_port,
 				  struct intel_connector *connector)
@@ -768,11 +744,6 @@  intel_dp_mst_hdcp2_stream_encryption(struct intel_connector *connector,
 	return 0;
 }
 
-/*
- * DP v2.0 I.3.3 ignore the stream signature L' in QSES reply msg reply.
- * I.3.5 MST source device may use a QSES msg to query downstream status
- * for a particular stream.
- */
 static
 int intel_dp_mst_hdcp2_check_link(struct intel_digital_port *dig_port,
 				  struct intel_connector *connector)
@@ -792,7 +763,7 @@  int intel_dp_mst_hdcp2_check_link(struct intel_digital_port *dig_port,
 			return ret;
 	}
 
-	return intel_dp_mst_get_qses_status(dig_port, connector) ? 0 : -EINVAL;
+	return 0;
 }
 
 static const struct intel_hdcp_shim intel_dp_mst_hdcp_shim = {