From patchwork Wed Feb 3 11:44:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tvrtko Ursulin X-Patchwork-Id: 12064161 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE387C433E6 for ; Wed, 3 Feb 2021 11:45:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 994A264F72 for ; Wed, 3 Feb 2021 11:45:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 994A264F72 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EEFC6EA7E; Wed, 3 Feb 2021 11:45:18 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3AEA6EA7D; Wed, 3 Feb 2021 11:45:16 +0000 (UTC) IronPort-SDR: 86eykhktsA4ecrNzlxQBI+66VKaETqyC1x4m+A44u22I3xRamCrpv7LDo7/pTR0Wub8gRjie5z +fIvaLOwOfwA== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="177519821" X-IronPort-AV: E=Sophos;i="5.79,398,1602572400"; d="scan'208";a="177519821" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 03:45:09 -0800 IronPort-SDR: EJeKohU5qVksynqvKfF2JAo1QWixegByRgrXFcp0NE4Vb6C3tZLhNHehNRkCXXJI1YRsXIojuI 3ipnOXrj25kw== X-IronPort-AV: E=Sophos;i="5.79,398,1602572400"; d="scan'208";a="392405899" Received: from eransege-mobl.ger.corp.intel.com (HELO localhost.localdomain) ([10.214.208.106]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 03:45:06 -0800 From: Tvrtko Ursulin To: igt-dev@lists.freedesktop.org Date: Wed, 3 Feb 2021 11:44:55 +0000 Message-Id: <20210203114456.895974-1-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t 1/2] intel_gpu_top: Show banner messages when cycling sort modes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Tvrtko Ursulin It is useful to let the user know what is the currently active sort mode. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- tools/intel_gpu_top.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 584aa21b198a..b409106f3718 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -1479,6 +1479,8 @@ print_header_token(const char *cont, int lines, int con_w, int con_h, int *rem, return lines; } +static const char *header_msg; + static int print_header(const struct igt_device_card *card, const char *codename, @@ -1593,8 +1595,14 @@ print_header(const struct igt_device_card *card, if (lines++ < con_h) printf("\n"); - if (lines++ < con_h) - printf("\n"); + if (lines++ < con_h) { + if (header_msg) { + printf(" >>> %s\n", header_msg); + header_msg = NULL; + } else { + printf("\n"); + } + } } return lines; @@ -2146,12 +2154,15 @@ static void select_client_sort(void) switch (++client_sort % 3) { case 0: client_cmp = client_last_cmp; + header_msg = "Sorting clients by current GPU usage."; break; case 1: client_cmp = client_total_cmp; + header_msg = "Sorting clients by accummulated GPU usage."; break; case 2: client_cmp = client_id_cmp; + header_msg = "Sorting clients by sysfs id."; } }